Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1615073 > unrolled thread

Re: [PATCH 9/9] [media] cx231xx: stop double error reporting

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 9/9] [media] cx231xx: stop double error reporting Wolfram Sang <wsa@the-dreams.de> - 2017-04-03 12:30 +0200

#1615073 — Re: [PATCH 9/9] [media] cx231xx: stop double error reporting

[Multipart message — attachments visible in raw view] — view raw

On Mon, Apr 03, 2017 at 10:38:38AM +0200, Peter Rosin wrote:
> i2c_mux_add_adapter already logs a message on failure.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  drivers/media/usb/cx231xx/cx231xx-i2c.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c
> index 35e9acfe63d3..dff514e147da 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c
> @@ -576,17 +576,10 @@ int cx231xx_i2c_mux_create(struct cx231xx *dev)
>  
>  int cx231xx_i2c_mux_register(struct cx231xx *dev, int mux_no)
>  {
> -	int rc;
> -
> -	rc = i2c_mux_add_adapter(dev->muxc,
> -				 0,
> -				 mux_no /* chan_id */,
> -				 0 /* class */);
> -	if (rc)
> -		dev_warn(dev->dev,
> -			 "i2c mux %d register FAILED\n", mux_no);
> -
> -	return rc;
> +	return i2c_mux_add_adapter(dev->muxc,
> +				   0,
> +				   mux_no /* chan_id */,
> +				   0 /* class */);

Could be argued that the whole function is obsolete now and the
c231xx-core can call i2c_mux_add_adapter() directly. But maybe this is a
seperate patch.

>  }
>  
>  void cx231xx_i2c_mux_unregister(struct cx231xx *dev)
> -- 
> 2.1.4
> 

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web