Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1615009 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-04-03 11:20 +0200 |
| Last post | 2017-04-03 11:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal' Colin King <colin.king@canonical.com> - 2017-04-03 11:20 +0200
Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal' Joe Perches <joe@perches.com> - 2017-04-03 11:30 +0200
Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal' Colin Ian King <colin.king@canonical.com> - 2017-04-03 11:50 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-04-03 11:20 +0200 |
| Subject | [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal' |
| Message-ID | <ts6jx-4Wo-27@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
trivial fix to spelling mistake in wl1271_warning error message
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
index 58e148d7bc7b..416080adc181 100644
--- a/drivers/net/wireless/ti/wlcore/debugfs.c
+++ b/drivers/net/wireless/ti/wlcore/debugfs.c
@@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file,
}
if (wl->conf.fwlog.output == 0) {
- wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf");
+ wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf");
return -EINVAL;
}
--
2.11.0
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-04-03 11:30 +0200 |
| Subject | Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal' |
| Message-ID | <ts6tb-4ZD-3@gated-at.bofh.it> |
| In reply to | #1615009 |
On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistake in wl1271_warning error message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
> index 58e148d7bc7b..416080adc181 100644
> --- a/drivers/net/wireless/ti/wlcore/debugfs.c
> +++ b/drivers/net/wireless/ti/wlcore/debugfs.c
> @@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file,
> }
>
> if (wl->conf.fwlog.output == 0) {
> - wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf");
> + wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf");
Hi Colin.
When you do these would you please fix all the typos on the
same line? opperation -> operation
Also, generally, invalid is a better word choice than illegal
for these situations.
Thanks and cheers, Joe
[toc] | [prev] | [next] | [standalone]
| From | Colin Ian King <colin.king@canonical.com> |
|---|---|
| Date | 2017-04-03 11:50 +0200 |
| Subject | Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal' |
| Message-ID | <ts6My-55V-9@gated-at.bofh.it> |
| In reply to | #1615012 |
On 03/04/17 10:20, Joe Perches wrote:
> On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> trivial fix to spelling mistake in wl1271_warning error message
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
>> index 58e148d7bc7b..416080adc181 100644
>> --- a/drivers/net/wireless/ti/wlcore/debugfs.c
>> +++ b/drivers/net/wireless/ti/wlcore/debugfs.c
>> @@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file,
>> }
>>
>> if (wl->conf.fwlog.output == 0) {
>> - wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf");
>> + wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf");
>
> Hi Colin.
>
> When you do these would you please fix all the typos on the
> same line? opperation -> operation
Sure, I stupidly missed that.
>
> Also, generally, invalid is a better word choice than illegal
> for these situations.
Good point.
>
> Thanks and cheers, Joe
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web