Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614533 > unrolled thread

[PATCH] iio: pressure: zpa2326: Remove unnecessary cast on void pointer

Back to article view | Back to linux.kernel

Contents

  [PATCH] iio: pressure: zpa2326: Remove unnecessary cast on void  pointer simran singhal <singhalsimran0@gmail.com> - 2017-04-01 16:20 +0200
    Re: [PATCH] iio: pressure: zpa2326: Remove unnecessary cast on void  pointer Jonathan Cameron <jic23@kernel.org> - 2017-04-02 11:00 +0200

#1614533 — [PATCH] iio: pressure: zpa2326: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T*)x)->f
|
- (T*)
  e
)

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/iio/pressure/zpa2326.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
index c720c3a..e58a0ad 100644
--- a/drivers/iio/pressure/zpa2326.c
+++ b/drivers/iio/pressure/zpa2326.c
@@ -751,7 +751,7 @@ static void zpa2326_suspend(struct iio_dev *indio_dev)
  */
 static irqreturn_t zpa2326_handle_irq(int irq, void *data)
 {
-	struct iio_dev *indio_dev = (struct iio_dev *)data;
+	struct iio_dev *indio_dev = data;
 
 	if (iio_buffer_enabled(indio_dev)) {
 		/* Timestamping needed for buffered sampling only. */
@@ -790,7 +790,7 @@ static irqreturn_t zpa2326_handle_irq(int irq, void *data)
  */
 static irqreturn_t zpa2326_handle_threaded_irq(int irq, void *data)
 {
-	struct iio_dev         *indio_dev = (struct iio_dev *)data;
+	struct iio_dev         *indio_dev = data;
 	struct zpa2326_private *priv = iio_priv(indio_dev);
 	unsigned int            val;
 	bool                    cont;
-- 
2.7.4

[toc] | [next] | [standalone]

#1614668

On 01/04/17 15:18, simran singhal wrote:
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> |
>   ((T *)x)[...]
> |
>   ((T*)x)->f
> |
> - (T*)
>   e
> )
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied and pushed out as testing as normal.

Thanks for these. Good to clean them up. It's one of my pet
hates, but still the sometimes get through ;)

Jonathan
> ---
>  drivers/iio/pressure/zpa2326.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
> index c720c3a..e58a0ad 100644
> --- a/drivers/iio/pressure/zpa2326.c
> +++ b/drivers/iio/pressure/zpa2326.c
> @@ -751,7 +751,7 @@ static void zpa2326_suspend(struct iio_dev *indio_dev)
>   */
>  static irqreturn_t zpa2326_handle_irq(int irq, void *data)
>  {
> -	struct iio_dev *indio_dev = (struct iio_dev *)data;
> +	struct iio_dev *indio_dev = data;
>  
>  	if (iio_buffer_enabled(indio_dev)) {
>  		/* Timestamping needed for buffered sampling only. */
> @@ -790,7 +790,7 @@ static irqreturn_t zpa2326_handle_irq(int irq, void *data)
>   */
>  static irqreturn_t zpa2326_handle_threaded_irq(int irq, void *data)
>  {
> -	struct iio_dev         *indio_dev = (struct iio_dev *)data;
> +	struct iio_dev         *indio_dev = data;
>  	struct zpa2326_private *priv = iio_priv(indio_dev);
>  	unsigned int            val;
>  	bool                    cont;
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web