Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1614331 > unrolled thread
| Started by | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| First post | 2017-04-01 01:50 +0200 |
| Last post | 2017-04-03 04:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net: ethernet: ti: cpsw: wake tx queues on ndo_tx_timeout Grygorii Strashko <grygorii.strashko@ti.com> - 2017-04-01 01:50 +0200
Re: [PATCH] net: ethernet: ti: cpsw: wake tx queues on ndo_tx_timeout David Miller <davem@davemloft.net> - 2017-04-03 04:50 +0200
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2017-04-01 01:50 +0200 |
| Subject | [PATCH] net: ethernet: ti: cpsw: wake tx queues on ndo_tx_timeout |
| Message-ID | <tresO-2Rp-3@gated-at.bofh.it> |
In case, if TX watchdog is fired some or all netdev TX queues will be stopped and as part of recovery it is required not only to drain and reinitailize CPSW TX channeles, but also wake up stoppted TX queues what doesn't happen now and netdevice will stop transmiting data until reopenned. Hence, add netif_tx_wake_all_queues() call in .ndo_tx_timeout() to complete recovery and restore TX path. Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 86d6f10..71fd4ef 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1819,6 +1819,8 @@ static void cpsw_ndo_tx_timeout(struct net_device *ndev) } cpsw_intr_enable(cpsw); + netif_trans_update(ndev); + netif_tx_wake_all_queues(ndev); } static int cpsw_ndo_set_mac_address(struct net_device *ndev, void *p) -- 2.10.1
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-04-03 04:50 +0200 |
| Subject | Re: [PATCH] net: ethernet: ti: cpsw: wake tx queues on ndo_tx_timeout |
| Message-ID | <ts0e5-Sj-1@gated-at.bofh.it> |
| In reply to | #1614331 |
From: Grygorii Strashko <grygorii.strashko@ti.com> Date: Fri, 31 Mar 2017 18:41:23 -0500 > In case, if TX watchdog is fired some or all netdev TX queues will be > stopped and as part of recovery it is required not only to drain and > reinitailize CPSW TX channeles, but also wake up stoppted TX queues what > doesn't happen now and netdevice will stop transmiting data until > reopenned. > > Hence, add netif_tx_wake_all_queues() call in .ndo_tx_timeout() to complete > recovery and restore TX path. > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> Applied, thank you.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web