Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1614605 > unrolled thread
| Started by | Nicolas Pitre <nicolas.pitre@linaro.org> |
|---|---|
| First post | 2017-04-02 00:40 +0200 |
| Last post | 2017-04-02 17:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 3/5] serial: small Makefile reordering Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-04-02 00:40 +0200
Re: [PATCH v2 3/5] serial: small Makefile reordering Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-02 15:00 +0200
Re: [PATCH v2 3/5] serial: small Makefile reordering Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-04-02 17:50 +0200
| From | Nicolas Pitre <nicolas.pitre@linaro.org> |
|---|---|
| Date | 2017-04-02 00:40 +0200 |
| Subject | [PATCH v2 3/5] serial: small Makefile reordering |
| Message-ID | <trzQB-lI-1@gated-at.bofh.it> |
Move 21285 entry down alongside other UART drivers to be more consistent with the rest of the file. It is kept before 8250 though, to preserve the existing link ordering between those two. Signed-off-by: Nicolas Pitre <nico@linaro.org> --- drivers/tty/serial/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile index 2d6288bc45..53c03e0051 100644 --- a/drivers/tty/serial/Makefile +++ b/drivers/tty/serial/Makefile @@ -3,7 +3,6 @@ # obj-$(CONFIG_SERIAL_CORE) += serial_core.o -obj-$(CONFIG_SERIAL_21285) += 21285.o obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o obj-$(CONFIG_SERIAL_EARLYCON_ARM_SEMIHOST) += earlycon-arm-semihost.o @@ -17,6 +16,8 @@ obj-$(CONFIG_SERIAL_SUNZILOG) += sunzilog.o obj-$(CONFIG_SERIAL_SUNSU) += sunsu.o obj-$(CONFIG_SERIAL_SUNSAB) += sunsab.o +obj-$(CONFIG_SERIAL_21285) += 21285.o + # Now bring in any enabled 8250/16450/16550 type drivers. obj-$(CONFIG_SERIAL_8250) += 8250/ -- 2.9.3
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-04-02 15:00 +0200 |
| Message-ID | <trNgR-zs-1@gated-at.bofh.it> |
| In reply to | #1614605 |
On Sun, Apr 2, 2017 at 1:21 AM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote: > Move 21285 entry down alongside other UART drivers to be more consistent > with the rest of the file. It is kept before 8250 though, to preserve the > existing link ordering between those two. I did once for entire Makefile (some logical reordering), but Greg objected it. Perhaps you can sell it better. http://www.spinics.net/lists/linux-serial/msg23616.html > > Signed-off-by: Nicolas Pitre <nico@linaro.org> > --- > drivers/tty/serial/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile > index 2d6288bc45..53c03e0051 100644 > --- a/drivers/tty/serial/Makefile > +++ b/drivers/tty/serial/Makefile > @@ -3,7 +3,6 @@ > # > > obj-$(CONFIG_SERIAL_CORE) += serial_core.o > -obj-$(CONFIG_SERIAL_21285) += 21285.o > > obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o > obj-$(CONFIG_SERIAL_EARLYCON_ARM_SEMIHOST) += earlycon-arm-semihost.o > @@ -17,6 +16,8 @@ obj-$(CONFIG_SERIAL_SUNZILOG) += sunzilog.o > obj-$(CONFIG_SERIAL_SUNSU) += sunsu.o > obj-$(CONFIG_SERIAL_SUNSAB) += sunsab.o > > +obj-$(CONFIG_SERIAL_21285) += 21285.o > + > # Now bring in any enabled 8250/16450/16550 type drivers. > obj-$(CONFIG_SERIAL_8250) += 8250/ > > -- > 2.9.3 > -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Nicolas Pitre <nicolas.pitre@linaro.org> |
|---|---|
| Date | 2017-04-02 17:50 +0200 |
| Message-ID | <trPVn-2kD-1@gated-at.bofh.it> |
| In reply to | #1614728 |
On Sun, 2 Apr 2017, Andy Shevchenko wrote: > On Sun, Apr 2, 2017 at 1:21 AM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote: > > Move 21285 entry down alongside other UART drivers to be more consistent > > with the rest of the file. It is kept before 8250 though, to preserve the > > existing link ordering between those two. > > I did once for entire Makefile (some logical reordering), but Greg > objected it. Perhaps you can sell it better. > http://www.spinics.net/lists/linux-serial/msg23616.html The 21285 entry is the only one that clearly is out of place. I suppose that the rest is debatable. > > > > > Signed-off-by: Nicolas Pitre <nico@linaro.org> > > --- > > drivers/tty/serial/Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile > > index 2d6288bc45..53c03e0051 100644 > > --- a/drivers/tty/serial/Makefile > > +++ b/drivers/tty/serial/Makefile > > @@ -3,7 +3,6 @@ > > # > > > > obj-$(CONFIG_SERIAL_CORE) += serial_core.o > > -obj-$(CONFIG_SERIAL_21285) += 21285.o > > > > obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o > > obj-$(CONFIG_SERIAL_EARLYCON_ARM_SEMIHOST) += earlycon-arm-semihost.o > > @@ -17,6 +16,8 @@ obj-$(CONFIG_SERIAL_SUNZILOG) += sunzilog.o > > obj-$(CONFIG_SERIAL_SUNSU) += sunsu.o > > obj-$(CONFIG_SERIAL_SUNSAB) += sunsab.o > > > > +obj-$(CONFIG_SERIAL_21285) += 21285.o > > + > > # Now bring in any enabled 8250/16450/16550 type drivers. > > obj-$(CONFIG_SERIAL_8250) += 8250/ > > > > -- > > 2.9.3 > > > > > > -- > With Best Regards, > Andy Shevchenko >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web