Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1611538 > unrolled thread
| Started by | Daniel Cashman <dan.a.cashman@gmail.com> |
|---|---|
| First post | 2017-03-29 05:40 +0200 |
| Last post | 2017-04-02 05:00 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Remove atomisp/i2c style errors. Daniel Cashman <dan.a.cashman@gmail.com> - 2017-03-29 05:40 +0200
Re: [PATCH] Remove atomisp/i2c style errors. Greg KH <gregkh@linuxfoundation.org> - 2017-03-29 09:10 +0200
[PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs. Daniel Cashman <dan.a.cashman@gmail.com> - 2017-03-29 19:10 +0200
Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs. Alan Cox <alan@linux.intel.com> - 2017-03-29 19:40 +0200
Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs. Daniel Cashman <dan.a.cashman@gmail.com> - 2017-04-02 05:00 +0200
| From | Daniel Cashman <dan.a.cashman@gmail.com> |
|---|---|
| Date | 2017-03-29 05:40 +0200 |
| Subject | [PATCH] Remove atomisp/i2c style errors. |
| Message-ID | <tqcCJ-11n-3@gated-at.bofh.it> |
From: Dan Cashman <dan.a.cashman@gmail.com>
Remove two ' , ' issues and change spaces to tabs found by poking around in
drivers/staging/. Warnings left untouched.
Test: Run checkpatch script in drivers/staging/media/atomisp/i2c before and
after change. Errors go from 3 to 0.
Signed-off-by: Dan Cashman <dan.a.cashman@gmail.com>
---
drivers/staging/media/atomisp/i2c/ap1302.c | 4 ++--
drivers/staging/media/atomisp/i2c/gc0310.c | 2 +-
drivers/staging/media/atomisp/i2c/gc2235.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c
index bacffbe..8432ee9 100644
--- a/drivers/staging/media/atomisp/i2c/ap1302.c
+++ b/drivers/staging/media/atomisp/i2c/ap1302.c
@@ -606,8 +606,8 @@ static s32 ap1302_try_mbus_fmt_locked(struct v4l2_subdev *sd,
static int ap1302_get_fmt(struct v4l2_subdev *sd,
- struct v4l2_subdev_pad_config *cfg,
- struct v4l2_subdev_format *format)
+ struct v4l2_subdev_pad_config *cfg,
+ struct v4l2_subdev_format *format)
{
struct v4l2_mbus_framefmt *fmt = &format->format;
diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c
index add8b90..1ec616a 100644
--- a/drivers/staging/media/atomisp/i2c/gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/gc0310.c
@@ -54,7 +54,7 @@ static int gc0310_read_reg(struct i2c_client *client,
return -EINVAL;
}
- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));
msg[0].addr = client->addr;
msg[0].flags = 0;
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/staging/media/atomisp/i2c/gc2235.c
index 9b41023..50f4317 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -55,7 +55,7 @@ static int gc2235_read_reg(struct i2c_client *client,
return -EINVAL;
}
- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));
msg[0].addr = client->addr;
msg[0].flags = 0;
--
2.7.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-03-29 09:10 +0200 |
| Message-ID | <tqfTX-3sX-3@gated-at.bofh.it> |
| In reply to | #1611538 |
On Tue, Mar 28, 2017 at 08:31:37PM -0700, Daniel Cashman wrote: > From: Dan Cashman <dan.a.cashman@gmail.com> Please list what the issue you fixed in the subject line. Also change the subject to match others for this driver, a 'git log' will show you what to do there. > > Remove two ' , ' issues and change spaces to tabs found by poking around in > drivers/staging/. Warnings left untouched. > > Test: Run checkpatch script in drivers/staging/media/atomisp/i2c before and > after change. Errors go from 3 to 0. This isn't needed, and really, you didn't test the code, only a random perl script :) thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Daniel Cashman <dan.a.cashman@gmail.com> |
|---|---|
| Date | 2017-03-29 19:10 +0200 |
| Subject | [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs. |
| Message-ID | <tqpgC-1u5-15@gated-at.bofh.it> |
| In reply to | #1611631 |
From: Dan Cashman <dan.a.cashman@gmail.com>
Signed-off-by: Dan Cashman <dan.a.cashman@gmail.com>
---
drivers/staging/media/atomisp/i2c/ap1302.c | 4 ++--
drivers/staging/media/atomisp/i2c/gc0310.c | 2 +-
drivers/staging/media/atomisp/i2c/gc2235.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c
index bacffbe..8432ee9 100644
--- a/drivers/staging/media/atomisp/i2c/ap1302.c
+++ b/drivers/staging/media/atomisp/i2c/ap1302.c
@@ -606,8 +606,8 @@ static s32 ap1302_try_mbus_fmt_locked(struct v4l2_subdev *sd,
static int ap1302_get_fmt(struct v4l2_subdev *sd,
- struct v4l2_subdev_pad_config *cfg,
- struct v4l2_subdev_format *format)
+ struct v4l2_subdev_pad_config *cfg,
+ struct v4l2_subdev_format *format)
{
struct v4l2_mbus_framefmt *fmt = &format->format;
diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c
index add8b90..1ec616a 100644
--- a/drivers/staging/media/atomisp/i2c/gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/gc0310.c
@@ -54,7 +54,7 @@ static int gc0310_read_reg(struct i2c_client *client,
return -EINVAL;
}
- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));
msg[0].addr = client->addr;
msg[0].flags = 0;
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/staging/media/atomisp/i2c/gc2235.c
index 9b41023..50f4317 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -55,7 +55,7 @@ static int gc2235_read_reg(struct i2c_client *client,
return -EINVAL;
}
- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));
msg[0].addr = client->addr;
msg[0].flags = 0;
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Alan Cox <alan@linux.intel.com> |
|---|---|
| Date | 2017-03-29 19:40 +0200 |
| Subject | Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs. |
| Message-ID | <tqpJE-1Fu-13@gated-at.bofh.it> |
| In reply to | #1612156 |
On Wed, 2017-03-29 at 09:57 -0700, Daniel Cashman wrote: > From: Dan Cashman <dan.a.cashman@gmail.com> > > Signed-off-by: Dan Cashman <dan.a.cashman@gmail.com> As the TODO asks - please no whitespace cleanups yet. They make it harder to keep other cleanups that fix (or mostly remove) code applying. Nothing wrong with the patch otherwise - but it should also have something in the commit message. Alan
[toc] | [prev] | [next] | [standalone]
| From | Daniel Cashman <dan.a.cashman@gmail.com> |
|---|---|
| Date | 2017-04-02 05:00 +0200 |
| Subject | Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs. |
| Message-ID | <trDUd-2Vl-1@gated-at.bofh.it> |
| In reply to | #1612178 |
My apologies; I did not review the TODO. Consider this withdrawn. Dan On 03/29/2017 10:30 AM, Alan Cox wrote: > On Wed, 2017-03-29 at 09:57 -0700, Daniel Cashman wrote: >> From: Dan Cashman <dan.a.cashman@gmail.com> >> >> Signed-off-by: Dan Cashman <dan.a.cashman@gmail.com> > > > As the TODO asks - please no whitespace cleanups yet. They make it > harder to keep other cleanups that fix (or mostly remove) code > applying. > > Nothing wrong with the patch otherwise - but it should also have > something in the commit message. > > Alan >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web