Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1613741 > unrolled thread
| Started by | Chewie Lin <linsh@oregonstate.edu> |
|---|---|
| First post | 2017-03-31 10:50 +0200 |
| Last post | 2017-04-01 05:30 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] drivers: fixed a checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-03-31 10:50 +0200
Re: [PATCH] drivers: fixed a checkpatch warning Greg KH <greg@kroah.com> - 2017-03-31 11:10 +0200
Re: [PATCH] drivers: fixed a checkpatch warning Joe Perches <joe@perches.com> - 2017-03-31 21:00 +0200
Re: [PATCH] drivers: fixed a checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-04-01 05:30 +0200
| From | Chewie Lin <linsh@oregonstate.edu> |
|---|---|
| Date | 2017-03-31 10:50 +0200 |
| Subject | [PATCH] drivers: fixed a checkpatch warning |
| Message-ID | <tr0pP-2e1-1@gated-at.bofh.it> |
fixed a coding style error/warning. Signed-off-by: Chewie Lin <linsh@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(&priv->usb->dev, - "usb_device_reset fail status=%d\n", status); + "%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0
[toc] | [next] | [standalone]
| From | Greg KH <greg@kroah.com> |
|---|---|
| Date | 2017-03-31 11:10 +0200 |
| Message-ID | <tr0Je-2AS-91@gated-at.bofh.it> |
| In reply to | #1613741 |
On Fri, Mar 31, 2017 at 01:40:29AM -0700, Chewie Lin wrote: > fixed a coding style error/warning. Worst changelog and subject: line ever :) Please go read the links that my patchbot sent you last time you submitted this change. You didn't do so for some odd reason :( thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-03-31 21:00 +0200 |
| Message-ID | <tr9Wa-8nY-15@gated-at.bofh.it> |
| In reply to | #1613741 |
On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote: > fixed a coding style error/warning. > > Signed-off-by: Chewie Lin <linsh@oregonstate.edu> > --- > drivers/staging/vt6656/main_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c > index 9e074e9..2d9e7af 100644 > --- a/drivers/staging/vt6656/main_usb.c > +++ b/drivers/staging/vt6656/main_usb.c > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > status = usb_reset_device(priv->usb); > if (status) > dev_warn(&priv->usb->dev, > - "usb_device_reset fail status=%d\n", status); > + "%s=%d\n", "usb_device_reset fail status", status); Yeah, what Greg said. Also most likely this should be dev_warn(&priv->usb->dev, "usb_reset_device fail status=%d\n", status); Note the function is usb_device_reset, but the function call that failed is usb_reset_device.
[toc] | [prev] | [next] | [standalone]
| From | Chewie Lin <linsh@oregonstate.edu> |
|---|---|
| Date | 2017-04-01 05:30 +0200 |
| Message-ID | <trhTH-5sS-5@gated-at.bofh.it> |
| In reply to | #1614255 |
On Fri, Mar 31, 2017 at 11:53:55AM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote: > > fixed a coding style error/warning. > > > > Signed-off-by: Chewie Lin <linsh@oregonstate.edu> > > --- > > drivers/staging/vt6656/main_usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c > > index 9e074e9..2d9e7af 100644 > > --- a/drivers/staging/vt6656/main_usb.c > > +++ b/drivers/staging/vt6656/main_usb.c > > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > > status = usb_reset_device(priv->usb); > > if (status) > > dev_warn(&priv->usb->dev, > > - "usb_device_reset fail status=%d\n", status); > > + "%s=%d\n", "usb_device_reset fail status", status); > > Yeah, what Greg said. > > Also most likely this should be > > dev_warn(&priv->usb->dev, > "usb_reset_device fail status=%d\n", status); > > Note the function is usb_device_reset, but the > function call that failed is usb_reset_device. yep, I had the comic book guy from the Simpsons voice when I read that. :) I submitted a separate patch, maybe I should have reply-to this instead? >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web