Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1610050 > unrolled thread
| Started by | Mike Galbraith <efault@gmx.de> |
|---|---|
| First post | 2017-03-27 20:30 +0200 |
| Last post | 2017-03-30 06:00 +0200 |
| Articles | 8 on this page of 48 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-03-27 20:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-03-29 08:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-29 22:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-03-30 09:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-31 05:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Christoph Hellwig <hch@lst.de> - 2017-03-31 10:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-31 18:50 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Christoph Hellwig <hch@lst.de> - 2017-04-03 16:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-03 17:50 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-03 18:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Christoph Hellwig <hch@lst.de> - 2017-04-05 08:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-03 20:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-03 20:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-04 06:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 15:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-04 16:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 16:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 17:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-04 19:50 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-04 20:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 20:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-04 20:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 23:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 05:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 21:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 05:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-05 05:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 05:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 05:50 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-05 06:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 06:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Christoph Hellwig <hch@lst.de> - 2017-04-05 08:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 09:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-05 23:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 08:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-07 08:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 08:50 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 09:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 09:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 09:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-07 15:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-07 15:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 16:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-07 21:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-08 07:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-05 06:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-29 22:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-03-30 06:00 +0200
Page 3 of 3 — ← Prev page 1 2 [3]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-07 15:30 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <ttC7D-7CK-3@gated-at.bofh.it> |
| In reply to | #1618518 |
On Fri, Apr 07, 2017 at 09:22:02AM +0200, Mike Galbraith wrote: > On Fri, 2017-04-07 at 09:05 +0200, Mike Galbraith wrote: > > On Fri, 2017-04-07 at 08:44 +0200, Mike Galbraith wrote: > > > On Fri, 2017-04-07 at 09:24 +0300, Michael S. Tsirkin wrote: > > > > On Fri, Apr 07, 2017 at 08:03:19AM +0200, Mike Galbraith wrote: > > > > > > > > Test tag works fine here w/wo threadirqs, RT works as well. > > > > > > > > > > -Mike > > > > > > > > Thanks a lot. > > > > OK I pushed out two new tags > > > > test1 with just the cleanup reverts > > > > test2 with a bugfix in this area > > > > > > > > > > > > I would very much appreciate your testing report on both - > > > > should be ok but better make sure. > > > > > > Ok, once it percolates out I'll do that. > > > > for_linus-10-g960bef2a6172 contains a -ENOBUILD merge conflict. > > But test2 works fine w/wo threadirqs. Oops. This is what one gets by pushing at 2am. I fixed that one up (still didn't even build as I'm in the middle of a conference). Also it's actually the reverse test2 is just the revert test1 has one more bugfix. So I'm inclined to push test2 out to linux-next for now, and will add test1 later if it fares well. Mike, your testing is very much appreciated! -- MST
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-07 15:40 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <ttChk-7G0-21@gated-at.bofh.it> |
| In reply to | #1618793 |
On Fri, Apr 07, 2017 at 04:20:12PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 07, 2017 at 09:22:02AM +0200, Mike Galbraith wrote: > > On Fri, 2017-04-07 at 09:05 +0200, Mike Galbraith wrote: > > > On Fri, 2017-04-07 at 08:44 +0200, Mike Galbraith wrote: > > > > On Fri, 2017-04-07 at 09:24 +0300, Michael S. Tsirkin wrote: > > > > > On Fri, Apr 07, 2017 at 08:03:19AM +0200, Mike Galbraith wrote: > > > > > > > > > > Test tag works fine here w/wo threadirqs, RT works as well. > > > > > > > > > > > > -Mike > > > > > > > > > > Thanks a lot. > > > > > OK I pushed out two new tags > > > > > test1 with just the cleanup reverts > > > > > test2 with a bugfix in this area > > > > > > > > > > > > > > > I would very much appreciate your testing report on both - > > > > > should be ok but better make sure. > > > > > > > > Ok, once it percolates out I'll do that. > > > > > > for_linus-10-g960bef2a6172 contains a -ENOBUILD merge conflict. > > > > But test2 works fine w/wo threadirqs. > > Oops. This is what one gets by pushing at 2am. I fixed that one up > (still didn't even build as I'm in the middle of a conference). > Also it's actually the reverse test2 is just the revert test1 has > one more bugfix. > > So I'm inclined to push test2 out to linux-next for now, and will > add test1 later if it fares well. > > Mike, your testing is very much appreciated! Oh wait, I still put the ctx feature patches in there :( Pls ignore, I'll update when I've fixed it up. Sorry about the noise. > -- > MST
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-07 16:40 +0200 |
| Message-ID | <ttDdo-8mD-29@gated-at.bofh.it> |
| In reply to | #1618803 |
On Fri, 2017-04-07 at 16:35 +0300, Michael S. Tsirkin wrote: > Oh wait, I still put the ctx feature patches in there :( > Pls ignore, I'll update when I've fixed it up. Sorry about the noise. Both worked fine w/wo threadirqs. -Mike
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-07 21:00 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <ttHgZ-2Sw-5@gated-at.bofh.it> |
| In reply to | #1618856 |
On Fri, Apr 07, 2017 at 04:29:53PM +0200, Mike Galbraith wrote: > On Fri, 2017-04-07 at 16:35 +0300, Michael S. Tsirkin wrote: > > > Oh wait, I still put the ctx feature patches in there :( > > Pls ignore, I'll update when I've fixed it up. Sorry about the noise. > > Both worked fine w/wo threadirqs. > > -Mike OK. test3 and test4 are now pushed: test3 should fix your hang, test4 is trying to fix a crash reported independently. Will push to linux-next once I hear from you. -- MST
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-08 07:10 +0200 |
| Message-ID | <ttQNj-YJ-7@gated-at.bofh.it> |
| In reply to | #1619045 |
On Fri, 2017-04-07 at 21:56 +0300, Michael S. Tsirkin wrote: > OK. test3 and test4 are now pushed: test3 should fix your hang, > test4 is trying to fix a crash reported independently. test3 does not fix the post hibernate hang business that I can easily reproduce, those are NFS, and at least as old as 4.4. Host/guest, dunno, put 4.4 on both, guest hangs intermittently. [<ffffffffa039a550>] __rpc_wait_for_completion_task+0x30/0x30 [sunrpc] [<ffffffffa039a56e>] rpc_wait_bit_killable+0x1e/0xb0 [sunrpc] [<ffffffffa039a550>] __rpc_wait_for_completion_task+0x30/0x30 [sunrpc] [<ffffffff810c6450>] autoremove_wake_function+0x50/0x50 [<ffffffffa038f670>] call_decode+0x850/0x850 [sunrpc] [<ffffffffa038f670>] call_decode+0x850/0x850 [sunrpc] [<ffffffffa039b17e>] __rpc_execute+0x14e/0x440 [sunrpc] [<ffffffff810f7d35>] ktime_get+0x35/0xa0 [<ffffffffa0390900>] rpc_run_task+0x120/0x170 [sunrpc] [<ffffffffa064a1c6>] nfs4_call_sync_sequence+0x56/0x80 [nfsv4] [<ffffffffa064acd0>] _nfs4_proc_getattr+0xb0/0xc0 [nfsv4] [<ffffffff8123f8b2>] path_lookupat+0xd2/0x100 [<ffffffffa0655d9c>] nfs4_proc_getattr+0x5c/0xe0 [nfsv4] [<ffffffffa0612120>] __nfs_revalidate_inode+0xa0/0x300 [nfs] [<ffffffffa0612485>] nfs_getattr+0x95/0x250 [nfs] [<ffffffff812365eb>] vfs_statx+0x7b/0xc0 [<ffffffff81236a60>] SYSC_newstat+0x20/0x40 [<ffffffff81687177>] entry_SYSCALL_64_fastpath+0x1a/0xa9 [<ffffffffffffffff>] 0xffffffffffffffff I noted no _other_ misbehavior in either kernel, w/wo threadirqs. -Mike
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-05 06:00 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <tsKgW-5Kg-13@gated-at.bofh.it> |
| In reply to | #1616542 |
On Wed, Apr 05, 2017 at 05:24:30AM +0200, Mike Galbraith wrote: > On Wed, 2017-04-05 at 06:13 +0300, Michael S. Tsirkin wrote: > > On Wed, Apr 05, 2017 at 05:09:09AM +0200, Mike Galbraith wrote: > > > On Tue, 2017-04-04 at 22:03 +0300, Michael S. Tsirkin wrote: > > > > > > > since I couldn't reproduce, I decided it's worth trying to see > > > > what happens if we revert back to before 5c34d002dcc7. > > > > > > > > > > > > Could you please test a tag "test" in my tree above? > > > > It should point at 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > > > > > Nogo. > > > > > > git@homer:..git/vhost> git remote update > > > Fetching origin > > > git@homer:..git/vhost> git show > > > 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > > fatal: bad object 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > > > Maybe because it's a tag not a head. Pls try > > git fetch git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git > > refs/tags/test > > That worked. Checked out/building. Thanks a lot for the testing. -- MST
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-03-29 22:30 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <tqsoa-3FE-19@gated-at.bofh.it> |
| In reply to | #1611612 |
On Wed, Mar 29, 2017 at 08:23:22AM +0200, Mike Galbraith wrote:
> On Mon, 2017-03-27 at 20:18 +0200, Mike Galbraith wrote:
>
> > BTW, WRT RT woes with $subject, I tried booting a generic kernel with
> > threadirqs, and bingo, same deal, just a bit more painful than for RT,
> > where there's no watchdog moaning accompanying the (preemptible) spin.
>
> BTW++: the last hunk of this bandaid may be a bug fix. With only the
> first two, box tried to use uninitialized stuff on hibernate, went
> boom. Looks like that may be possible without help from me.
>
> --- a/drivers/char/virtio_console.c
> +++ b/drivers/char/virtio_console.c
> @@ -2058,7 +2058,7 @@ static int virtcons_probe(struct virtio_
> portdev->max_nr_ports = 1;
>
> /* Don't test MULTIPORT at all if we're rproc: not a valid feature! */
> - if (!is_rproc_serial(vdev) &&
> + if (!is_rproc_serial(vdev) && !IS_ENABLED(CONFIG_IRQ_FORCED_THREADING) &&
> virtio_cread_feature(vdev, VIRTIO_CONSOLE_F_MULTIPORT,
> struct virtio_console_config, max_nr_ports,
> &portdev->max_nr_ports) == 0) {
> @@ -2179,7 +2179,9 @@ static struct virtio_device_id id_table[
>
> static unsigned int features[] = {
> VIRTIO_CONSOLE_F_SIZE,
> +#ifndef CONFIG_IRQ_FORCED_THREADING
> VIRTIO_CONSOLE_F_MULTIPORT,
> +#endif
> };
These look kind of questionable.
Is this part needed?
> static struct virtio_device_id rproc_serial_id_table[] = {
> @@ -2202,14 +2204,16 @@ static int virtcons_freeze(struct virtio
>
> vdev->config->reset(vdev);
>
> - virtqueue_disable_cb(portdev->c_ivq);
> + if (use_multiport(portdev))
> + virtqueue_disable_cb(portdev->c_ivq);
> cancel_work_sync(&portdev->control_work);
> cancel_work_sync(&portdev->config_work);
> /*
> * Once more: if control_work_handler() was running, it would
> * enable the cb as the last step.
> */
> - virtqueue_disable_cb(portdev->c_ivq);
> + if (use_multiport(portdev))
> + virtqueue_disable_cb(portdev->c_ivq);
> remove_controlq_data(portdev);
>
> list_for_each_entry(port, &portdev->ports, list) {
This looks real. No idea why would interrupt sharing
trigger anything like this but go figure.
Can you pls submit this separately with
a signature?
--
MST
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-03-30 06:00 +0200 |
| Message-ID | <tqzpD-fK-11@gated-at.bofh.it> |
| In reply to | #1612299 |
On Wed, 2017-03-29 at 23:19 +0300, Michael S. Tsirkin wrote:
> > > > > > > > > > > &portdev->max_nr_ports) == 0) {
> > @@ -2179,7 +2179,9 @@ static struct virtio_device_id id_table[
> >
> > static unsigned int features[] = {
> > > > > > VIRTIO_CONSOLE_F_SIZE,
> > +#ifndef CONFIG_IRQ_FORCED_THREADING
> > > > > > VIRTIO_CONSOLE_F_MULTIPORT,
> > +#endif
> > };
>
> These look kind of questionable.
> Is this part needed?
I would have sworn it was, but double checking, nope, it's not.
Hm, so I could make a prettier bandaid with a runtime check.. but it'd
remain a bandaid, so I'll go do some beans 'n' biscuits work instead.
-Mike
[toc] | [prev] | [standalone]
Page 3 of 3 — ← Prev page 1 2 [3]
Back to top | Article view | linux.kernel
csiph-web