Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1611654 > unrolled thread

Re: [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity Vincent Guittot <vincent.guittot@linaro.org> - 2017-03-29 09:40 +0200
    Re: [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity Juri Lelli <juri.lelli@arm.com> - 2017-03-29 10:10 +0200

#1611654 — Re: [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity

On 27 March 2017 at 15:18, Juri Lelli <juri.lelli@arm.com> wrote:
> parse_cpu_capacity() has to return 0 on failure, but it currently returns
> 1 instead if raw_capacity kcalloc failed.
>
> Fix it by removing the negation of the return value.
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Reported-by: Morten Rasmussen <morten.rasmussen@arm.com>
> Fixes: 06073ee26775 ('ARM: 8621/3: parse cpu capacity-dmips-mhz from DT')
> Signed-off-by: Juri Lelli <juri.lelli@arm.com>
> ---
>  arch/arm/kernel/topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
> index f8a3ab82e77f..4e4af809606a 100644
> --- a/arch/arm/kernel/topology.c
> +++ b/arch/arm/kernel/topology.c
> @@ -166,7 +166,7 @@ static int __init parse_cpu_capacity(struct device_node *cpu_node, int cpu)
>                         if (!raw_capacity) {
>                                 pr_err("cpu_capacity: failed to allocate memory for raw capacities\n");
>                                 cap_parsing_failed = true;
> -                               return !ret;
> +                               return ret;

Why not directly returning 0 ? whatever the value of ret, the parse of
cpu capacity has failed in this case

>                         }
>                 }
>                 capacity_scale = max(cpu_capacity, capacity_scale);
> --
> 2.10.0
>

[toc] | [next] | [standalone]

#1611667

On 29/03/17 09:37, Vincent Guittot wrote:
> On 27 March 2017 at 15:18, Juri Lelli <juri.lelli@arm.com> wrote:
> > parse_cpu_capacity() has to return 0 on failure, but it currently returns
> > 1 instead if raw_capacity kcalloc failed.
> >
> > Fix it by removing the negation of the return value.
> >
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Reported-by: Morten Rasmussen <morten.rasmussen@arm.com>
> > Fixes: 06073ee26775 ('ARM: 8621/3: parse cpu capacity-dmips-mhz from DT')
> > Signed-off-by: Juri Lelli <juri.lelli@arm.com>
> > ---
> >  arch/arm/kernel/topology.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
> > index f8a3ab82e77f..4e4af809606a 100644
> > --- a/arch/arm/kernel/topology.c
> > +++ b/arch/arm/kernel/topology.c
> > @@ -166,7 +166,7 @@ static int __init parse_cpu_capacity(struct device_node *cpu_node, int cpu)
> >                         if (!raw_capacity) {
> >                                 pr_err("cpu_capacity: failed to allocate memory for raw capacities\n");
> >                                 cap_parsing_failed = true;
> > -                               return !ret;
> > +                               return ret;
> 
> Why not directly returning 0 ? whatever the value of ret, the parse of
> cpu capacity has failed in this case
> 

Sure, can change that.

Thanks,

- Juri

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web