Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1611626 > unrolled thread

[PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma

Started byvaibhavddit@gmail.com
First post2017-03-29 09:00 +0200
Last post2017-03-29 09:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma vaibhavddit@gmail.com - 2017-03-29 09:00 +0200
    Re: [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error  about unnecessary whitespace and comma Greg KH <gregkh@linuxfoundation.org> - 2017-03-29 09:10 +0200

#1611626 — [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma

Fromvaibhavddit@gmail.com
Date2017-03-29 09:00 +0200
Subject[PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma
Message-ID<tqfKi-3aT-15@gated-at.bofh.it>
From: Vaibhav Kothari <vaibhavddit@gmail.com>

Removed whitespace & comma in fbtft-bus.c as a part of
checkpatch.pl fix-up.

Signed-off-by: Vaibhav Kothari <vaibhavddit@gmail.com>
---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 3475b1b..2a18417 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -56,9 +56,9 @@ void func(struct fbtft_par *par, int len, ...)                                \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
-- 
1.9.1

[toc] | [next] | [standalone]


#1611632 — Re: [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-03-29 09:10 +0200
SubjectRe: [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma
Message-ID<tqfTY-3sX-11@gated-at.bofh.it>
In reply to#1611626
On Wed, Mar 29, 2017 at 12:23:01PM +0530, vaibhavddit@gmail.com wrote:
> From: Vaibhav Kothari <vaibhavddit@gmail.com>
> 
> Removed whitespace & comma in fbtft-bus.c as a part of
> checkpatch.pl fix-up.

Did you test build this?  Always do so, otherwise you will get grumpy
emails saying you need to test-build your changes...

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web