Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1610226 > unrolled thread
| Started by | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| First post | 2017-03-28 03:20 +0200 |
| Last post | 2017-03-30 20:00 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] kbuild: use -Oz instead of -Os when using clang Matthias Kaehlcke <mka@chromium.org> - 2017-03-28 03:20 +0200
Re: [PATCH] kbuild: use -Oz instead of -Os when using clang Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-30 18:10 +0200
Re: [PATCH] kbuild: use -Oz instead of -Os when using clang Matthias Kaehlcke <mka@chromium.org> - 2017-03-30 18:50 +0200
Re: [PATCH] kbuild: use -Oz instead of -Os when using clang Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-30 20:00 +0200
| From | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| Date | 2017-03-28 03:20 +0200 |
| Subject | [PATCH] kbuild: use -Oz instead of -Os when using clang |
| Message-ID | <tpNXI-8w9-13@gated-at.bofh.it> |
This generates smaller resulting object code when compiled with clang. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b2faa9319372..66bcdbf58371 100644 --- a/Makefile +++ b/Makefile @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) endif ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) else ifdef CONFIG_PROFILE_ALL_BRANCHES KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) -- 2.12.2.564.g063fe858b8-goog
[toc] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-03-30 18:10 +0200 |
| Message-ID | <tqKO6-mb-15@gated-at.bofh.it> |
| In reply to | #1610226 |
2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> This generates smaller resulting object code when compiled with clang.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index b2faa9319372..66bcdbf58371 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,)
> endif
>
> ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
> -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,)
> +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os)
> +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,)
> else
> ifdef CONFIG_PROFILE_ALL_BRANCHES
> KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,)
> --
> 2.12.2.564.g063fe858b8-goog
>
This is the same as the following commit in LLVMLinux
except Author/Signed-off-by.
Who should the authorship really belong to?
commit 186e62808239c603bfa308d5ea994a10d67bb409
Author: Behan Webster <behanw@converseincode.com>
Date: Thu Oct 16 14:28:54 2014 +0200
LLVMLinux: use -Oz instead of -Os when using clang
This generates smaller resulting object code when compiled with clang.
Signed-off-by: Behan Webster <behanw@converseincode.com>
--
Best Regards
Masahiro Yamada
[toc] | [prev] | [next] | [standalone]
| From | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| Date | 2017-03-30 18:50 +0200 |
| Message-ID | <tqLqO-KI-19@gated-at.bofh.it> |
| In reply to | #1613254 |
El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit: > 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: > > This generates smaller resulting object code when compiled with clang. > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > --- > > Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index b2faa9319372..66bcdbf58371 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) > > endif > > > > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE > > -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) > > +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) > > +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) > > else > > ifdef CONFIG_PROFILE_ALL_BRANCHES > > KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) > > > > > > This is the same as the following commit in LLVMLinux > except Author/Signed-off-by. > > Who should the authorship really belong to? (this time without html, sorry for the noise) It should belong to Behan, I missed to add a 'From' tag, sorry about that. Should I resend with the tag or can you fix it when applying the patch? Matthias > commit 186e62808239c603bfa308d5ea994a10d67bb409 > Author: Behan Webster <behanw@converseincode.com> > Date: Thu Oct 16 14:28:54 2014 +0200 > > LLVMLinux: use -Oz instead of -Os when using clang > > This generates smaller resulting object code when compiled with clang. > > Signed-off-by: Behan Webster <behanw@converseincode.com> > >
[toc] | [prev] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-03-30 20:00 +0200 |
| Message-ID | <tqMwx-1vj-9@gated-at.bofh.it> |
| In reply to | #1613292 |
Hi Matthias, 2017-03-31 1:41 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: > El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit: > >> 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: >> > This generates smaller resulting object code when compiled with clang. >> > >> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> >> > --- >> > Makefile | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/Makefile b/Makefile >> > index b2faa9319372..66bcdbf58371 100644 >> > --- a/Makefile >> > +++ b/Makefile >> > @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) >> > endif >> > >> > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE >> > -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) >> > +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) >> > +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) >> > else >> > ifdef CONFIG_PROFILE_ALL_BRANCHES >> > KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) >> > >> >> >> >> This is the same as the following commit in LLVMLinux >> except Author/Signed-off-by. >> >> Who should the authorship really belong to? > > (this time without html, sorry for the noise) > > It should belong to Behan, I missed to add a 'From' tag, sorry about > that. Should I resend with the tag or can you fix it when applying the > patch? No need to re-send it. I can fixup it manually. -- Best Regards Masahiro Yamada
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web