Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1611254 > unrolled thread
| Started by | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| First post | 2017-03-28 20:00 +0200 |
| Last post | 2017-03-28 21:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH net-next 3/4] net: dsa: mv88e6xxx: fix 88E6191 ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-28 20:00 +0200
Re: [PATCH net-next 3/4] net: dsa: mv88e6xxx: fix 88E6191 ops Andrew Lunn <andrew@lunn.ch> - 2017-03-28 21:00 +0200
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2017-03-28 20:00 +0200 |
| Subject | [PATCH net-next 3/4] net: dsa: mv88e6xxx: fix 88E6191 ops |
| Message-ID | <tq3zr-2Gq-1@gated-at.bofh.it> |
The mv88e6xxx_info structure for the 88E6191 chip was pointing the
mv88e6391_ops definition instead of mv88e6191_ops. Fix this.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 3918790c4a75..da7bf608cc58 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -3846,7 +3846,7 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = {
.atu_move_port_mask = 0x1f,
.tag_protocol = DSA_TAG_PROTO_DSA,
.flags = MV88E6XXX_FLAGS_FAMILY_6390,
- .ops = &mv88e6391_ops,
+ .ops = &mv88e6191_ops,
},
[MV88E6240] = {
--
2.12.1
[toc] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2017-03-28 21:00 +0200 |
| Message-ID | <tq4vw-3mI-7@gated-at.bofh.it> |
| In reply to | #1611254 |
On Tue, Mar 28, 2017 at 01:50:34PM -0400, Vivien Didelot wrote:
> The mv88e6xxx_info structure for the 88E6191 chip was pointing the
> mv88e6391_ops definition instead of mv88e6191_ops. Fix this.
mv88e6391_ops and mv88e6191_ops appear to be identical, so effectively
there is no bug here. So no need to have this in -stable.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web