Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1611261 > unrolled thread

[PATCH 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers

Started byAzhar Shaikh <azhar.shaikh@intel.com>
First post2017-03-28 20:20 +0200
Last post2017-03-30 21:40 +0200
Articles 8 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers Azhar Shaikh <azhar.shaikh@intel.com> - 2017-03-28 20:20 +0200
    [PATCH 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers Azhar Shaikh <azhar.shaikh@intel.com> - 2017-03-28 20:20 +0200
    [PATCH v2 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers Azhar Shaikh <azhar.shaikh@intel.com> - 2017-03-29 20:20 +0200
      Re: [PATCH v2 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for  BYT-related Intel controllers Adrian Hunter <adrian.hunter@intel.com> - 2017-03-30 09:50 +0200
      Re: [PATCH v2 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for  BYT-related Intel controllers Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-30 21:40 +0200
    [PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers Azhar Shaikh <azhar.shaikh@intel.com> - 2017-03-29 20:20 +0200
      Re: [PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for  BYT-related Intel controllers Adrian Hunter <adrian.hunter@intel.com> - 2017-03-30 09:50 +0200
      Re: [PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for  BYT-related Intel controllers Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-30 21:40 +0200

#1611261 — [PATCH 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers

FromAzhar Shaikh <azhar.shaikh@intel.com>
Date2017-03-28 20:20 +0200
Subject[PATCH 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers
Message-ID<tq3SN-37G-1@gated-at.bofh.it>
Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel SD card
controllers.

Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
---
 drivers/mmc/host/sdhci-acpi.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index 9dcb704..a15d237 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -263,10 +263,8 @@ static int sdhci_acpi_sd_probe_slot(struct platform_device *pdev,
 
 	/* Platform specific code during sd probe slot goes here */
 
-	if (hid && !strcmp(hid, "80865ACA")) {
+	if (hid && !strcmp(hid, "80865ACA"))
 		host->mmc_host_ops.get_cd = bxt_get_cd;
-		host->mmc->caps |= MMC_CAP_AGGRESSIVE_PM;
-	}
 
 	return 0;
 }
@@ -302,7 +300,7 @@ static int sdhci_acpi_sd_probe_slot(struct platform_device *pdev,
 	.quirks  = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
 	.quirks2 = SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON |
 		   SDHCI_QUIRK2_STOP_WITH_TC,
-	.caps    = MMC_CAP_WAIT_WHILE_BUSY,
+	.caps    = MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_AGGRESSIVE_PM,
 	.probe_slot	= sdhci_acpi_sd_probe_slot,
 };
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1611265 — [PATCH 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers

FromAzhar Shaikh <azhar.shaikh@intel.com>
Date2017-03-28 20:20 +0200
Subject[PATCH 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers
Message-ID<tq3SN-37G-13@gated-at.bofh.it>
In reply to#1611261
Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel SD card
controllers.

Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
---
 drivers/mmc/host/sdhci-pci-core.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 86560d5..4a58a80 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -423,16 +423,15 @@ static int byt_sdio_probe_slot(struct sdhci_pci_slot *slot)
 
 static int byt_sd_probe_slot(struct sdhci_pci_slot *slot)
 {
-	slot->host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY;
+	slot->host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY |
+				 MMC_CAP_AGGRESSIVE_PM;
 	slot->cd_idx = 0;
 	slot->cd_override_level = true;
 	if (slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_BXT_SD ||
 	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_BXTM_SD ||
 	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_APL_SD ||
-	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_SD) {
+	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_SD)
 		slot->host->mmc_host_ops.get_cd = bxt_get_cd;
-		slot->host->mmc->caps |= MMC_CAP_AGGRESSIVE_PM;
-	}
 
 	return 0;
 }
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1612222 — [PATCH v2 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers

FromAzhar Shaikh <azhar.shaikh@intel.com>
Date2017-03-29 20:20 +0200
Subject[PATCH v2 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers
Message-ID<tqqmm-2iB-21@gated-at.bofh.it>
In reply to#1611261
Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel SD card
controllers.

Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
---
Changes in v2:
  - Rebased the patch on top of 'next' branch.
  - No code change.

 drivers/mmc/host/sdhci-pci-core.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 6c0440e..833072b 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -630,16 +630,15 @@ static int byt_sdio_probe_slot(struct sdhci_pci_slot *slot)
 static int byt_sd_probe_slot(struct sdhci_pci_slot *slot)
 {
 	byt_read_dsm(slot);
-	slot->host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY;
+	slot->host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY |
+				 MMC_CAP_AGGRESSIVE_PM;
 	slot->cd_idx = 0;
 	slot->cd_override_level = true;
 	if (slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_BXT_SD ||
 	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_BXTM_SD ||
 	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_APL_SD ||
-	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_SD) {
+	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_SD)
 		slot->host->mmc_host_ops.get_cd = bxt_get_cd;
-		slot->host->mmc->caps |= MMC_CAP_AGGRESSIVE_PM;
-	}
 
 	return 0;
 }
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1612682 — Re: [PATCH v2 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers

FromAdrian Hunter <adrian.hunter@intel.com>
Date2017-03-30 09:50 +0200
SubjectRe: [PATCH v2 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers
Message-ID<tqD0f-2Ug-45@gated-at.bofh.it>
In reply to#1612222
On 29/03/17 21:16, Azhar Shaikh wrote:
> Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel SD card
> controllers.
> 
> Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> Changes in v2:
>   - Rebased the patch on top of 'next' branch.
>   - No code change.
> 
>  drivers/mmc/host/sdhci-pci-core.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 6c0440e..833072b 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -630,16 +630,15 @@ static int byt_sdio_probe_slot(struct sdhci_pci_slot *slot)
>  static int byt_sd_probe_slot(struct sdhci_pci_slot *slot)
>  {
>  	byt_read_dsm(slot);
> -	slot->host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY;
> +	slot->host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY |
> +				 MMC_CAP_AGGRESSIVE_PM;
>  	slot->cd_idx = 0;
>  	slot->cd_override_level = true;
>  	if (slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_BXT_SD ||
>  	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_BXTM_SD ||
>  	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_APL_SD ||
> -	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_SD) {
> +	    slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_SD)
>  		slot->host->mmc_host_ops.get_cd = bxt_get_cd;
> -		slot->host->mmc->caps |= MMC_CAP_AGGRESSIVE_PM;
> -	}
>  
>  	return 0;
>  }
>

[toc] | [prev] | [next] | [standalone]

#1613400 — Re: [PATCH v2 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers

FromUlf Hansson <ulf.hansson@linaro.org>
Date2017-03-30 21:40 +0200
SubjectRe: [PATCH v2 2/2] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers
Message-ID<tqO5k-2G9-33@gated-at.bofh.it>
In reply to#1612222
On 29 March 2017 at 20:16, Azhar Shaikh <azhar.shaikh@intel.com> wrote:
> Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel SD card
> controllers.
>
> Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>


Thanks, applied for next!

Kind regards
Uffe


> ---
> Changes in v2:
>   - Rebased the patch on top of 'next' branch.
>   - No code change.
>
>  drivers/mmc/host/sdhci-pci-core.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 6c0440e..833072b 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -630,16 +630,15 @@ static int byt_sdio_probe_slot(struct sdhci_pci_slot *slot)
>  static int byt_sd_probe_slot(struct sdhci_pci_slot *slot)
>  {
>         byt_read_dsm(slot);
> -       slot->host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY;
> +       slot->host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY |
> +                                MMC_CAP_AGGRESSIVE_PM;
>         slot->cd_idx = 0;
>         slot->cd_override_level = true;
>         if (slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_BXT_SD ||
>             slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_BXTM_SD ||
>             slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_APL_SD ||
> -           slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_SD) {
> +           slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_SD)
>                 slot->host->mmc_host_ops.get_cd = bxt_get_cd;
> -               slot->host->mmc->caps |= MMC_CAP_AGGRESSIVE_PM;
> -       }
>
>         return 0;
>  }
> --
> 1.9.1
>

[toc] | [prev] | [next] | [standalone]

#1612232 — [PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers

FromAzhar Shaikh <azhar.shaikh@intel.com>
Date2017-03-29 20:20 +0200
Subject[PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers
Message-ID<tqqmm-2iB-23@gated-at.bofh.it>
In reply to#1611261
Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel SD card
controllers.

Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
---
Changes in v2:
  - Rebased the patch on top of 'next' branch.
  - No code change.

 drivers/mmc/host/sdhci-acpi.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index 665c5f3..c6a9a1b 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -263,10 +263,8 @@ static int sdhci_acpi_sd_probe_slot(struct platform_device *pdev,
 
 	/* Platform specific code during sd probe slot goes here */
 
-	if (hid && !strcmp(hid, "80865ACA")) {
+	if (hid && !strcmp(hid, "80865ACA"))
 		host->mmc_host_ops.get_cd = bxt_get_cd;
-		host->mmc->caps |= MMC_CAP_AGGRESSIVE_PM;
-	}
 
 	return 0;
 }
@@ -302,7 +300,7 @@ static int sdhci_acpi_sd_probe_slot(struct platform_device *pdev,
 	.quirks  = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
 	.quirks2 = SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON |
 		   SDHCI_QUIRK2_STOP_WITH_TC,
-	.caps    = MMC_CAP_WAIT_WHILE_BUSY,
+	.caps    = MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_AGGRESSIVE_PM,
 	.probe_slot	= sdhci_acpi_sd_probe_slot,
 };
 
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1612678 — Re: [PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers

FromAdrian Hunter <adrian.hunter@intel.com>
Date2017-03-30 09:50 +0200
SubjectRe: [PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers
Message-ID<tqD0e-2Ug-31@gated-at.bofh.it>
In reply to#1612232
On 29/03/17 21:16, Azhar Shaikh wrote:
> Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel SD card
> controllers.
> 
> Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> Changes in v2:
>   - Rebased the patch on top of 'next' branch.
>   - No code change.
> 
>  drivers/mmc/host/sdhci-acpi.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index 665c5f3..c6a9a1b 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -263,10 +263,8 @@ static int sdhci_acpi_sd_probe_slot(struct platform_device *pdev,
>  
>  	/* Platform specific code during sd probe slot goes here */
>  
> -	if (hid && !strcmp(hid, "80865ACA")) {
> +	if (hid && !strcmp(hid, "80865ACA"))
>  		host->mmc_host_ops.get_cd = bxt_get_cd;
> -		host->mmc->caps |= MMC_CAP_AGGRESSIVE_PM;
> -	}
>  
>  	return 0;
>  }
> @@ -302,7 +300,7 @@ static int sdhci_acpi_sd_probe_slot(struct platform_device *pdev,
>  	.quirks  = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
>  	.quirks2 = SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON |
>  		   SDHCI_QUIRK2_STOP_WITH_TC,
> -	.caps    = MMC_CAP_WAIT_WHILE_BUSY,
> +	.caps    = MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_AGGRESSIVE_PM,
>  	.probe_slot	= sdhci_acpi_sd_probe_slot,
>  };
>  
>

[toc] | [prev] | [next] | [standalone]

#1613395 — Re: [PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers

FromUlf Hansson <ulf.hansson@linaro.org>
Date2017-03-30 21:40 +0200
SubjectRe: [PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel controllers
Message-ID<tqO5k-2G9-25@gated-at.bofh.it>
In reply to#1612232
On 29 March 2017 at 20:16, Azhar Shaikh <azhar.shaikh@intel.com> wrote:
> Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel SD card
> controllers.
>
> Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>


Thanks, applied for next!

Kind regards
Uffe


> ---
> Changes in v2:
>   - Rebased the patch on top of 'next' branch.
>   - No code change.
>
>  drivers/mmc/host/sdhci-acpi.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index 665c5f3..c6a9a1b 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -263,10 +263,8 @@ static int sdhci_acpi_sd_probe_slot(struct platform_device *pdev,
>
>         /* Platform specific code during sd probe slot goes here */
>
> -       if (hid && !strcmp(hid, "80865ACA")) {
> +       if (hid && !strcmp(hid, "80865ACA"))
>                 host->mmc_host_ops.get_cd = bxt_get_cd;
> -               host->mmc->caps |= MMC_CAP_AGGRESSIVE_PM;
> -       }
>
>         return 0;
>  }
> @@ -302,7 +300,7 @@ static int sdhci_acpi_sd_probe_slot(struct platform_device *pdev,
>         .quirks  = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
>         .quirks2 = SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON |
>                    SDHCI_QUIRK2_STOP_WITH_TC,
> -       .caps    = MMC_CAP_WAIT_WHILE_BUSY,
> +       .caps    = MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_AGGRESSIVE_PM,
>         .probe_slot     = sdhci_acpi_sd_probe_slot,
>  };
>
> --
> 1.9.1
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web