Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1610999 > unrolled thread
| Started by | Joel Stanley <joel@jms.id.au> |
|---|---|
| First post | 2017-03-28 16:20 +0200 |
| Last post | 2017-03-28 17:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header Joel Stanley <joel@jms.id.au> - 2017-03-28 16:20 +0200
Re: [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header Arnd Bergmann <arnd@arndb.de> - 2017-03-28 17:10 +0200
| From | Joel Stanley <joel@jms.id.au> |
|---|---|
| Date | 2017-03-28 16:20 +0200 |
| Subject | Re: [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header |
| Message-ID | <tq08y-pa-7@gated-at.bofh.it> |
On Wed, Mar 29, 2017 at 12:40 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added header file triggers a sanity check:
>
> usr/include/linux/aspeed-lpc-ctrl.h:44: found __[us]{8,16,32,64} type without #include <linux/types.h>
Thanks Arnd.
What tool are you running to do this check?
> We should include linux/types.h explicitly to ensure the header
> can be included from user space.
>
> Fixes: 6c4e97678501 ("drivers/misc: Add Aspeed LPC control driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
> ---
> include/uapi/linux/aspeed-lpc-ctrl.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/aspeed-lpc-ctrl.h b/include/uapi/linux/aspeed-lpc-ctrl.h
> index f96fa995a3f0..c328c976c684 100644
> --- a/include/uapi/linux/aspeed-lpc-ctrl.h
> +++ b/include/uapi/linux/aspeed-lpc-ctrl.h
> @@ -11,6 +11,7 @@
> #define _UAPI_LINUX_ASPEED_LPC_CTRL_H
>
> #include <linux/ioctl.h>
> +#include <linux/types.h>
>
> /* Window types */
> #define ASPEED_LPC_CTRL_WINDOW_FLASH 1
> --
> 2.9.0
>
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-03-28 17:10 +0200 |
| Message-ID | <tq0UV-12M-7@gated-at.bofh.it> |
| In reply to | #1610999 |
On Tue, Mar 28, 2017 at 4:15 PM, Joel Stanley <joel@jms.id.au> wrote:
> On Wed, Mar 29, 2017 at 12:40 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The newly added header file triggers a sanity check:
>>
>> usr/include/linux/aspeed-lpc-ctrl.h:44: found __[us]{8,16,32,64} type without #include <linux/types.h>
>
> Thanks Arnd.
>
> What tool are you running to do this check?
I was running 'make randconfig' builds.
The warning came from scripts/headers_check.pl.
Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web