Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1609697 > unrolled thread

[PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER

Started byTobias Regnery <tobias.regnery@gmail.com>
First post2017-03-27 12:10 +0200
Last post2017-03-27 13:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER Tobias Regnery <tobias.regnery@gmail.com> - 2017-03-27 12:10 +0200
    Re: [PATCH] clk: sunxi-ng: fix build error without  CONFIG_RESET_CONTROLLER Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-27 13:50 +0200

#1609697 — [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER

FromTobias Regnery <tobias.regnery@gmail.com>
Date2017-03-27 12:10 +0200
Subject[PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
Message-ID<tpzL5-6pP-51@gated-at.bofh.it>
With CONFIG_RESET_CONTROLLER=n we get the following link error in the
sunxi-ng clk driver:

drivers/built-in.o: In function `sunxi_ccu_probe':
mux-core.c:(.text+0x12fe68): undefined reference to 'reset_controller_register'
mux-core.c:(.text+0x12fe68): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol 'reset_controller_register'

Fix this by adding the appropriate select statement.

Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
 drivers/clk/sunxi-ng/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index 213cf64e4fab..8af8f4be8e3b 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -1,6 +1,7 @@
 config SUNXI_CCU
 	bool "Clock support for Allwinner SoCs"
 	depends on ARCH_SUNXI || COMPILE_TEST
+	select RESET_CONTROLLER
 	default ARCH_SUNXI
 
 if SUNXI_CCU
-- 
2.11.0

[toc] | [next] | [standalone]


#1609750 — Re: [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-03-27 13:50 +0200
SubjectRe: [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
Message-ID<tpBjP-7ro-7@gated-at.bofh.it>
In reply to#1609697

[Multipart message — attachments visible in raw view] — view raw

On Mon, Mar 27, 2017 at 11:57:53AM +0200, Tobias Regnery wrote:
> With CONFIG_RESET_CONTROLLER=n we get the following link error in the
> sunxi-ng clk driver:
> 
> drivers/built-in.o: In function `sunxi_ccu_probe':
> mux-core.c:(.text+0x12fe68): undefined reference to 'reset_controller_register'
> mux-core.c:(.text+0x12fe68): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol 'reset_controller_register'
> 
> Fix this by adding the appropriate select statement.
> 
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web