Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609161 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-03-25 15:20 +0100 |
| Last post | 2017-03-27 03:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] netvsc: fix unititialized return value in variable ret Colin King <colin.king@canonical.com> - 2017-03-25 15:20 +0100
RE: [PATCH] netvsc: fix unititialized return value in variable ret Haiyang Zhang <haiyangz@microsoft.com> - 2017-03-27 03:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-03-25 15:20 +0100 |
| Subject | [PATCH] netvsc: fix unititialized return value in variable ret |
| Message-ID | <toUHT-1Wx-9@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
It is possible for an uninitialized value of ret to be returned
so fix this by initializing ret to zero.
Detected by CoverityScan, CID#1420762 ("Uninitialized scalar variable")
Fixes: 163891d7d429 ("netvsc: handle offline mtu and channel change")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/hyperv/netvsc_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index eb7ae79d47bb..f830bbbd8ad4 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -855,7 +855,7 @@ static int netvsc_change_mtu(struct net_device *ndev, int mtu)
struct hv_device *hdev = ndevctx->device_ctx;
struct netvsc_device_info device_info;
bool was_running;
- int ret;
+ int ret = 0;
if (!nvdev || nvdev->destroy)
return -ENODEV;
--
2.11.0
[toc] | [next] | [standalone]
| From | Haiyang Zhang <haiyangz@microsoft.com> |
|---|---|
| Date | 2017-03-27 03:00 +0200 |
| Message-ID | <tpraO-86m-7@gated-at.bofh.it> |
| In reply to | #1609161 |
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Saturday, March 25, 2017 10:17 AM
> To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> devel@linuxdriverproject.org; netdev@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] netvsc: fix unititialized return value in variable ret
>
> From: Colin Ian King <colin.king@canonical.com>
>
> It is possible for an uninitialized value of ret to be returned
> so fix this by initializing ret to zero.
>
> Detected by CoverityScan, CID#1420762 ("Uninitialized scalar variable")
>
> Fixes: 163891d7d429 ("netvsc: handle offline mtu and channel change")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/hyperv/netvsc_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hyperv/netvsc_drv.c
> b/drivers/net/hyperv/netvsc_drv.c
> index eb7ae79d47bb..f830bbbd8ad4 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -855,7 +855,7 @@ static int netvsc_change_mtu(struct net_device *ndev,
> int mtu)
> struct hv_device *hdev = ndevctx->device_ctx;
> struct netvsc_device_info device_info;
> bool was_running;
> - int ret;
> + int ret = 0;
This was just fix by commit: 386f57622cc3bbb39b9c00fc8762bc9ab28e0f8d
Thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web