Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1610625 > unrolled thread
| Started by | Andrea della Porta <sfaragnaus@gmail.com> |
|---|---|
| First post | 2017-03-28 14:10 +0200 |
| Last post | 2017-03-29 23:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] coding style issue resolved Andrea della Porta <sfaragnaus@gmail.com> - 2017-03-28 14:10 +0200
Re: [PATCH] coding style issue resolved Jonathan Cameron <jic23@kernel.org> - 2017-03-29 23:20 +0200
| From | Andrea della Porta <sfaragnaus@gmail.com> |
|---|---|
| Date | 2017-03-28 14:10 +0200 |
| Subject | [PATCH] coding style issue resolved |
| Message-ID | <tpY6J-7lr-1@gated-at.bofh.it> |
Coding style issue resolved.
Signed-off-by: Andrea della Porta <sfaragnaus@gmail.com>
---
drivers/staging/iio/accel/adis16209.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c
index 52fa2e0..159a687 100644
--- a/drivers/staging/iio/accel/adis16209.c
+++ b/drivers/staging/iio/accel/adis16209.c
@@ -255,9 +255,9 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
}
addr = adis16209_addresses[chan->scan_index][0];
ret = adis_read_reg_16(st, addr, &val16);
- if (ret) {
+ if (ret)
return ret;
- }
+
val16 &= (1 << bits) - 1;
val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
*val = val16;
--
2.4.10
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-03-29 23:20 +0200 |
| Message-ID | <tqtay-4hp-31@gated-at.bofh.it> |
| In reply to | #1610625 |
On 28/03/17 13:01, Andrea della Porta wrote:
> Coding style issue resolved.
>
> Signed-off-by: Andrea della Porta <sfaragnaus@gmail.com>
Please include the driver name in the title. Subsystem also good.
staging:iio:accel:adis16029 drop braces around single element if block
or something along those lines would be good.
> ---
> drivers/staging/iio/accel/adis16209.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c
> index 52fa2e0..159a687 100644
> --- a/drivers/staging/iio/accel/adis16209.c
> +++ b/drivers/staging/iio/accel/adis16209.c
> @@ -255,9 +255,9 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
> }
> addr = adis16209_addresses[chan->scan_index][0];
> ret = adis_read_reg_16(st, addr, &val16);
> - if (ret) {
> + if (ret)
> return ret;
> - }
> +
> val16 &= (1 << bits) - 1;
> val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> *val = val16;
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web