Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1608375 > unrolled thread
| Started by | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| First post | 2017-03-24 13:30 +0100 |
| Last post | 2017-03-28 08:00 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms() Adrian Hunter <adrian.hunter@intel.com> - 2017-03-24 13:30 +0100
Re: [PATCH] perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms() Andi Kleen <ak@linux.intel.com> - 2017-03-25 00:30 +0100
Re: [PATCH] perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms() Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-25 02:00 +0100
[tip:perf/core] perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms() tip-bot for Adrian Hunter <tipbot@zytor.com> - 2017-03-28 08:00 +0200
| From | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| Date | 2017-03-24 13:30 +0100 |
| Subject | [PATCH] perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms() |
| Message-ID | <towvV-1tO-21@gated-at.bofh.it> |
Address filtering with kernel symbols incorrectly resulted in the error
"Cannot determine size of symbol" because the no_size logic was the wrong
way around.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org # v4.9+
---
I thought I sent this ages ago, but I can't see it anywhere :-/
tools/perf/util/auxtrace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index c5a6e0b12452..78bd632f144d 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -1826,7 +1826,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
filt->addr = start;
if (filt->range && !filt->size && !filt->sym_to) {
filt->size = size;
- no_size = !!size;
+ no_size = !size;
}
}
@@ -1840,7 +1840,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
if (err)
return err;
filt->size = start + size - filt->addr;
- no_size = !!size;
+ no_size = !size;
}
/* The very last symbol in kallsyms does not imply a particular size */
--
1.9.1
[toc] | [next] | [standalone]
| From | Andi Kleen <ak@linux.intel.com> |
|---|---|
| Date | 2017-03-25 00:30 +0100 |
| Subject | Re: [PATCH] perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms() |
| Message-ID | <toGOB-pq-1@gated-at.bofh.it> |
| In reply to | #1608375 |
On Fri, Mar 24, 2017 at 02:15:52PM +0200, Adrian Hunter wrote: > Address filtering with kernel symbols incorrectly resulted in the error > "Cannot determine size of symbol" because the no_size logic was the wrong > way around. > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> > Cc: stable@vger.kernel.org # v4.9+ > --- Tested-by: Andi Kleen <ak@linux.intel.com> Fixes my problems with tracing kernel with PT with filtering. -Andi
[toc] | [prev] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2017-03-25 02:00 +0100 |
| Subject | Re: [PATCH] perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms() |
| Message-ID | <toIdI-1mI-7@gated-at.bofh.it> |
| In reply to | #1609023 |
Em Fri, Mar 24, 2017 at 04:20:12PM -0700, Andi Kleen escreveu: > On Fri, Mar 24, 2017 at 02:15:52PM +0200, Adrian Hunter wrote: > > Address filtering with kernel symbols incorrectly resulted in the error > > "Cannot determine size of symbol" because the no_size logic was the wrong > > way around. > > > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> > > Cc: stable@vger.kernel.org # v4.9+ > > --- > > Tested-by: Andi Kleen <ak@linux.intel.com> Thanks, applied. - Arnaldo > Fixes my problems with tracing kernel with PT with filtering. > > -Andi
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Adrian Hunter <tipbot@zytor.com> |
|---|---|
| Date | 2017-03-28 08:00 +0200 |
| Subject | [tip:perf/core] perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms() |
| Message-ID | <tpSkF-36v-7@gated-at.bofh.it> |
| In reply to | #1608375 |
Commit-ID: c3a0bbc7ad7598dec5a204868bdf8a2b1b51df14
Gitweb: http://git.kernel.org/tip/c3a0bbc7ad7598dec5a204868bdf8a2b1b51df14
Author: Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Fri, 24 Mar 2017 14:15:52 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 27 Mar 2017 11:58:08 -0300
perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms()
Address filtering with kernel symbols incorrectly resulted in the error
"Cannot determine size of symbol" because the no_size logic was the wrong
way around.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Tested-by: Andi Kleen <ak@linux.intel.com>
Cc: stable@vger.kernel.org # v4.9+
Link: http://lkml.kernel.org/r/1490357752-27942-1-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/auxtrace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index c5a6e0b1..78bd632 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -1826,7 +1826,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
filt->addr = start;
if (filt->range && !filt->size && !filt->sym_to) {
filt->size = size;
- no_size = !!size;
+ no_size = !size;
}
}
@@ -1840,7 +1840,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
if (err)
return err;
filt->size = start + size - filt->addr;
- no_size = !!size;
+ no_size = !size;
}
/* The very last symbol in kallsyms does not imply a particular size */
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web