Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609321 > unrolled thread

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

Started byAndrey Utkin <andrey_utkin@fastmail.com>
First post2017-03-26 13:30 +0200
Last post2017-03-28 13:40 +0200
Articles 8 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe Andrey Utkin <andrey_utkin@fastmail.com> - 2017-03-26 13:30 +0200
    Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe Zhang Rui <rui.zhang@intel.com> - 2017-03-27 04:50 +0200
      Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-27 18:40 +0200
        Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe Zhang Rui <rui.zhang@intel.com> - 2017-03-28 08:00 +0200
          Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe Zhang Rui <rui.zhang@intel.com> - 2017-03-28 11:00 +0200
            Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-28 12:40 +0200
              Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-03-28 12:50 +0200
                Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-28 13:40 +0200

#1609321 — Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

FromAndrey Utkin <andrey_utkin@fastmail.com>
Date2017-03-26 13:30 +0200
SubjectRe: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe
Message-ID<tpewW-7xq-3@gated-at.bofh.it>
On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman wrote:
> 4.10-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Zhang Rui <rui.zhang@intel.com>
> 
> commit e28d6f048799acb0014491e6b74e580d84bd7916 upstream.
> 
> With commit 67bf5156edc4 ("gpio / ACPI: fix returned error from
> acpi_dev_gpio_irq_get()"), mmc_gpiod_request_cd() returns -EPROBE_DEFER if
> GPIO is not ready when sdhci-acpi driver is probed, and sdhci-acpi driver
> should be probed again later in this case.
> 
> This fixes an order issue when both GPIO and sdhci-acpi drivers are built
> as modules.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177101
> Tested-by: Jonas Aaberg <cja@gmx.net>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> ---
>  drivers/mmc/host/sdhci-acpi.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -467,7 +467,10 @@ static int sdhci_acpi_probe(struct platf
>  	if (sdhci_acpi_flag(c, SDHCI_ACPI_SD_CD)) {
>  		bool v = sdhci_acpi_flag(c, SDHCI_ACPI_SD_CD_OVERRIDE_LEVEL);
>  
> -		if (mmc_gpiod_request_cd(host->mmc, NULL, 0, v, 0, NULL)) {
> +		err = mmc_gpiod_request_cd(host->mmc, NULL, 0, v, 0, NULL);
> +		if (err) {
> +			if (err == -EPROBE_DEFER)
> +				goto err_free;
>  			dev_warn(dev, "failed to setup card detect gpio\n");
>  			c->use_runtime_pm = false;
>  		}
> 
> 

Regression reported: https://bugzilla.kernel.org/show_bug.cgi?id=194871

Reverting this patch is said to fix the issue for 4.10.2.

[toc] | [next] | [standalone]

#1609434

FromZhang Rui <rui.zhang@intel.com>
Date2017-03-27 04:50 +0200
Message-ID<tpsTf-133-9@gated-at.bofh.it>
In reply to#1609321
On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote:
> On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman wrote:
> > 
> > 4.10-stable review patch.  If anyone has any objections, please let
> > me know.
> > 
> > ------------------
> > 
> > From: Zhang Rui <rui.zhang@intel.com>
> > 
> > commit e28d6f048799acb0014491e6b74e580d84bd7916 upstream.
> > 
> > With commit 67bf5156edc4 ("gpio / ACPI: fix returned error from
> > acpi_dev_gpio_irq_get()"), mmc_gpiod_request_cd() returns
> > -EPROBE_DEFER if
> > GPIO is not ready when sdhci-acpi driver is probed, and sdhci-acpi
> > driver
> > should be probed again later in this case.
> > 
> > This fixes an order issue when both GPIO and sdhci-acpi drivers are
> > built
> > as modules.
> > 
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177101
> > Tested-by: Jonas Aaberg <cja@gmx.net>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > 
> > ---
> >  drivers/mmc/host/sdhci-acpi.c |    5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > --- a/drivers/mmc/host/sdhci-acpi.c
> > +++ b/drivers/mmc/host/sdhci-acpi.c
> > @@ -467,7 +467,10 @@ static int sdhci_acpi_probe(struct platf
> >  	if (sdhci_acpi_flag(c, SDHCI_ACPI_SD_CD)) {
> >  		bool v = sdhci_acpi_flag(c,
> > SDHCI_ACPI_SD_CD_OVERRIDE_LEVEL);
> >  
> > -		if (mmc_gpiod_request_cd(host->mmc, NULL, 0, v, 0,
> > NULL)) {
> > +		err = mmc_gpiod_request_cd(host->mmc, NULL, 0, v,
> > 0, NULL);
> > +		if (err) {
> > +			if (err == -EPROBE_DEFER)
> > +				goto err_free;
> >  			dev_warn(dev, "failed to setup card detect
> > gpio\n");
> >  			c->use_runtime_pm = false;
> >  		}
> > 
> > 
> Regression reported: https://bugzilla.kernel.org/show_bug.cgi?id=1948
> 71
> 
> Reverting this patch is said to fix the issue for 4.10.2.

thanks for raising the issue. Let's see check why it breaks in the
bugzilla report.

thanks,
rui

[toc] | [prev] | [next] | [standalone]

#1609980

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-03-27 18:40 +0200
Message-ID<tpFQu-2sV-17@gated-at.bofh.it>
In reply to#1609434
On Mon, Mar 27, 2017 at 10:40:23AM +0800, Zhang Rui wrote:
> On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote:
> > On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman wrote:
> > > 
> > > 4.10-stable review patch.  If anyone has any objections, please let
> > > me know.
> > > 
> > > ------------------
> > > 
> > > From: Zhang Rui <rui.zhang@intel.com>
> > > 
> > > commit e28d6f048799acb0014491e6b74e580d84bd7916 upstream.
> > > 
> > > With commit 67bf5156edc4 ("gpio / ACPI: fix returned error from
> > > acpi_dev_gpio_irq_get()"), mmc_gpiod_request_cd() returns
> > > -EPROBE_DEFER if
> > > GPIO is not ready when sdhci-acpi driver is probed, and sdhci-acpi
> > > driver
> > > should be probed again later in this case.
> > > 
> > > This fixes an order issue when both GPIO and sdhci-acpi drivers are
> > > built
> > > as modules.
> > > 
> > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177101
> > > Tested-by: Jonas Aaberg <cja@gmx.net>
> > > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > > Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > 
> > > ---
> > >  drivers/mmc/host/sdhci-acpi.c |    5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > --- a/drivers/mmc/host/sdhci-acpi.c
> > > +++ b/drivers/mmc/host/sdhci-acpi.c
> > > @@ -467,7 +467,10 @@ static int sdhci_acpi_probe(struct platf
> > >  	if (sdhci_acpi_flag(c, SDHCI_ACPI_SD_CD)) {
> > >  		bool v = sdhci_acpi_flag(c,
> > > SDHCI_ACPI_SD_CD_OVERRIDE_LEVEL);
> > >  
> > > -		if (mmc_gpiod_request_cd(host->mmc, NULL, 0, v, 0,
> > > NULL)) {
> > > +		err = mmc_gpiod_request_cd(host->mmc, NULL, 0, v,
> > > 0, NULL);
> > > +		if (err) {
> > > +			if (err == -EPROBE_DEFER)
> > > +				goto err_free;
> > >  			dev_warn(dev, "failed to setup card detect
> > > gpio\n");
> > >  			c->use_runtime_pm = false;
> > >  		}
> > > 
> > > 
> > Regression reported: https://bugzilla.kernel.org/show_bug.cgi?id=1948
> > 71
> > 
> > Reverting this patch is said to fix the issue for 4.10.2.
> 
> thanks for raising the issue. Let's see check why it breaks in the
> bugzilla report.

Is this also broken in Linus's tree?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1610330

FromZhang Rui <rui.zhang@intel.com>
Date2017-03-28 08:00 +0200
Message-ID<tpSkF-36v-11@gated-at.bofh.it>
In reply to#1609980
On Mon, 2017-03-27 at 18:36 +0200, Greg Kroah-Hartman wrote:
> On Mon, Mar 27, 2017 at 10:40:23AM +0800, Zhang Rui wrote:
> > 
> > On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote:
> > > 
> > > On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman
> > > wrote:
> > > > 
> > > > 
> > > > 4.10-stable review patch.  If anyone has any objections, please
> > > > let
> > > > me know.
> > > > 
> > > > ------------------
> > > > 
> > > > From: Zhang Rui <rui.zhang@intel.com>
> > > > 
> > > > commit e28d6f048799acb0014491e6b74e580d84bd7916 upstream.
> > > > 
> > > > With commit 67bf5156edc4 ("gpio / ACPI: fix returned error from
> > > > acpi_dev_gpio_irq_get()"), mmc_gpiod_request_cd() returns
> > > > -EPROBE_DEFER if
> > > > GPIO is not ready when sdhci-acpi driver is probed, and sdhci-
> > > > acpi
> > > > driver
> > > > should be probed again later in this case.
> > > > 
> > > > This fixes an order issue when both GPIO and sdhci-acpi drivers
> > > > are
> > > > built
> > > > as modules.
> > > > 
> > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177101htt
> > > > ps://bugzilla.kernel.org/show_bug.cgi?id=177101
> > > > Tested-by: Jonas Aaberg <cja@gmx.net>
> > > > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > > > Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > 
> > > > ---
> > > >  drivers/mmc/host/sdhci-acpi.c |    5 ++++-
> > > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > > 
> > > > --- a/drivers/mmc/host/sdhci-acpi.c
> > > > +++ b/drivers/mmc/host/sdhci-acpi.c
> > > > @@ -467,7 +467,10 @@ static int sdhci_acpi_probe(struct platf
> > > >  	if (sdhci_acpi_flag(c, SDHCI_ACPI_SD_CD)) {
> > > >  		bool v = sdhci_acpi_flag(c,
> > > > SDHCI_ACPI_SD_CD_OVERRIDE_LEVEL);
> > > >  
> > > > -		if (mmc_gpiod_request_cd(host->mmc, NULL, 0,
> > > > v, 0,
> > > > NULL)) {
> > > > +		err = mmc_gpiod_request_cd(host->mmc, NULL, 0,
> > > > v,
> > > > 0, NULL);
> > > > +		if (err) {
> > > > +			if (err == -EPROBE_DEFER)
> > > > +				goto err_free;
> > > >  			dev_warn(dev, "failed to setup card
> > > > detect
> > > > gpio\n");
> > > >  			c->use_runtime_pm = false;
> > > >  		}
> > > > 
> > > > 
> > > Regression reported: https://bugzilla.kernel.org/show_bug.cgi?id=
> > > 1948
> > > 71
> > > 
> > > Reverting this patch is said to fix the issue for 4.10.2.
> > thanks for raising the issue. Let's see check why it breaks in the
> > bugzilla report.
> Is this also broken in Linus's tree?
> 
Well, I think so.

Although it's still under debugging, the root cause of the problem
seems to be that, when mmc_gpiod_request_cd() returns -EPROBE_DEFER, it
means either the GPIO controller driver is not probed at the moment, OR
the GPIO controller driver is not available at all. The later case
 causes the problem like this because sdhci-acpi driver is made to wait
for the GPIO controller, in the patch above. 

This is not a problem for distro kernel when all the driver are built
as modules. And the problem should be fixed by enabling the GPIO
controller driver in kernel config.

thanks,
rui

[toc] | [prev] | [next] | [standalone]

#1610423

FromZhang Rui <rui.zhang@intel.com>
Date2017-03-28 11:00 +0200
Message-ID<tpV8S-535-5@gated-at.bofh.it>
In reply to#1610330
On Tue, 2017-03-28 at 13:51 +0800, Zhang Rui wrote:
> On Mon, 2017-03-27 at 18:36 +0200, Greg Kroah-Hartman wrote:
> > 
> > On Mon, Mar 27, 2017 at 10:40:23AM +0800, Zhang Rui wrote:
> > > 
> > > 
> > > On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote:
> > > > 
> > > > 
> > > > On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman
> > > > wrote:
> > > > > 
> > > > > 
> > > > > 
> > > > > 4.10-stable review patch.  If anyone has any objections,
> > > > > please
> > > > > let
> > > > > me know.
> > > > > 
> > > > > ------------------
> > > > > 
> > > > > From: Zhang Rui <rui.zhang@intel.com>
> > > > > 
> > > > > commit e28d6f048799acb0014491e6b74e580d84bd7916 upstream.
> > > > > 
> > > > > With commit 67bf5156edc4 ("gpio / ACPI: fix returned error
> > > > > from
> > > > > acpi_dev_gpio_irq_get()"), mmc_gpiod_request_cd() returns
> > > > > -EPROBE_DEFER if
> > > > > GPIO is not ready when sdhci-acpi driver is probed, and
> > > > > sdhci-
> > > > > acpi
> > > > > driver
> > > > > should be probed again later in this case.
> > > > > 
> > > > > This fixes an order issue when both GPIO and sdhci-acpi
> > > > > drivers
> > > > > are
> > > > > built
> > > > > as modules.
> > > > > 
> > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177101h
> > > > > tt
> > > > > ps://bugzilla.kernel.org/show_bug.cgi?id=177101
> > > > > Tested-by: Jonas Aaberg <cja@gmx.net>
> > > > > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > > > > Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org
> > > > > >
> > > > > 
> > > > > ---
> > > > >  drivers/mmc/host/sdhci-acpi.c |    5 ++++-
> > > > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > > > 
> > > > > --- a/drivers/mmc/host/sdhci-acpi.c
> > > > > +++ b/drivers/mmc/host/sdhci-acpi.c
> > > > > @@ -467,7 +467,10 @@ static int sdhci_acpi_probe(struct platf
> > > > >  	if (sdhci_acpi_flag(c, SDHCI_ACPI_SD_CD)) {
> > > > >  		bool v = sdhci_acpi_flag(c,
> > > > > SDHCI_ACPI_SD_CD_OVERRIDE_LEVEL);
> > > > >  
> > > > > -		if (mmc_gpiod_request_cd(host->mmc, NULL, 0,
> > > > > v, 0,
> > > > > NULL)) {
> > > > > +		err = mmc_gpiod_request_cd(host->mmc, NULL,
> > > > > 0,
> > > > > v,
> > > > > 0, NULL);
> > > > > +		if (err) {
> > > > > +			if (err == -EPROBE_DEFER)
> > > > > +				goto err_free;
> > > > >  			dev_warn(dev, "failed to setup card
> > > > > detect
> > > > > gpio\n");
> > > > >  			c->use_runtime_pm = false;
> > > > >  		}
> > > > > 
> > > > > 
> > > > Regression reported: https://bugzilla.kernel.org/show_bug.cgi?i
> > > > d=
> > > > 1948
> > > > 71
> > > > 
> > > > Reverting this patch is said to fix the issue for 4.10.2.
> > > thanks for raising the issue. Let's see check why it breaks in
> > > the
> > > bugzilla report.
> > Is this also broken in Linus's tree?
> > 
> Well, I think so.
> 
> Although it's still under debugging, the root cause of the problem
> seems to be that, when mmc_gpiod_request_cd() returns -EPROBE_DEFER,
> it
> means either the GPIO controller driver is not probed at the moment,
> OR
> the GPIO controller driver is not available at all. The later case
>  causes the problem like this because sdhci-acpi driver is made to
> wait
> for the GPIO controller, in the patch above. 
> 
> This is not a problem for distro kernel when all the driver are built
> as modules. And the problem should be fixed by enabling the GPIO
> controller driver in kernel config.
> 
It's confirmed the problem is gone after enabling
CONFIG_PINCTRL_CHERRYVIEW,
https://bugzilla.kernel.org/show_bug.cgi?id=194871#c16

thanks,
rui
> thanks,
> rui

[toc] | [prev] | [next] | [standalone]

#1610551

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-03-28 12:40 +0200
Message-ID<tpWHE-6e9-9@gated-at.bofh.it>
In reply to#1610423
On Tue, Mar 28, 2017 at 04:51:20PM +0800, Zhang Rui wrote:
> On Tue, 2017-03-28 at 13:51 +0800, Zhang Rui wrote:
> > On Mon, 2017-03-27 at 18:36 +0200, Greg Kroah-Hartman wrote:
> > > 
> > > On Mon, Mar 27, 2017 at 10:40:23AM +0800, Zhang Rui wrote:
> > > > 
> > > > 
> > > > On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote:
> > > > > 
> > > > > 
> > > > > On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman
> > > > > wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 4.10-stable review patch.  If anyone has any objections,
> > > > > > please
> > > > > > let
> > > > > > me know.
> > > > > > 
> > > > > > ------------------
> > > > > > 
> > > > > > From: Zhang Rui <rui.zhang@intel.com>
> > > > > > 
> > > > > > commit e28d6f048799acb0014491e6b74e580d84bd7916 upstream.
> > > > > > 
> > > > > > With commit 67bf5156edc4 ("gpio / ACPI: fix returned error
> > > > > > from
> > > > > > acpi_dev_gpio_irq_get()"), mmc_gpiod_request_cd() returns
> > > > > > -EPROBE_DEFER if
> > > > > > GPIO is not ready when sdhci-acpi driver is probed, and
> > > > > > sdhci-
> > > > > > acpi
> > > > > > driver
> > > > > > should be probed again later in this case.
> > > > > > 
> > > > > > This fixes an order issue when both GPIO and sdhci-acpi
> > > > > > drivers
> > > > > > are
> > > > > > built
> > > > > > as modules.
> > > > > > 
> > > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177101h
> > > > > > tt
> > > > > > ps://bugzilla.kernel.org/show_bug.cgi?id=177101
> > > > > > Tested-by: Jonas Aaberg <cja@gmx.net>
> > > > > > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > > > > > Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> > > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org
> > > > > > >
> > > > > > 
> > > > > > ---
> > > > > >  drivers/mmc/host/sdhci-acpi.c |    5 ++++-
> > > > > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > > > > 
> > > > > > --- a/drivers/mmc/host/sdhci-acpi.c
> > > > > > +++ b/drivers/mmc/host/sdhci-acpi.c
> > > > > > @@ -467,7 +467,10 @@ static int sdhci_acpi_probe(struct platf
> > > > > >  	if (sdhci_acpi_flag(c, SDHCI_ACPI_SD_CD)) {
> > > > > >  		bool v = sdhci_acpi_flag(c,
> > > > > > SDHCI_ACPI_SD_CD_OVERRIDE_LEVEL);
> > > > > >  
> > > > > > -		if (mmc_gpiod_request_cd(host->mmc, NULL, 0,
> > > > > > v, 0,
> > > > > > NULL)) {
> > > > > > +		err = mmc_gpiod_request_cd(host->mmc, NULL,
> > > > > > 0,
> > > > > > v,
> > > > > > 0, NULL);
> > > > > > +		if (err) {
> > > > > > +			if (err == -EPROBE_DEFER)
> > > > > > +				goto err_free;
> > > > > >  			dev_warn(dev, "failed to setup card
> > > > > > detect
> > > > > > gpio\n");
> > > > > >  			c->use_runtime_pm = false;
> > > > > >  		}
> > > > > > 
> > > > > > 
> > > > > Regression reported: https://bugzilla.kernel.org/show_bug.cgi?i
> > > > > d=
> > > > > 1948
> > > > > 71
> > > > > 
> > > > > Reverting this patch is said to fix the issue for 4.10.2.
> > > > thanks for raising the issue. Let's see check why it breaks in
> > > > the
> > > > bugzilla report.
> > > Is this also broken in Linus's tree?
> > > 
> > Well, I think so.
> > 
> > Although it's still under debugging, the root cause of the problem
> > seems to be that, when mmc_gpiod_request_cd() returns -EPROBE_DEFER,
> > it
> > means either the GPIO controller driver is not probed at the moment,
> > OR
> > the GPIO controller driver is not available at all. The later case
> >  causes the problem like this because sdhci-acpi driver is made to
> > wait
> > for the GPIO controller, in the patch above. 
> > 
> > This is not a problem for distro kernel when all the driver are built
> > as modules. And the problem should be fixed by enabling the GPIO
> > controller driver in kernel config.
> > 
> It's confirmed the problem is gone after enabling
> CONFIG_PINCTRL_CHERRYVIEW,
> https://bugzilla.kernel.org/show_bug.cgi?id=194871#c16

Ok, what does that mean for the stable tree?

confused,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1610556

FromMika Westerberg <mika.westerberg@linux.intel.com>
Date2017-03-28 12:50 +0200
Message-ID<tpWRl-6j4-25@gated-at.bofh.it>
In reply to#1610551
On Tue, Mar 28, 2017 at 12:35:30PM +0200, Greg Kroah-Hartman wrote:
> > It's confirmed the problem is gone after enabling
> > CONFIG_PINCTRL_CHERRYVIEW,
> > https://bugzilla.kernel.org/show_bug.cgi?id=194871#c16
> 
> Ok, what does that mean for the stable tree?

I don't think there is anything the stable tree needs to do here.

Distros should just make sure they include necessary drivers in their
initrds if they need GPIOs etc.

[toc] | [prev] | [next] | [standalone]

#1610608

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-03-28 13:40 +0200
Message-ID<tpXDJ-6Qq-31@gated-at.bofh.it>
In reply to#1610556
On Tue, Mar 28, 2017 at 01:46:51PM +0300, Mika Westerberg wrote:
> On Tue, Mar 28, 2017 at 12:35:30PM +0200, Greg Kroah-Hartman wrote:
> > > It's confirmed the problem is gone after enabling
> > > CONFIG_PINCTRL_CHERRYVIEW,
> > > https://bugzilla.kernel.org/show_bug.cgi?id=194871#c16
> > 
> > Ok, what does that mean for the stable tree?
> 
> I don't think there is anything the stable tree needs to do here.
> 
> Distros should just make sure they include necessary drivers in their
> initrds if they need GPIOs etc.

Ok, thanks for the explaination.

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web