Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1608623 > unrolled thread

[PATCH] selftests/futex: Fix build error with OUTPUT variable

Started byDarren Hart <dvhart@infradead.org>
First post2017-03-24 17:20 +0100
Last post2017-03-28 04:30 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] selftests/futex: Fix build error with OUTPUT variable Darren Hart <dvhart@infradead.org> - 2017-03-24 17:20 +0100
    Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable Bamvor Zhang <bamv2005@gmail.com> - 2017-03-26 15:10 +0200
    Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable Michael Ellerman <mpe@ellerman.id.au> - 2017-03-28 02:30 +0200
      Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable Darren Hart <dvhart@infradead.org> - 2017-03-28 04:30 +0200

#1608623 — [PATCH] selftests/futex: Fix build error with OUTPUT variable

FromDarren Hart <dvhart@infradead.org>
Date2017-03-24 17:20 +0100
Subject[PATCH] selftests/futex: Fix build error with OUTPUT variable
Message-ID<toA6v-48t-37@gated-at.bofh.it>
The use of $$OUTPUT in the target shell commands resulted in an empty
string followed by an absolute path for which mkdir failed:

$ make -C tools/testing/selftests/futex
make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex'
Makefile:36: warning: overriding recipe for target 'clean'
../lib.mk:55: warning: ignoring old recipe for target 'clean'
for DIR in functional; do		\
	BUILD_TARGET=$OUTPUT/$DIR;	\
	mkdir $BUILD_TARGET  -p;	\
	make OUTPUT=$BUILD_TARGET -C $DIR all;\
done
mkdir: cannot create directory ‘/functional’: Permission denied

Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT
variable. The above make command now completes successfully.

Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
Cc: linux-kselftest@vger.kernel.org
Cc: bamvor.zhangjian@huawei.com
Cc: Shuah Khan <shuah@kernel.org>
Cc: <stable@vger.kernel.org> # 4.10.x-
---
 tools/testing/selftests/futex/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index 653c5cd..c8095e6 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -8,7 +8,7 @@ include ../lib.mk
 
 all:
 	for DIR in $(SUBDIRS); do		\
-		BUILD_TARGET=$$OUTPUT/$$DIR;	\
+		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
 		mkdir $$BUILD_TARGET  -p;	\
 		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
 	done
@@ -22,7 +22,7 @@ override define INSTALL_RULE
 	install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
 
 	@for SUBDIR in $(SUBDIRS); do \
-		BUILD_TARGET=$$OUTPUT/$$SUBDIR;	\
+		BUILD_TARGET=$(OUTPUT)/$$SUBDIR;	\
 		mkdir $$BUILD_TARGET  -p;	\
 		$(MAKE) OUTPUT=$$BUILD_TARGET -C $$SUBDIR INSTALL_PATH=$(INSTALL_PATH)/$$SUBDIR install; \
 	done;
@@ -34,7 +34,7 @@ endef
 
 clean:
 	for DIR in $(SUBDIRS); do		\
-		BUILD_TARGET=$$OUTPUT/$$DIR;	\
+		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
 		mkdir $$BUILD_TARGET  -p;	\
 		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
 	done
-- 
2.9.3


-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [next] | [standalone]

#1609327

FromBamvor Zhang <bamv2005@gmail.com>
Date2017-03-26 15:10 +0200
Message-ID<tpg5H-ki-11@gated-at.bofh.it>
In reply to#1608623
Hi,

On Sat, Mar 25, 2017 at 12:18 AM, Darren Hart <dvhart@infradead.org> wrote:
>
> The use of $$OUTPUT in the target shell commands resulted in an empty
> string followed by an absolute path for which mkdir failed:
>
> $ make -C tools/testing/selftests/futex
> make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex'
> Makefile:36: warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
> for DIR in functional; do               \
>         BUILD_TARGET=$OUTPUT/$DIR;      \
>         mkdir $BUILD_TARGET  -p;        \
>         make OUTPUT=$BUILD_TARGET -C $DIR all;\
> done
> mkdir: cannot create directory ‘/functional’: Permission denied
>
> Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT
> variable. The above make command now completes successfully.
Test with native and cross-compiler build from selftests/futex or selftests,
the results are good.
Tested-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>

Regards

Bamvor
>
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> Cc: linux-kselftest@vger.kernel.org
> Cc: bamvor.zhangjian@huawei.com
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: <stable@vger.kernel.org> # 4.10.x-
> ---
>  tools/testing/selftests/futex/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index 653c5cd..c8095e6 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -8,7 +8,7 @@ include ../lib.mk
>
>  all:
>         for DIR in $(SUBDIRS); do               \
> -               BUILD_TARGET=$$OUTPUT/$$DIR;    \
> +               BUILD_TARGET=$(OUTPUT)/$$DIR;   \
>                 mkdir $$BUILD_TARGET  -p;       \
>                 make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>         done
> @@ -22,7 +22,7 @@ override define INSTALL_RULE
>         install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
>
>         @for SUBDIR in $(SUBDIRS); do \
> -               BUILD_TARGET=$$OUTPUT/$$SUBDIR; \
> +               BUILD_TARGET=$(OUTPUT)/$$SUBDIR;        \
>                 mkdir $$BUILD_TARGET  -p;       \
>                 $(MAKE) OUTPUT=$$BUILD_TARGET -C $$SUBDIR INSTALL_PATH=$(INSTALL_PATH)/$$SUBDIR install; \
>         done;
> @@ -34,7 +34,7 @@ endef
>
>  clean:
>         for DIR in $(SUBDIRS); do               \
> -               BUILD_TARGET=$$OUTPUT/$$DIR;    \
> +               BUILD_TARGET=$(OUTPUT)/$$DIR;   \
>                 mkdir $$BUILD_TARGET  -p;       \
>                 make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>         done
> --
> 2.9.3
>
>
> --
> Darren Hart
> VMware Open Source Technology Center




-- 
-----------------------------------------
   arm64, kernel. opensuse
   blog: http://aarch64.me
-----------------------------------------

[toc] | [prev] | [next] | [standalone]

#1610176

FromMichael Ellerman <mpe@ellerman.id.au>
Date2017-03-28 02:30 +0200
Message-ID<tpNbj-7QT-3@gated-at.bofh.it>
In reply to#1608623
Darren Hart <dvhart@infradead.org> writes:

> The use of $$OUTPUT in the target shell commands resulted in an empty
> string followed by an absolute path for which mkdir failed:
>
> $ make -C tools/testing/selftests/futex
> make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex'
> Makefile:36: warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
> for DIR in functional; do		\
> 	BUILD_TARGET=$OUTPUT/$DIR;	\
> 	mkdir $BUILD_TARGET  -p;	\
> 	make OUTPUT=$BUILD_TARGET -C $DIR all;\
> done
> mkdir: cannot create directory ‘/functional’: Permission denied
>
> Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT
> variable. The above make command now completes successfully.
>
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> Cc: linux-kselftest@vger.kernel.org
> Cc: bamvor.zhangjian@huawei.com
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: <stable@vger.kernel.org> # 4.10.x-

The OUTPUT support only went into v4.11-rc1, so I don't see why you need
a stable tag?

Change looks good though.

cheers

[toc] | [prev] | [next] | [standalone]

#1610264

FromDarren Hart <dvhart@infradead.org>
Date2017-03-28 04:30 +0200
Message-ID<tpP3r-Sl-1@gated-at.bofh.it>
In reply to#1610176
On Tue, Mar 28, 2017 at 11:19:25AM +1100, Michael Ellerman wrote:
> Darren Hart <dvhart@infradead.org> writes:
> 
> > The use of $$OUTPUT in the target shell commands resulted in an empty
> > string followed by an absolute path for which mkdir failed:
> >
> > $ make -C tools/testing/selftests/futex
> > make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex'
> > Makefile:36: warning: overriding recipe for target 'clean'
> > ../lib.mk:55: warning: ignoring old recipe for target 'clean'
> > for DIR in functional; do		\
> > 	BUILD_TARGET=$OUTPUT/$DIR;	\
> > 	mkdir $BUILD_TARGET  -p;	\
> > 	make OUTPUT=$BUILD_TARGET -C $DIR all;\
> > done
> > mkdir: cannot create directory ‘/functional’: Permission denied
> >
> > Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT
> > variable. The above make command now completes successfully.
> >
> > Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> > Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> > Cc: linux-kselftest@vger.kernel.org
> > Cc: bamvor.zhangjian@huawei.com
> > Cc: Shuah Khan <shuah@kernel.org>
> > Cc: <stable@vger.kernel.org> # 4.10.x-
> 
> The OUTPUT support only went into v4.11-rc1, so I don't see why you need
> a stable tag?

Git spelunking failure on my part, you are correct. Please disregard the stable
tag.

> 
> Change looks good though.
> 

Thank you for the review.

-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web