Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609899 > unrolled thread
| Started by | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| First post | 2017-03-27 16:50 +0200 |
| Last post | 2017-04-03 15:30 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] drm/sun4i: Add display backend interrupt to dt binding Chen-Yu Tsai <wens@csie.org> - 2017-03-27 16:50 +0200
[PATCH 1/2] drm/sun4i: Add display backend interrupt to device tree binding Chen-Yu Tsai <wens@csie.org> - 2017-03-27 16:50 +0200
Re: [PATCH 1/2] drm/sun4i: Add display backend interrupt to device tree binding Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-29 09:20 +0200
Re: [PATCH 1/2] drm/sun4i: Add display backend interrupt to device tree binding Rob Herring <robh@kernel.org> - 2017-04-03 15:30 +0200
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-03-27 16:50 +0200 |
| Subject | [PATCH 0/2] drm/sun4i: Add display backend interrupt to dt binding |
| Message-ID | <tpDYl-XG-5@gated-at.bofh.it> |
Hi Maxime, As promised, here is the patch adding the interrupt line for the display backend to the sun5i shared dtsi, and another one adding it to the device tree bindings. The display backend has an undocumented (in the user manual) interrupt that, according to vendor code, is raised when the current scanout is completed. This might be a better fit for DRM/KMS vblank signalling, rather than the TCON's vblank interrupt. If true, it would allow us to cut out the TCON from the crtc in the driver, instead keeping it solely as an encoder, simplifying some of the inter-component code. Regardless, the interrupt line exists and should be added to the device tree. Regards ChenYu Chen-Yu Tsai (2): drm/sun4i: Add display backend interrupt to device tree binding ARM: dts: sun5i: Add interrupt for display backend Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 2 ++ arch/arm/boot/dts/sun5i.dtsi | 1 + 2 files changed, 3 insertions(+) -- 2.11.0
[toc] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-03-27 16:50 +0200 |
| Subject | [PATCH 1/2] drm/sun4i: Add display backend interrupt to device tree binding |
| Message-ID | <tpE82-11f-21@gated-at.bofh.it> |
| In reply to | #1609899 |
The display backend has an interrupt line. Add it to the device tree
binding.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
index b82c00449468..57a8d0610062 100644
--- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
+++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
@@ -94,6 +94,7 @@ Required properties:
* allwinner,sun6i-a31-display-backend
* allwinner,sun8i-a33-display-backend
- reg: base address and size of the memory-mapped region.
+ - interrupts: interrupt associated to this IP
- clocks: phandles to the clocks feeding the frontend and backend
* ahb: the backend interface clock
* mod: the backend module clock
@@ -265,6 +266,7 @@ fe0: display-frontend@1e00000 {
be0: display-backend@1e60000 {
compatible = "allwinner,sun5i-a13-display-backend";
reg = <0x01e60000 0x10000>;
+ interrupts = <47>;
clocks = <&ahb_gates 44>, <&de_be_clk>,
<&dram_gates 26>;
clock-names = "ahb", "mod",
--
2.11.0
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-03-29 09:20 +0200 |
| Subject | Re: [PATCH 1/2] drm/sun4i: Add display backend interrupt to device tree binding |
| Message-ID | <tqg3E-3we-11@gated-at.bofh.it> |
| In reply to | #1609904 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, Mar 27, 2017 at 10:38:46PM +0800, Chen-Yu Tsai wrote: > The display backend has an interrupt line. Add it to the device tree > binding. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> The patches prefix for the binding documentation is usually dt-bindings: I've changed that and applied that patch, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-04-03 15:30 +0200 |
| Subject | Re: [PATCH 1/2] drm/sun4i: Add display backend interrupt to device tree binding |
| Message-ID | <tsads-7pt-21@gated-at.bofh.it> |
| In reply to | #1609904 |
On Mon, Mar 27, 2017 at 10:38:46PM +0800, Chen-Yu Tsai wrote: > The display backend has an interrupt line. Add it to the device tree > binding. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Rob Herring <robh@kernel.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web