Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1609157 > unrolled thread

[PATCH V3] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

Started bySinan Kaya <okaya@codeaurora.org>
First post2017-03-25 15:10 +0100
Last post2017-03-27 16:30 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH V3] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF Sinan Kaya <okaya@codeaurora.org> - 2017-03-25 15:10 +0100
    Re: [PATCH V3] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF Corey Minyard <minyard@acm.org> - 2017-03-26 03:30 +0200
      Re: [PATCH V3] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF Sinan Kaya <okaya@codeaurora.org> - 2017-03-27 16:30 +0200

#1609157 — [PATCH V3] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

FromSinan Kaya <okaya@codeaurora.org>
Date2017-03-25 15:10 +0100
Subject[PATCH V3] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF
Message-ID<toUyd-1Tc-3@gated-at.bofh.it>
ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI)
driver to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC
interfaces.

IPMI_SSIF is an alternative BMC communication method. It allows BMC to
be accessed over an I2C bus instead of a standard interface.

Change the dependency to IPMI_HANDLER so that ACPI_IPMI works with all
IPMI providers.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/acpi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 83e5f7e..3e15bf8 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -256,7 +256,7 @@ config ACPI_PROCESSOR
 
 config ACPI_IPMI
 	tristate "IPMI"
-	depends on IPMI_SI
+	depends on IPMI_HANDLER
 	default n
 	help
 	  This driver enables the ACPI to access the BMC controller. And it
-- 
1.9.1

[toc] | [next] | [standalone]


#1609267

FromCorey Minyard <minyard@acm.org>
Date2017-03-26 03:30 +0200
Message-ID<tp5ah-PA-3@gated-at.bofh.it>
In reply to#1609157
On 03/25/2017 09:02 AM, Sinan Kaya wrote:
> ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI)
> driver to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC
> interfaces.
>
> IPMI_SSIF is an alternative BMC communication method. It allows BMC to
> be accessed over an I2C bus instead of a standard interface.
>
> Change the dependency to IPMI_HANDLER so that ACPI_IPMI works with all
> IPMI providers.

If the ACPI people ack this, I can queue it, or they can take it with:

Acked-by: Corey Minyard <cminyard@mvista.com>

Thanks,

-corey

> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> ---
>   drivers/acpi/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 83e5f7e..3e15bf8 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -256,7 +256,7 @@ config ACPI_PROCESSOR
>   
>   config ACPI_IPMI
>   	tristate "IPMI"
> -	depends on IPMI_SI
> +	depends on IPMI_HANDLER
>   	default n
>   	help
>   	  This driver enables the ACPI to access the BMC controller. And it

[toc] | [prev] | [next] | [standalone]


#1609886

FromSinan Kaya <okaya@codeaurora.org>
Date2017-03-27 16:30 +0200
Message-ID<tpDOG-Ur-19@gated-at.bofh.it>
In reply to#1609267
Rafael,

On 3/25/2017 9:25 PM, Corey Minyard wrote:
> If the ACPI people ack this, I can queue it, or they can take it with:
> 
> Acked-by: Corey Minyard <cminyard@mvista.com>

What's your preference?

Sinan

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web