Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1607968 > unrolled thread

Re: [PATCH 17/46] selinux: Delete an unnecessary variable assignment in filename_trans_read()

Started byPaul Moore <paul@paul-moore.com>
First post2017-03-23 23:10 +0100
Last post2017-03-23 23:10 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 17/46] selinux: Delete an unnecessary variable assignment  in filename_trans_read() Paul Moore <paul@paul-moore.com> - 2017-03-23 23:10 +0100

#1607968 — Re: [PATCH 17/46] selinux: Delete an unnecessary variable assignment in filename_trans_read()

FromPaul Moore <paul@paul-moore.com>
Date2017-03-23 23:10 +0100
SubjectRe: [PATCH 17/46] selinux: Delete an unnecessary variable assignment in filename_trans_read()
Message-ID<toj5D-ic-7@gated-at.bofh.it>
On Sun, Jan 15, 2017 at 10:17 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 14 Jan 2017 19:02:42 +0100
>
> The local variable "ft" was set to a null pointer despite of an
> immediate reassignment.
> Thus remove this statement from the beginning of a loop.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  security/selinux/ss/policydb.c | 1 -
>  1 file changed, 1 deletion(-)

Merged, thanks.

> diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
> index 106a1da1d68a..2be5b18eb149 100644
> --- a/security/selinux/ss/policydb.c
> +++ b/security/selinux/ss/policydb.c
> @@ -1927,7 +1927,6 @@ static int filename_trans_read(struct policydb *p, void *fp)
>         nel = le32_to_cpu(buf[0]);
>
>         for (i = 0; i < nel; i++) {
> -               ft = NULL;
>                 otype = NULL;
>                 name = NULL;
>                 ft = kzalloc(sizeof(*ft), GFP_KERNEL);
> --
> 2.11.0
>



-- 
paul moore
www.paul-moore.com

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web