Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1602898 > unrolled thread
| Started by | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| First post | 2017-03-16 23:40 +0100 |
| Last post | 2017-03-23 18:40 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping() Matthias Kaehlcke <mka@chromium.org> - 2017-03-16 23:40 +0100
Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping() Grant Grundler <grundler@chromium.org> - 2017-03-23 01:40 +0100
Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping() Paul Moore <paul@paul-moore.com> - 2017-03-23 13:10 +0100
Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping() Grant Grundler <grundler@chromium.org> - 2017-03-23 18:40 +0100
| From | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| Date | 2017-03-16 23:40 +0100 |
| Subject | [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping() |
| Message-ID | <tlMdQ-4Yc-9@gated-at.bofh.it> |
'perms' will never be NULL since it isn't a plain pointer but an array
of u32 values.
This fixes the following warning when building with clang:
security/selinux/ss/services.c:158:16: error: address of array
'p_in->perms' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
while (p_in->perms && p_in->perms[k]) {
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
security/selinux/ss/services.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index 082b20c78363..2f20b5f974f4 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -155,7 +155,7 @@ static int selinux_set_mapping(struct policydb *pol,
}
k = 0;
- while (p_in->perms && p_in->perms[k]) {
+ while (p_in->perms[k]) {
/* An empty permission string skips ahead */
if (!*p_in->perms[k]) {
k++;
--
2.12.0.367.g23dc2f6d3c-goog
[toc] | [next] | [standalone]
| From | Grant Grundler <grundler@chromium.org> |
|---|---|
| Date | 2017-03-23 01:40 +0100 |
| Message-ID | <tnYXf-2Br-5@gated-at.bofh.it> |
| In reply to | #1602898 |
[resending as plain text only - sorry]
Ping? Any feedback on this patch?
LGTM.
cheers,
grant
On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> 'perms' will never be NULL since it isn't a plain pointer but an array
> of u32 values.
>
> This fixes the following warning when building with clang:
>
> security/selinux/ss/services.c:158:16: error: address of array
> 'p_in->perms' will always evaluate to 'true'
> [-Werror,-Wpointer-bool-conversion]
> while (p_in->perms && p_in->perms[k]) {
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> security/selinux/ss/services.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
> index 082b20c78363..2f20b5f974f4 100644
> --- a/security/selinux/ss/services.c
> +++ b/security/selinux/ss/services.c
> @@ -155,7 +155,7 @@ static int selinux_set_mapping(struct policydb *pol,
> }
>
> k = 0;
> - while (p_in->perms && p_in->perms[k]) {
> + while (p_in->perms[k]) {
> /* An empty permission string skips ahead */
> if (!*p_in->perms[k]) {
> k++;
> --
> 2.12.0.367.g23dc2f6d3c-goog
>
[toc] | [prev] | [next] | [standalone]
| From | Paul Moore <paul@paul-moore.com> |
|---|---|
| Date | 2017-03-23 13:10 +0100 |
| Message-ID | <to9IZ-21Y-5@gated-at.bofh.it> |
| In reply to | #1602898 |
On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler <grundler@chromium.org> wrote:
> Ping? Any feedback on this patch?
It's on my list of patches to review, patience please.
> On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
>>
>> 'perms' will never be NULL since it isn't a plain pointer but an array
>> of u32 values.
>>
>> This fixes the following warning when building with clang:
>>
>> security/selinux/ss/services.c:158:16: error: address of array
>> 'p_in->perms' will always evaluate to 'true'
>> [-Werror,-Wpointer-bool-conversion]
>> while (p_in->perms && p_in->perms[k]) {
>>
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> security/selinux/ss/services.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/security/selinux/ss/services.c
>> b/security/selinux/ss/services.c
>> index 082b20c78363..2f20b5f974f4 100644
>> --- a/security/selinux/ss/services.c
>> +++ b/security/selinux/ss/services.c
>> @@ -155,7 +155,7 @@ static int selinux_set_mapping(struct policydb *pol,
>> }
>>
>> k = 0;
>> - while (p_in->perms && p_in->perms[k]) {
>> + while (p_in->perms[k]) {
>> /* An empty permission string skips ahead */
>> if (!*p_in->perms[k]) {
>> k++;
>> --
>> 2.12.0.367.g23dc2f6d3c-goog
>>
>
--
paul moore
www.paul-moore.com
[toc] | [prev] | [next] | [standalone]
| From | Grant Grundler <grundler@chromium.org> |
|---|---|
| Date | 2017-03-23 18:40 +0100 |
| Message-ID | <toeSl-5uK-1@gated-at.bofh.it> |
| In reply to | #1607413 |
On Thu, Mar 23, 2017 at 5:08 AM, Paul Moore <paul@paul-moore.com> wrote:
> On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler <grundler@chromium.org> wrote:
>> Ping? Any feedback on this patch?
>
> It's on my list of patches to review, patience please.
No problem! Thank you!
just wanted confirmation it wasn't overlooked.
cheers,
grant
>
>> On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
>>>
>>> 'perms' will never be NULL since it isn't a plain pointer but an array
>>> of u32 values.
>>>
>>> This fixes the following warning when building with clang:
>>>
>>> security/selinux/ss/services.c:158:16: error: address of array
>>> 'p_in->perms' will always evaluate to 'true'
>>> [-Werror,-Wpointer-bool-conversion]
>>> while (p_in->perms && p_in->perms[k]) {
>>>
>>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>>> ---
>>> security/selinux/ss/services.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/security/selinux/ss/services.c
>>> b/security/selinux/ss/services.c
>>> index 082b20c78363..2f20b5f974f4 100644
>>> --- a/security/selinux/ss/services.c
>>> +++ b/security/selinux/ss/services.c
>>> @@ -155,7 +155,7 @@ static int selinux_set_mapping(struct policydb *pol,
>>> }
>>>
>>> k = 0;
>>> - while (p_in->perms && p_in->perms[k]) {
>>> + while (p_in->perms[k]) {
>>> /* An empty permission string skips ahead */
>>> if (!*p_in->perms[k]) {
>>> k++;
>>> --
>>> 2.12.0.367.g23dc2f6d3c-goog
>>>
>>
>
>
>
> --
> paul moore
> www.paul-moore.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web