Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1607642 > unrolled thread
| Started by | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| First post | 2017-03-23 17:00 +0100 |
| Last post | 2017-03-25 15:10 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF Sinan Kaya <okaya@codeaurora.org> - 2017-03-23 17:00 +0100
Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF Timur Tabi <timur@codeaurora.org> - 2017-03-23 17:00 +0100
Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF Corey Minyard <minyard@acm.org> - 2017-03-25 04:00 +0100
Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF Sinan Kaya <okaya@codeaurora.org> - 2017-03-25 15:10 +0100
| From | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| Date | 2017-03-23 17:00 +0100 |
| Subject | [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF |
| Message-ID | <todjz-4ib-1@gated-at.bofh.it> |
ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces. IPMI_SSIF is an alternative BMC communication method. It allows BMC to be accessed over an I2C bus instead of a standard interface. Enabling ACPI_IPMI over IPMI_SSIF with this change. Signed-off-by: Sinan Kaya <okaya@codeaurora.org> --- drivers/acpi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 83e5f7e..8767062 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -256,7 +256,7 @@ config ACPI_PROCESSOR config ACPI_IPMI tristate "IPMI" - depends on IPMI_SI + depends on IPMI_SI||IPMI_SSIF default n help This driver enables the ACPI to access the BMC controller. And it -- 1.9.1
[toc] | [next] | [standalone]
| From | Timur Tabi <timur@codeaurora.org> |
|---|---|
| Date | 2017-03-23 17:00 +0100 |
| Message-ID | <todjz-4ib-9@gated-at.bofh.it> |
| In reply to | #1607642 |
On 03/23/2017 10:53 AM, Sinan Kaya wrote: > + depends on IPMI_SI||IPMI_SSIF Blank spaces around ||. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
[toc] | [prev] | [next] | [standalone]
| From | Corey Minyard <minyard@acm.org> |
|---|---|
| Date | 2017-03-25 04:00 +0100 |
| Message-ID | <toK5Q-2HT-9@gated-at.bofh.it> |
| In reply to | #1607642 |
Oops, yes, this is an issue. However, it should probably depend on IPMI_HANDLER, not the individual interface types. -corey On 03/23/2017 10:53 AM, Sinan Kaya wrote: > ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver > to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces. > > IPMI_SSIF is an alternative BMC communication method. It allows BMC to be > accessed over an I2C bus instead of a standard interface. > > Enabling ACPI_IPMI over IPMI_SSIF with this change. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > --- > drivers/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 83e5f7e..8767062 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -256,7 +256,7 @@ config ACPI_PROCESSOR > > config ACPI_IPMI > tristate "IPMI" > - depends on IPMI_SI > + depends on IPMI_SI||IPMI_SSIF > default n > help > This driver enables the ACPI to access the BMC controller. And it
[toc] | [prev] | [next] | [standalone]
| From | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| Date | 2017-03-25 15:10 +0100 |
| Message-ID | <toUyd-1Tc-5@gated-at.bofh.it> |
| In reply to | #1609071 |
On 3/24/2017 10:56 PM, Corey Minyard wrote: > Oops, yes, this is an issue. > > However, it should probably depend on IPMI_HANDLER, not the individual interface types. > Thanks for the review. I posted V3 with your recommendation. > -corey -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web