Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1607632 > unrolled thread
| Started by | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| First post | 2017-03-23 16:40 +0100 |
| Last post | 2017-03-25 15:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ACPI / IPMI: change warning to debug on timeout Sinan Kaya <okaya@codeaurora.org> - 2017-03-23 16:40 +0100
Re: [PATCH] ACPI / IPMI: change warning to debug on timeout Corey Minyard <minyard@acm.org> - 2017-03-25 04:00 +0100
Re: [PATCH] ACPI / IPMI: change warning to debug on timeout Sinan Kaya <okaya@codeaurora.org> - 2017-03-25 15:10 +0100
| From | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| Date | 2017-03-23 16:40 +0100 |
| Subject | [PATCH] ACPI / IPMI: change warning to debug on timeout |
| Message-ID | <tod0e-4a5-17@gated-at.bofh.it> |
Getting timeout message from BMC when trying to read from a non-existent
FRU. This is expected but warning is not.
Let's reduce the warning to debug.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/acpi/acpi_ipmi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c
index 747c2ba..1b64419 100644
--- a/drivers/acpi/acpi_ipmi.c
+++ b/drivers/acpi/acpi_ipmi.c
@@ -429,8 +429,7 @@ static void ipmi_msg_handler(struct ipmi_recv_msg *msg, void *user_msg_data)
if (msg->recv_type == IPMI_RESPONSE_RECV_TYPE &&
msg->msg.data_len == 1) {
if (msg->msg.data[0] == IPMI_TIMEOUT_COMPLETION_CODE) {
- dev_WARN_ONCE(dev, true,
- "Unexpected response (timeout).\n");
+ dev_dbg_once(dev, "Unexpected response (timeout).\n");
tx_msg->msg_done = ACPI_IPMI_TIMEOUT;
}
goto out_comp;
--
1.9.1
[toc] | [next] | [standalone]
| From | Corey Minyard <minyard@acm.org> |
|---|---|
| Date | 2017-03-25 04:00 +0100 |
| Message-ID | <toK5Q-2HT-11@gated-at.bofh.it> |
| In reply to | #1607632 |
Why would a timeout for a message be expected? The BMC should
at least respond with an error for an incorrect message.
-corey
On 03/23/2017 10:32 AM, Sinan Kaya wrote:
> Getting timeout message from BMC when trying to read from a non-existent
> FRU. This is expected but warning is not.
>
> Let's reduce the warning to debug.
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> ---
> drivers/acpi/acpi_ipmi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c
> index 747c2ba..1b64419 100644
> --- a/drivers/acpi/acpi_ipmi.c
> +++ b/drivers/acpi/acpi_ipmi.c
> @@ -429,8 +429,7 @@ static void ipmi_msg_handler(struct ipmi_recv_msg *msg, void *user_msg_data)
> if (msg->recv_type == IPMI_RESPONSE_RECV_TYPE &&
> msg->msg.data_len == 1) {
> if (msg->msg.data[0] == IPMI_TIMEOUT_COMPLETION_CODE) {
> - dev_WARN_ONCE(dev, true,
> - "Unexpected response (timeout).\n");
> + dev_dbg_once(dev, "Unexpected response (timeout).\n");
> tx_msg->msg_done = ACPI_IPMI_TIMEOUT;
> }
> goto out_comp;
[toc] | [prev] | [next] | [standalone]
| From | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| Date | 2017-03-25 15:10 +0100 |
| Message-ID | <toUyd-1Tc-9@gated-at.bofh.it> |
| In reply to | #1609072 |
On 3/24/2017 10:55 PM, Corey Minyard wrote:
> Why would a timeout for a message be expected? The BMC should
> at least respond with an error for an incorrect message.
Let me add some more context...
In this particular case, the FRU ID that I was trying to access was
correct.
Platform supports PCIe hotplug. The FRU is embedded into the HW that
is being removed. That's what I mean by non-existent.
When the device is ejected and a FRU command is executed, BMC times out
reaching to the FRU on the device.
When the device is inserted, everything works as expected.
>
> -corey
>
> On 03/23/2017 10:32 AM, Sinan Kaya wrote:
>> Getting timeout message from BMC when trying to read from a non-existent
>> FRU. This is expected but warning is not.
>>
>> Let's reduce the warning to debug.
>>
>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
>> ---
>> drivers/acpi/acpi_ipmi.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c
>> index 747c2ba..1b64419 100644
>> --- a/drivers/acpi/acpi_ipmi.c
>> +++ b/drivers/acpi/acpi_ipmi.c
>> @@ -429,8 +429,7 @@ static void ipmi_msg_handler(struct ipmi_recv_msg *msg, void *user_msg_data)
>> if (msg->recv_type == IPMI_RESPONSE_RECV_TYPE &&
>> msg->msg.data_len == 1) {
>> if (msg->msg.data[0] == IPMI_TIMEOUT_COMPLETION_CODE) {
>> - dev_WARN_ONCE(dev, true,
>> - "Unexpected response (timeout).\n");
>> + dev_dbg_once(dev, "Unexpected response (timeout).\n");
>> tx_msg->msg_done = ACPI_IPMI_TIMEOUT;
>> }
>> goto out_comp;
>
>
>
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web