Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1606886 > unrolled thread

[PATCH v3 0/5] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v3 0/5] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-22 19:30 +0100
    [PATCH v3 2/5] pata_bk3710: disable IORDY Timer on chipset  initialization Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-22 19:30 +0100
      Re: [PATCH v3 2/5] pata_bk3710: disable IORDY Timer on chipset  initialization Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-23 11:50 +0100
    [PATCH v3 4/5] ARM: davinci: add pata_bk3710 libata driver support Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-22 19:30 +0100
    [PATCH v3 5/5] ARM: davinci_all_defconfig: convert to use libata PATA Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-22 19:30 +0100
    [PATCH v3 3/5] pata_bk3710: clear status bits of BMISP on chipset  initialization Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-22 19:30 +0100
      Re: [PATCH v3 3/5] pata_bk3710: clear status bits of BMISP on chipset  initialization Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-23 11:50 +0100
    Re: [PATCH v3 0/5] ATA/ARM: convert ARM/DaVinci to use libata PATA  drivers Sekhar Nori <nsekhar@ti.com> - 2017-03-23 15:00 +0100
      Re: [PATCH v3 0/5] ATA/ARM: convert ARM/DaVinci to use libata PATA  drivers Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-24 16:40 +0100

#1606886 — [PATCH v3 0/5] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers

Hi,

This patchset adds Palmchip BK3710 IDE controller driver to
libata and switches ARM/DaVinci to use it (instead of the old
IDE driver).

Sekhar, please check that it still works after changes, thanks.

Changes since v2
(https://www.spinics.net/lists/arm-kernel/msg568597.html):
- fixed 'checkpatch.pl --strict' issues reported by Sekhar
- added chipset initialization fixups in the new patches #2-3
  (based on the review comments from Sergei)

Changes since v1
(https://www.spinics.net/lists/arm-kernel/msg567442.html):
- addressed review comments from Sergei Shtylyov
- fixed cycle_time unitialized variable issue

Changes since v0.1 draft patch version
(https://www.spinics.net/lists/arm-kernel/msg566932.html):
- fixed cycle_time build warning
- added platform support fixes from Sekhar
- added defconfig changes from Sekhar
- preserved platform support for the old IDE driver
- split it on 3 patches

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics


Bartlomiej Zolnierkiewicz (3):
  ata: add Palmchip BK3710 PATA controller driver
  pata_bk3710: disable IORDY Timer on chipset initialization
  pata_bk3710: clear status bits of BMISP on chipset initialization

Sekhar Nori (2):
  ARM: davinci: add pata_bk3710 libata driver support
  ARM: davinci_all_defconfig: convert to use libata PATA

 arch/arm/configs/davinci_all_defconfig    |   4 +-
 arch/arm/mach-davinci/board-dm644x-evm.c  |   3 +-
 arch/arm/mach-davinci/board-dm646x-evm.c  |   3 +-
 arch/arm/mach-davinci/board-neuros-osd2.c |   3 +-
 drivers/ata/Kconfig                       |   9 +
 drivers/ata/Makefile                      |   1 +
 drivers/ata/pata_bk3710.c                 | 382 ++++++++++++++++++++++++++++++
 7 files changed, 399 insertions(+), 6 deletions(-)
 create mode 100644 drivers/ata/pata_bk3710.c

-- 
1.9.1

[toc] | [next] | [standalone]

#1606887 — [PATCH v3 2/5] pata_bk3710: disable IORDY Timer on chipset initialization

Disable IORDY Timer as the driver doesn't handle IORDY Timer
interrupt anyway.

Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/ata/pata_bk3710.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_bk3710.c b/drivers/ata/pata_bk3710.c
index 1a1223f..f22e4bf 100644
--- a/drivers/ata/pata_bk3710.c
+++ b/drivers/ata/pata_bk3710.c
@@ -264,9 +264,9 @@ static void pata_bk3710_chipinit(void __iomem *base)
 
 	/*
 	 * IORDYTMP IORDY Timer for Primary Register
-	 * (ATA_IORDYTMP_IORDYTMP     , 0xffff  )
+	 * (ATA_IORDYTMP_IORDYTMP	, DISABLE)
 	 */
-	iowrite32(0xFFFF, base + BK3710_IORDYTMP);
+	iowrite32(0, base + BK3710_IORDYTMP);
 
 	/*
 	 * Configure BMISP Register
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1607352 — Re: [PATCH v3 2/5] pata_bk3710: disable IORDY Timer on chipset initialization

On 3/22/2017 9:20 PM, Bartlomiej Zolnierkiewicz wrote:

> Disable IORDY Timer as the driver doesn't handle IORDY Timer
> interrupt anyway.
>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

MBR, Sergei

[toc] | [prev] | [next] | [standalone]

#1606890 — [PATCH v3 4/5] ARM: davinci: add pata_bk3710 libata driver support

From: Sekhar Nori <nsekhar@ti.com>

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
[b.zolnierkie: split from bigger patch + preserved old driver support]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 arch/arm/mach-davinci/board-dm644x-evm.c  | 3 ++-
 arch/arm/mach-davinci/board-dm646x-evm.c  | 3 ++-
 arch/arm/mach-davinci/board-neuros-osd2.c | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
index 023480b..20f1874 100644
--- a/arch/arm/mach-davinci/board-dm644x-evm.c
+++ b/arch/arm/mach-davinci/board-dm644x-evm.c
@@ -744,7 +744,8 @@ static int davinci_phy_fixup(struct phy_device *phydev)
 	return 0;
 }
 
-#define HAS_ATA		IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710)
+#define HAS_ATA		(IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) || \
+			 IS_ENABLED(CONFIG_PATA_BK3710))
 
 #define HAS_NOR		IS_ENABLED(CONFIG_MTD_PHYSMAP)
 
diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
index f702d4f..cb17682 100644
--- a/arch/arm/mach-davinci/board-dm646x-evm.c
+++ b/arch/arm/mach-davinci/board-dm646x-evm.c
@@ -119,7 +119,8 @@
 	},
 };
 
-#define HAS_ATA		IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710)
+#define HAS_ATA		(IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) || \
+			 IS_ENABLED(CONFIG_PATA_BK3710))
 
 #ifdef CONFIG_I2C
 /* CPLD Register 0 bits to control ATA */
diff --git a/arch/arm/mach-davinci/board-neuros-osd2.c b/arch/arm/mach-davinci/board-neuros-osd2.c
index 0a78388..0c02aaa 100644
--- a/arch/arm/mach-davinci/board-neuros-osd2.c
+++ b/arch/arm/mach-davinci/board-neuros-osd2.c
@@ -163,7 +163,8 @@ static void __init davinci_ntosd2_map_io(void)
 	.wires		= 4,
 };
 
-#define HAS_ATA		IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710)
+#define HAS_ATA		(IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) || \
+			 IS_ENABLED(CONFIG_PATA_BK3710))
 
 #define HAS_NAND	IS_ENABLED(CONFIG_MTD_NAND_DAVINCI)
 
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1606893 — [PATCH v3 5/5] ARM: davinci_all_defconfig: convert to use libata PATA

From: Sekhar Nori <nsekhar@ti.com>

IDE subsystem has been deprecated since 2009 and the majority
(if not all) of Linux distributions have switched to use
libata for ATA support exclusively.  However there are still
some users (mostly old or/and embedded non-x86 systems) that
have not converted from using IDE subsystem to libata PATA
drivers.  This doesn't seem to be good thing in the long-term
for Linux as while there is less and less PATA systems left
in use:

* testing efforts are divided between two subsystems

* having duplicate drivers for same hardware confuses users

This patch converts davinci_all_defconfig to use libata PATA
drivers.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
[b.zolnierkie: split from bigger patch + added patch description]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 arch/arm/configs/davinci_all_defconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig
index c8663ea..93aab3d 100644
--- a/arch/arm/configs/davinci_all_defconfig
+++ b/arch/arm/configs/davinci_all_defconfig
@@ -74,12 +74,10 @@ CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_COUNT=1
 CONFIG_BLK_DEV_RAM_SIZE=32768
 CONFIG_EEPROM_AT24=y
-CONFIG_IDE=m
-CONFIG_BLK_DEV_PALMCHIP_BK3710=m
-CONFIG_SCSI=m
 CONFIG_BLK_DEV_SD=m
 CONFIG_ATA=m
 CONFIG_AHCI_DA850=m
+CONFIG_PATA_BK3710=m
 CONFIG_NETDEVICES=y
 CONFIG_NETCONSOLE=y
 CONFIG_TUN=m
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1606894 — [PATCH v3 3/5] pata_bk3710: clear status bits of BMISP on chipset initialization

Clear IORDYINT, INTRSTAT and DMAERROR bits of BMISP register
(value '1' needs to be written to the bit to clear it).

Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/ata/pata_bk3710.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_bk3710.c b/drivers/ata/pata_bk3710.c
index f22e4bf..6c3bd5f 100644
--- a/drivers/ata/pata_bk3710.c
+++ b/drivers/ata/pata_bk3710.c
@@ -276,7 +276,7 @@ static void pata_bk3710_chipinit(void __iomem *base)
 	 * (ATA_BMISP_INTRSTAT	, CLEAR)	|
 	 * (ATA_BMISP_DMAERROR	, CLEAR)
 	 */
-	iowrite16(0, base + BK3710_BMISP);
+	iowrite16(0xE, base + BK3710_BMISP);
 
 	pata_bk3710_setpiomode(base, NULL, 0, 600, 0);
 	pata_bk3710_setpiomode(base, NULL, 1, 600, 0);
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1607351 — Re: [PATCH v3 3/5] pata_bk3710: clear status bits of BMISP on chipset initialization

On 3/22/2017 9:21 PM, Bartlomiej Zolnierkiewicz wrote:

> Clear IORDYINT, INTRSTAT and DMAERROR bits of BMISP register
> (value '1' needs to be written to the bit to clear it).
>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
[...]

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

MBR, Sergei

[toc] | [prev] | [next] | [standalone]

#1607511 — Re: [PATCH v3 0/5] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers

On Wednesday 22 March 2017 11:50 PM, Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> This patchset adds Palmchip BK3710 IDE controller driver to
> libata and switches ARM/DaVinci to use it (instead of the old
> IDE driver).
> 
> Sekhar, please check that it still works after changes, thanks.

Did some basic mount/read/write tests, it passed.

Thanks,
Sekhar

[toc] | [prev] | [next] | [standalone]

#1608565 — Re: [PATCH v3 0/5] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers

On Thursday, March 23, 2017 07:27:05 PM Sekhar Nori wrote:
> On Wednesday 22 March 2017 11:50 PM, Bartlomiej Zolnierkiewicz wrote:
> > Hi,
> > 
> > This patchset adds Palmchip BK3710 IDE controller driver to
> > libata and switches ARM/DaVinci to use it (instead of the old
> > IDE driver).
> > 
> > Sekhar, please check that it still works after changes, thanks.
> 
> Did some basic mount/read/write tests, it passed.

Thanks for checking.

I guess that you can merge the patchset now to your tree
(with Tejun's ACK for the whole patches and Sergei's ACK
for ATA changes).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web