Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1607126 > unrolled thread
| Started by | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| First post | 2017-03-23 03:20 +0100 |
| Last post | 2017-03-23 08:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
linux-next: manual merge of the usb tree with the usb-gadget-fixes tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-03-23 03:20 +0100
Re: linux-next: manual merge of the usb tree with the usb-gadget-fixes tree Greg KH <greg@kroah.com> - 2017-03-23 08:50 +0100
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-03-23 03:20 +0100 |
| Subject | linux-next: manual merge of the usb tree with the usb-gadget-fixes tree |
| Message-ID | <to0w1-3Qh-13@gated-at.bofh.it> |
Hi Greg,
Today's linux-next merge of the usb tree got a conflict in:
drivers/usb/gadget/udc/pch_udc.c
between commit:
1f459262b0e1 ("usb: gadget: udc: remove pointer dereference after free")
from the usb-gadget-fixes tree and commit:
d293408ef303 ("usb: gadget: pch_udc: Replace PCI pool old API")
from the usb tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc drivers/usb/gadget/udc/pch_udc.c
index 8a365aad66fe,84dcbcd756f0..000000000000
--- a/drivers/usb/gadget/udc/pch_udc.c
+++ b/drivers/usb/gadget/udc/pch_udc.c
@@@ -1522,7 -1522,8 +1522,7 @@@ static void pch_udc_free_dma_chain(stru
/* do not free first desc., will be done by free for request */
td = phys_to_virt(addr);
addr2 = (dma_addr_t)td->next;
- pci_pool_free(dev->data_requests, td, addr);
+ dma_pool_free(dev->data_requests, td, addr);
- td->next = 0x00;
addr = addr2;
}
req->chain_len = 1;
[toc] | [next] | [standalone]
| From | Greg KH <greg@kroah.com> |
|---|---|
| Date | 2017-03-23 08:50 +0100 |
| Subject | Re: linux-next: manual merge of the usb tree with the usb-gadget-fixes tree |
| Message-ID | <to5Fo-7vn-23@gated-at.bofh.it> |
| In reply to | #1607126 |
On Thu, Mar 23, 2017 at 01:16:33PM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> Today's linux-next merge of the usb tree got a conflict in:
>
> drivers/usb/gadget/udc/pch_udc.c
>
> between commit:
>
> 1f459262b0e1 ("usb: gadget: udc: remove pointer dereference after free")
>
> from the usb-gadget-fixes tree and commit:
>
> d293408ef303 ("usb: gadget: pch_udc: Replace PCI pool old API")
>
> from the usb tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> --
> Cheers,
> Stephen Rothwell
>
> diff --cc drivers/usb/gadget/udc/pch_udc.c
> index 8a365aad66fe,84dcbcd756f0..000000000000
> --- a/drivers/usb/gadget/udc/pch_udc.c
> +++ b/drivers/usb/gadget/udc/pch_udc.c
> @@@ -1522,7 -1522,8 +1522,7 @@@ static void pch_udc_free_dma_chain(stru
> /* do not free first desc., will be done by free for request */
> td = phys_to_virt(addr);
> addr2 = (dma_addr_t)td->next;
> - pci_pool_free(dev->data_requests, td, addr);
> + dma_pool_free(dev->data_requests, td, addr);
> - td->next = 0x00;
> addr = addr2;
> }
> req->chain_len = 1;
Looks good to me, thanks!
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web