Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600048 > unrolled thread

[PATCH net] r8152: fix the list rx_done may be used without initialization

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH net] r8152: fix the list rx_done may be used without initialization Hayes Wang <hayeswang@realtek.com> - 2017-03-14 07:20 +0100
    Re: [PATCH net] r8152: fix the list rx_done may be used without  initialization David Miller <davem@davemloft.net> - 2017-03-21 22:50 +0100

#1600048 — [PATCH net] r8152: fix the list rx_done may be used without initialization

The list rx_done would be initialized when the linking on occurs.
Therefore, if a napi is scheduled without any linking on before,
the following kernel panic would happen.

	BUG: unable to handle kernel NULL pointer dereference at 000000000000008
	IP: [<ffffffffc085efde>] r8152_poll+0xe1e/0x1210 [r8152]
	PGD 0
	Oops: 0002 [#1] SMP

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
 drivers/net/usb/r8152.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 986243c..bb3eedd 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1362,6 +1362,7 @@ static int alloc_all_mem(struct r8152 *tp)
 	spin_lock_init(&tp->rx_lock);
 	spin_lock_init(&tp->tx_lock);
 	INIT_LIST_HEAD(&tp->tx_free);
+	INIT_LIST_HEAD(&tp->rx_done);
 	skb_queue_head_init(&tp->tx_queue);
 	skb_queue_head_init(&tp->rx_queue);
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1606011 — Re: [PATCH net] r8152: fix the list rx_done may be used without initialization

From: Hayes Wang <hayeswang@realtek.com>
Date: Tue, 14 Mar 2017 14:15:20 +0800

> The list rx_done would be initialized when the linking on occurs.
> Therefore, if a napi is scheduled without any linking on before,
> the following kernel panic would happen.
> 
> 	BUG: unable to handle kernel NULL pointer dereference at 000000000000008
> 	IP: [<ffffffffc085efde>] r8152_poll+0xe1e/0x1210 [r8152]
> 	PGD 0
> 	Oops: 0002 [#1] SMP
> 
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web