Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1605628 > unrolled thread

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

Started byJiri Kosina <jikos@kernel.org>
First post2017-03-21 15:10 +0100
Last post2017-03-22 09:30 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB  Touchscreens Jiri Kosina <jikos@kernel.org> - 2017-03-21 15:10 +0100
    Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-21 20:50 +0100
      Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB  Touchscreens Jiri Kosina <jikos@kernel.org> - 2017-03-21 20:50 +0100
        Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB  Touchscreens Jiri Kosina <jikos@kernel.org> - 2017-03-22 09:30 +0100

#1605628 — Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

FromJiri Kosina <jikos@kernel.org>
Date2017-03-21 15:10 +0100
SubjectRe: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens
Message-ID<tnsE2-4nH-13@gated-at.bofh.it>
On Tue, 14 Feb 2017, Martyn Welch wrote:

> The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH
> in it's capabilities, which is what user space expects a touchscreen
> device to report. This is causing udev to consider the device to be a
> "VMware's USB mouse" rather than as a touchscreen, which results in a
> mouse cursor being displayed in Weston.
> 
> This patch adds a special driver for the device to correct the
> capabilities reported.

Applied to for-4.12/accutouch. Thanks,

-- 
Jiri Kosina
SUSE Labs

[toc] | [next] | [standalone]


#1605948 — Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

FromDmitry Torokhov <dmitry.torokhov@gmail.com>
Date2017-03-21 20:50 +0100
SubjectRe: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens
Message-ID<tnxX4-7To-9@gated-at.bofh.it>
In reply to#1605628
On Tue, Mar 21, 2017 at 7:04 AM, Jiri Kosina <jikos@kernel.org> wrote:
>
> On Tue, 14 Feb 2017, Martyn Welch wrote:
>
> > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH
> > in it's capabilities, which is what user space expects a touchscreen
> > device to report. This is causing udev to consider the device to be a
> > "VMware's USB mouse" rather than as a touchscreen, which results in a
> > mouse cursor being displayed in Weston.
> >
> > This patch adds a special driver for the device to correct the
> > capabilities reported.
>
> Applied to for-4.12/accutouch. Thanks,

Hmm, can't we fix usage code from udev, like we do with other keymaps?
Kernel memory is quite precious.

Thanks.

-- 
Dmitry

[toc] | [prev] | [next] | [standalone]


#1605950

FromJiri Kosina <jikos@kernel.org>
Date2017-03-21 20:50 +0100
Message-ID<tnxX4-7To-11@gated-at.bofh.it>
In reply to#1605948
On Tue, 21 Mar 2017, Dmitry Torokhov wrote:

> > > This patch adds a special driver for the device to correct the
> > > capabilities reported.
> >
> > Applied to for-4.12/accutouch. Thanks,
> 
> Hmm, can't we fix usage code from udev, like we do with other keymaps?

Sorry, I messed up. I exchanged this patch with another one that fixed 
report descriptor (which we can't yet, although I have been thinking about 
ways how to do this properly).

Thanks for catching my mistake, Dmitry. Martyn, remapping HID usage codes 
is possible via udev now, as we support setkeycodes in hid-input for quite 
some time. Could you please verify that it works for you?

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]


#1606275

FromJiri Kosina <jikos@kernel.org>
Date2017-03-22 09:30 +0100
Message-ID<tnJOy-7TA-11@gated-at.bofh.it>
In reply to#1605950
On Tue, 21 Mar 2017, Jiri Kosina wrote:

> Sorry, I messed up. I exchanged this patch with another one that fixed 
> report descriptor (which we can't yet, although I have been thinking about 
> ways how to do this properly).

FTR, this is now also dropped from hid.git. Thanks again for catching my 
brainfart, Dmitry.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web