Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604431 > unrolled thread

[PATCH] ARM: sun8i: a33: remove highest OPP to fix CPU crashes

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: sun8i: a33: remove highest OPP to fix CPU crashes Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-03-20 12:50 +0100
    Re: [PATCH] ARM: sun8i: a33: remove highest OPP to fix CPU crashes Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-21 17:10 +0100

#1604431 — [PATCH] ARM: sun8i: a33: remove highest OPP to fix CPU crashes

The highest supported frequency (1.2GHz) requires to "overvolt" the CPU.
However, some boards still do not have the cpu-supply DT property in the
cpu DT node which means that the CPU will always run with the same input
voltage but try to run at 1.2GHz frequency. This is the source of
(experienced) CPU crashes.

Remove the OPP which requires overvolting the CPU until all boards have
a cpu-supply property.

Fixes: 03749eb88e635ad67818827adde8e5eea7b64571 ("ARM: dts: sun8i: add
opp-v2 table for A33")

Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
---
 arch/arm/boot/dts/sun8i-a33.dtsi | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
index 9d82414..463b2b3 100644
--- a/arch/arm/boot/dts/sun8i-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a33.dtsi
@@ -121,12 +121,6 @@
 			opp-microvolt = <1200000>;
 			clock-latency-ns = <244144>; /* 8 32k periods */
 		};
-
-		opp@1200000000 {
-			opp-hz = /bits/ 64 <1200000000>;
-			opp-microvolt = <1320000>;
-			clock-latency-ns = <244144>; /* 8 32k periods */
-		};
 	};
 
 	cpus {
-- 
2.9.3

[toc] | [next] | [standalone]

#1605759

[Multipart message — attachments visible in raw view] — view raw

On Mon, Mar 20, 2017 at 12:25:51PM +0100, Quentin Schulz wrote:
> The highest supported frequency (1.2GHz) requires to "overvolt" the CPU.
> However, some boards still do not have the cpu-supply DT property in the
> cpu DT node which means that the CPU will always run with the same input
> voltage but try to run at 1.2GHz frequency. This is the source of
> (experienced) CPU crashes.
> 
> Remove the OPP which requires overvolting the CPU until all boards have
> a cpu-supply property.
> 
> Fixes: 03749eb88e635ad67818827adde8e5eea7b64571 ("ARM: dts: sun8i: add
> opp-v2 table for A33")

The commit ID must be 12 chars, as documented in
Documentation/process/submitting-patches.rst.

You can also use the pretty format given there to be sure to have it
right.

> 
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web