Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1605796 > unrolled thread

[PATCH v3 01/11] ARM: sun8i: a33: add operating-points-v2 property to all nodes

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v3 01/11] ARM: sun8i: a33: add operating-points-v2 property to all nodes Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-03-21 17:40 +0100
    Re: [PATCH v3 01/11] ARM: sun8i: a33: add operating-points-v2  property to all nodes Chen-Yu Tsai <wens@csie.org> - 2017-03-22 04:40 +0100
      Re: [PATCH v3 01/11] ARM: sun8i: a33: add operating-points-v2  property to all nodes Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-22 09:00 +0100

#1605796 — [PATCH v3 01/11] ARM: sun8i: a33: add operating-points-v2 property to all nodes

The OPP are declared as shared but no operating points are declared for
cpu1, 2 and 3. Thus, the following error happens during the boot:

cpu cpu1: dev_pm_opp_of_get_sharing_cpus: Couldn't find tcpu_dev node.

This patch applies the operating points to each cpu of the A33.

Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
---

added in v2

 arch/arm/boot/dts/sun8i-a33.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
index e1e74b8..39b2d78 100644
--- a/arch/arm/boot/dts/sun8i-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a33.dtsi
@@ -75,16 +75,22 @@
 			operating-points-v2 = <&cpu0_opp_table>;
 		};
 
+		cpu@1 {
+			operating-points-v2 = <&cpu0_opp_table>;
+		};
+
 		cpu@2 {
 			compatible = "arm,cortex-a7";
 			device_type = "cpu";
 			reg = <2>;
+			operating-points-v2 = <&cpu0_opp_table>;
 		};
 
 		cpu@3 {
 			compatible = "arm,cortex-a7";
 			device_type = "cpu";
 			reg = <3>;
+			operating-points-v2 = <&cpu0_opp_table>;
 		};
 	};
 
-- 
2.9.3

[toc] | [next] | [standalone]

#1606188 — Re: [PATCH v3 01/11] ARM: sun8i: a33: add operating-points-v2 property to all nodes

On Tue, Mar 21, 2017 at 11:36 PM, Quentin Schulz
<quentin.schulz@free-electrons.com> wrote:
> The OPP are declared as shared but no operating points are declared for
> cpu1, 2 and 3. Thus, the following error happens during the boot:
>
> cpu cpu1: dev_pm_opp_of_get_sharing_cpus: Couldn't find tcpu_dev node.
>
> This patch applies the operating points to each cpu of the A33.
>

This should have

Fixes: 03749eb88e63 ("ARM: dts: sun8i: add opp-v2 table for A33")

and be merged as fixes for 4.11.

> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

[toc] | [prev] | [next] | [standalone]

#1606266 — Re: [PATCH v3 01/11] ARM: sun8i: a33: add operating-points-v2 property to all nodes

[Multipart message — attachments visible in raw view] — view raw

On Wed, Mar 22, 2017 at 11:32:28AM +0800, Chen-Yu Tsai wrote:
> On Tue, Mar 21, 2017 at 11:36 PM, Quentin Schulz
> <quentin.schulz@free-electrons.com> wrote:
> > The OPP are declared as shared but no operating points are declared for
> > cpu1, 2 and 3. Thus, the following error happens during the boot:
> >
> > cpu cpu1: dev_pm_opp_of_get_sharing_cpus: Couldn't find tcpu_dev node.
> >
> > This patch applies the operating points to each cpu of the A33.
> >
> 
> This should have
> 
> Fixes: 03749eb88e63 ("ARM: dts: sun8i: add opp-v2 table for A33")
> 
> and be merged as fixes for 4.11.
> 
> > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>

I just queued it as a fix for 4.11, with the fixes tag.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web