Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1605308 > unrolled thread

[PATCH 0/2] Hi655x: mfd/pmic: regulator: Correct dependencies

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] Hi655x: mfd/pmic: regulator: Correct dependencies Jeremy Linton <lintonrjeremy@gmail.com> - 2017-03-21 06:00 +0100
    [PATCH 1/2] mfd: hi655x: Reference required regulator driver Jeremy Linton <lintonrjeremy@gmail.com> - 2017-03-21 06:00 +0100
      Re: [PATCH 1/2] mfd: hi655x: Reference required regulator driver Lee Jones <lee.jones@linaro.org> - 2017-03-23 17:40 +0100

#1605308 — [PATCH 0/2] Hi655x: mfd/pmic: regulator: Correct dependencies

In an environment where the hi655x pmic is being built as a 
standalone module, it fails to automatically load resulting
in boot failures, machine hangs, etc. First we correct this
by setting an appropriate module dependency. Then we bump the
module use count on the mfd/pmic driver so that it cannot be
unloaded when in use. Again this avoids machine crashes.

Jeremy Linton (2):
  mfd: hi655x: Reference required regulator driver
  regulator: hi655x: Bump parent pmic module use count

 drivers/mfd/hi655x-pmic.c            |  1 +
 drivers/regulator/hi655x-regulator.c | 26 ++++++++++++++++++++++++--
 2 files changed, 25 insertions(+), 2 deletions(-)

-- 
2.10.2

[toc] | [next] | [standalone]

#1605309 — [PATCH 1/2] mfd: hi655x: Reference required regulator driver

The hisi pmic requires an independent regulator driver to be
loaded so that devices dependent on the pmic/regulator are
started properly. Currently there is only a single compatible
regulator driver in the tree, so reference it with a module soft
dependency so that modprobe loads it whenever the hisi pmic
driver is loaded.

Signed-off-by: Jeremy Linton <lintonrjeremy@gmail.com>
---
 drivers/mfd/hi655x-pmic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
index ba706ad..56e027d 100644
--- a/drivers/mfd/hi655x-pmic.c
+++ b/drivers/mfd/hi655x-pmic.c
@@ -184,3 +184,4 @@ module_platform_driver(hi655x_pmic_driver);
 MODULE_AUTHOR("Chen Feng <puck.chen@hisilicon.com>");
 MODULE_DESCRIPTION("Hisilicon hi655x PMIC driver");
 MODULE_LICENSE("GPL v2");
+MODULE_SOFTDEP("post: hi655x-regulator");
-- 
2.10.2

[toc] | [prev] | [next] | [standalone]

#1607694 — Re: [PATCH 1/2] mfd: hi655x: Reference required regulator driver

On Mon, 20 Mar 2017, Jeremy Linton wrote:

> The hisi pmic requires an independent regulator driver to be
> loaded so that devices dependent on the pmic/regulator are
> started properly. Currently there is only a single compatible
> regulator driver in the tree, so reference it with a module soft
> dependency so that modprobe loads it whenever the hisi pmic
> driver is loaded.

This is a new one on my, but it sounds okay.

OOI, what happens when there are lots of compatible drivers?

> Signed-off-by: Jeremy Linton <lintonrjeremy@gmail.com>
> ---
>  drivers/mfd/hi655x-pmic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> index ba706ad..56e027d 100644
> --- a/drivers/mfd/hi655x-pmic.c
> +++ b/drivers/mfd/hi655x-pmic.c
> @@ -184,3 +184,4 @@ module_platform_driver(hi655x_pmic_driver);
>  MODULE_AUTHOR("Chen Feng <puck.chen@hisilicon.com>");
>  MODULE_DESCRIPTION("Hisilicon hi655x PMIC driver");
>  MODULE_LICENSE("GPL v2");
> +MODULE_SOFTDEP("post: hi655x-regulator");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web