Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1605257 > unrolled thread

[PATCH 4/4 V2] staging: atomisp: remove redudant condition in if-statement

Started byDaeseok Youn <daeseok.youn@gmail.com>
First post2017-03-21 03:20 +0100
Last post2017-03-21 03:20 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH 4/4 V2] staging: atomisp: remove redudant condition in  if-statement Daeseok Youn <daeseok.youn@gmail.com> - 2017-03-21 03:20 +0100

#1605257 — [PATCH 4/4 V2] staging: atomisp: remove redudant condition in if-statement

FromDaeseok Youn <daeseok.youn@gmail.com>
Date2017-03-21 03:20 +0100
Subject[PATCH 4/4 V2] staging: atomisp: remove redudant condition in if-statement
Message-ID<tnhyW-5bM-9@gated-at.bofh.it>
The V4L2_FIELD_ANY is zero, so the (!field) is same meaning
with (field == V4L2_FIELD_ANY) in if-statement.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
V2: one(2/4) of this series was updated so I tried to send them again.

 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
index f7c0705..943a7ae 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
@@ -5084,7 +5084,7 @@ int atomisp_try_fmt(struct video_device *vdev, struct v4l2_format *f,
 
 	depth = get_pixel_depth(pixelformat);
 
-	if (!field || field == V4L2_FIELD_ANY)
+	if (field == V4L2_FIELD_ANY)
 		field = V4L2_FIELD_NONE;
 	else if (field != V4L2_FIELD_NONE) {
 		dev_err(isp->dev, "Wrong output field\n");
-- 
1.9.1

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web