Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1605155 > unrolled thread

Re: [PATCH v4 15/23] dt-bindings: PCI: dra7xx: Add dt bindings to enable unaligned access

Started byRob Herring <robh@kernel.org>
First post2017-03-20 22:50 +0100
Last post2017-03-22 15:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v4 15/23] dt-bindings: PCI: dra7xx: Add dt bindings to  enable unaligned access Rob Herring <robh@kernel.org> - 2017-03-20 22:50 +0100
    Re: [PATCH v4 15/23] dt-bindings: PCI: dra7xx: Add dt bindings to  enable unaligned access Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-22 15:40 +0100

#1605155 — Re: [PATCH v4 15/23] dt-bindings: PCI: dra7xx: Add dt bindings to enable unaligned access

FromRob Herring <robh@kernel.org>
Date2017-03-20 22:50 +0100
SubjectRe: [PATCH v4 15/23] dt-bindings: PCI: dra7xx: Add dt bindings to enable unaligned access
Message-ID<tndlE-2eT-23@gated-at.bofh.it>
On Mon, Mar 13, 2017 at 07:52:51PM +0530, Kishon Vijay Abraham I wrote:
> Update device tree binding documentation of TI's dra7xx PCI
> controller to include property for enabling unaligned mem access.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  Documentation/devicetree/bindings/pci/ti-pci.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt
> index 190828a5f32a..b69dd7dbd29e 100644
> --- a/Documentation/devicetree/bindings/pci/ti-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt
> @@ -39,6 +39,11 @@ DEVICE MODE
>   - interrupts : one interrupt entries must be specified for main interrupt.
>   - num-ib-windows : number of inbound address translation windows
>   - num-ob-windows : number of outbound address translation windows
> + - ti,syscon-unaligned-access: phandle to the syscon dt node. The 1st argument
> +			       should contain the register offset within syscon
> +			       and the 2nd argument should contain the bit field
> +			       for setting the bit to enable unaligned
> +			       access.

This should be setup by the firmware/bootloader or some platform code. 
Why does the PCI host need to configure this?

Rob

[toc] | [next] | [standalone]


#1606586

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-03-22 15:40 +0100
Message-ID<tnPAB-3OD-1@gated-at.bofh.it>
In reply to#1605155
Hi Rob,

On Tuesday 21 March 2017 03:13 AM, Rob Herring wrote:
> On Mon, Mar 13, 2017 at 07:52:51PM +0530, Kishon Vijay Abraham I wrote:
>> Update device tree binding documentation of TI's dra7xx PCI
>> controller to include property for enabling unaligned mem access.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>>  Documentation/devicetree/bindings/pci/ti-pci.txt | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt
>> index 190828a5f32a..b69dd7dbd29e 100644
>> --- a/Documentation/devicetree/bindings/pci/ti-pci.txt
>> +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt
>> @@ -39,6 +39,11 @@ DEVICE MODE
>>   - interrupts : one interrupt entries must be specified for main interrupt.
>>   - num-ib-windows : number of inbound address translation windows
>>   - num-ob-windows : number of outbound address translation windows
>> + - ti,syscon-unaligned-access: phandle to the syscon dt node. The 1st argument
>> +			       should contain the register offset within syscon
>> +			       and the 2nd argument should contain the bit field
>> +			       for setting the bit to enable unaligned
>> +			       access.
> 
> This should be setup by the firmware/bootloader or some platform code. 
> Why does the PCI host need to configure this?

That would create a dependency between the bootloader and kernel which is
usually avoided in platforms like dra7xx.

Thanks
Kishon

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web