Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1605818 > unrolled thread
| Started by | Quentin Schulz <quentin.schulz@free-electrons.com> |
|---|---|
| First post | 2017-03-21 18:00 +0100 |
| Last post | 2017-03-22 08:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3 02/11] ARM: sun8i: a33: add all operating points Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-03-21 18:00 +0100
Re: [PATCH v3 02/11] ARM: sun8i: a33: add all operating points Chen-Yu Tsai <wens@csie.org> - 2017-03-22 04:40 +0100
Re: [PATCH v3 02/11] ARM: sun8i: a33: add all operating points Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-22 08:30 +0100
| From | Quentin Schulz <quentin.schulz@free-electrons.com> |
|---|---|
| Date | 2017-03-21 18:00 +0100 |
| Subject | [PATCH v3 02/11] ARM: sun8i: a33: add all operating points |
| Message-ID | <tnviy-5Yp-21@gated-at.bofh.it> |
This adds almost all operating points allowed for the A33 as defined by
fex files available at:
https://github.com/linux-sunxi/sunxi-boards/tree/master/sys_config/a33
There are more possible frequencies in this patch than there are in the
fex files because the fex files only give an interval of possible
frequencies for a given voltage. All supported frequencies are defined
in the original driver code in Allwinner vendor tree.
There are two missing frequencies though: 1104MHz and 1200MHz which
require the CPU to have 1.32V supplied, which is higher than the default
voltage.
Without all A33 boards defining the CPU regulator, we cannot have these
two frequencies as it would cause the CPU to try to run a higher
frequency without "overvolting" which is very likely to crash the CPU.
Therefore, these two frequencies must be enabled on a per-board basis.
Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
---
v2:
- updated commit log,
- removed 1.1GHz as it requires overvolting the CPU which need the CPU
regulator to be set which is set on a per-board basis,
arch/arm/boot/dts/sun8i-a33.dtsi | 54 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
index 39b2d78..b1cdff66 100644
--- a/arch/arm/boot/dts/sun8i-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a33.dtsi
@@ -49,18 +49,72 @@
compatible = "operating-points-v2";
opp-shared;
+ opp@120000000 {
+ opp-hz = /bits/ 64 <120000000>;
+ opp-microvolt = <1040000>;
+ clock-latency-ns = <244144>; /* 8 32k periods */
+ };
+
+ opp@240000000 {
+ opp-hz = /bits/ 64 <240000000>;
+ opp-microvolt = <1040000>;
+ clock-latency-ns = <244144>; /* 8 32k periods */
+ };
+
+ opp@312000000 {
+ opp-hz = /bits/ 64 <312000000>;
+ opp-microvolt = <1040000>;
+ clock-latency-ns = <244144>; /* 8 32k periods */
+ };
+
+ opp@408000000 {
+ opp-hz = /bits/ 64 <408000000>;
+ opp-microvolt = <1040000>;
+ clock-latency-ns = <244144>; /* 8 32k periods */
+ };
+
+ opp@480000000 {
+ opp-hz = /bits/ 64 <480000000>;
+ opp-microvolt = <1040000>;
+ clock-latency-ns = <244144>; /* 8 32k periods */
+ };
+
+ opp@504000000 {
+ opp-hz = /bits/ 64 <504000000>;
+ opp-microvolt = <1040000>;
+ clock-latency-ns = <244144>; /* 8 32k periods */
+ };
+
+ opp@600000000 {
+ opp-hz = /bits/ 64 <600000000>;
+ opp-microvolt = <1040000>;
+ clock-latency-ns = <244144>; /* 8 32k periods */
+ };
+
opp@648000000 {
opp-hz = /bits/ 64 <648000000>;
opp-microvolt = <1040000>;
clock-latency-ns = <244144>; /* 8 32k periods */
};
+ opp@720000000 {
+ opp-hz = /bits/ 64 <720000000>;
+ opp-microvolt = <1100000>;
+ clock-latency-ns = <244144>; /* 8 32k periods */
+ };
+
opp@816000000 {
opp-hz = /bits/ 64 <816000000>;
opp-microvolt = <1100000>;
clock-latency-ns = <244144>; /* 8 32k periods */
};
+ opp@912000000 {
+ opp-hz = /bits/ 64 <912000000>;
+ opp-microvolt = <1200000>;
+ clock-latency-ns = <244144>; /* 8 32k periods */
+ };
+
opp@1008000000 {
opp-hz = /bits/ 64 <1008000000>;
opp-microvolt = <1200000>;
--
2.9.3
[toc] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-03-22 04:40 +0100 |
| Message-ID | <tnFhT-4AN-1@gated-at.bofh.it> |
| In reply to | #1605818 |
On Tue, Mar 21, 2017 at 11:36 PM, Quentin Schulz <quentin.schulz@free-electrons.com> wrote: > This adds almost all operating points allowed for the A33 as defined by > fex files available at: > https://github.com/linux-sunxi/sunxi-boards/tree/master/sys_config/a33 > > There are more possible frequencies in this patch than there are in the > fex files because the fex files only give an interval of possible > frequencies for a given voltage. All supported frequencies are defined > in the original driver code in Allwinner vendor tree. > > There are two missing frequencies though: 1104MHz and 1200MHz which > require the CPU to have 1.32V supplied, which is higher than the default > voltage. > > Without all A33 boards defining the CPU regulator, we cannot have these > two frequencies as it would cause the CPU to try to run a higher > frequency without "overvolting" which is very likely to crash the CPU. > > Therefore, these two frequencies must be enabled on a per-board basis. > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> Acked-by: Chen-Yu Tsai <wens@csie.org>
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-03-22 08:30 +0100 |
| Message-ID | <tnISt-7c5-9@gated-at.bofh.it> |
| In reply to | #1606187 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Mar 22, 2017 at 11:31:54AM +0800, Chen-Yu Tsai wrote: > On Tue, Mar 21, 2017 at 11:36 PM, Quentin Schulz > <quentin.schulz@free-electrons.com> wrote: > > This adds almost all operating points allowed for the A33 as defined by > > fex files available at: > > https://github.com/linux-sunxi/sunxi-boards/tree/master/sys_config/a33 > > > > There are more possible frequencies in this patch than there are in the > > fex files because the fex files only give an interval of possible > > frequencies for a given voltage. All supported frequencies are defined > > in the original driver code in Allwinner vendor tree. > > > > There are two missing frequencies though: 1104MHz and 1200MHz which > > require the CPU to have 1.32V supplied, which is higher than the default > > voltage. > > > > Without all A33 boards defining the CPU regulator, we cannot have these > > two frequencies as it would cause the CPU to try to run a higher > > frequency without "overvolting" which is very likely to crash the CPU. > > > > Therefore, these two frequencies must be enabled on a per-board basis. > > > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> > > Acked-by: Chen-Yu Tsai <wens@csie.org> Applied, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web