Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1606023 > unrolled thread
| Started by | Jin Qian <jinqian@android.com> |
|---|---|
| First post | 2017-03-21 23:10 +0100 |
| Last post | 2017-03-23 01:40 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] mmc: core: export emmc revision via sysfs Jin Qian <jinqian@android.com> - 2017-03-21 23:10 +0100
Re: [PATCH 1/1] mmc: core: export emmc revision via sysfs Jaehoon Chung <jh80.chung@samsung.com> - 2017-03-21 23:20 +0100
Re: [PATCH 1/1] mmc: core: export emmc revision via sysfs Jin Qian <jinqian@android.com> - 2017-03-23 01:40 +0100
| From | Jin Qian <jinqian@android.com> |
|---|---|
| Date | 2017-03-21 23:10 +0100 |
| Subject | [PATCH 1/1] mmc: core: export emmc revision via sysfs |
| Message-ID | <tnA8y-18H-19@gated-at.bofh.it> |
Extend sysfs to access ext_csd revision information.
Signed-off-by: Jin Qian <jinqian@google.com>
Signed-off-by: Jin Qian <jinqian@android.com>
---
drivers/mmc/core/mmc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 7fd722868875..08c62c9bec48 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -779,6 +779,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
+MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n",
card->ext_csd.device_life_time_est_typ_a,
@@ -836,6 +837,7 @@ static struct attribute *mmc_std_attrs[] = {
&dev_attr_name.attr,
&dev_attr_oemid.attr,
&dev_attr_prv.attr,
+ &dev_attr_rev.attr,
&dev_attr_pre_eol_info.attr,
&dev_attr_life_time.attr,
&dev_attr_serial.attr,
--
2.12.1.500.gab5fba24ee-goog
[toc] | [next] | [standalone]
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Date | 2017-03-21 23:20 +0100 |
| Message-ID | <tnAid-1cd-9@gated-at.bofh.it> |
| In reply to | #1606023 |
Hi,
On 03/22/2017 07:01 AM, Jin Qian wrote:
> Extend sysfs to access ext_csd revision information.
>
> Signed-off-by: Jin Qian <jinqian@google.com>
> Signed-off-by: Jin Qian <jinqian@android.com>
I think you can choose one of them for signed-off tag.
> ---
> drivers/mmc/core/mmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 7fd722868875..08c62c9bec48 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -779,6 +779,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
> MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
> MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
> MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
> +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
I'm not sure but if someone want to know ext_csd revision information, attribute name might be more clearly.
e,g) ext_csd_rev?
It's my preference. :)
Best Regards,
Jaehoon Chung
> MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
> MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n",
> card->ext_csd.device_life_time_est_typ_a,
> @@ -836,6 +837,7 @@ static struct attribute *mmc_std_attrs[] = {
> &dev_attr_name.attr,
> &dev_attr_oemid.attr,
> &dev_attr_prv.attr,
> + &dev_attr_rev.attr,
> &dev_attr_pre_eol_info.attr,
> &dev_attr_life_time.attr,
> &dev_attr_serial.attr,
>
[toc] | [prev] | [next] | [standalone]
| From | Jin Qian <jinqian@android.com> |
|---|---|
| Date | 2017-03-23 01:40 +0100 |
| Message-ID | <tnYXf-2Br-1@gated-at.bofh.it> |
| In reply to | #1606025 |
Removed redundant signoff.
export rev to collect some statistics on how many devices are running
with which mmc revision.
Other attr name seems follow cid.<name> or ext_csd.<name>.
Thanks,
jin
On Tue, Mar 21, 2017 at 3:17 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi,
>
> On 03/22/2017 07:01 AM, Jin Qian wrote:
>> Extend sysfs to access ext_csd revision information.
>>
>> Signed-off-by: Jin Qian <jinqian@google.com>
>> Signed-off-by: Jin Qian <jinqian@android.com>
>
> I think you can choose one of them for signed-off tag.
>
>> ---
>> drivers/mmc/core/mmc.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
>> index 7fd722868875..08c62c9bec48 100644
>> --- a/drivers/mmc/core/mmc.c
>> +++ b/drivers/mmc/core/mmc.c
>> @@ -779,6 +779,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
>> MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
>> MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
>> MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
>> +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
>
> I'm not sure but if someone want to know ext_csd revision information, attribute name might be more clearly.
> e,g) ext_csd_rev?
>
> It's my preference. :)
>
> Best Regards,
> Jaehoon Chung
>
>> MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
>> MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n",
>> card->ext_csd.device_life_time_est_typ_a,
>> @@ -836,6 +837,7 @@ static struct attribute *mmc_std_attrs[] = {
>> &dev_attr_name.attr,
>> &dev_attr_oemid.attr,
>> &dev_attr_prv.attr,
>> + &dev_attr_rev.attr,
>> &dev_attr_pre_eol_info.attr,
>> &dev_attr_life_time.attr,
>> &dev_attr_serial.attr,
>>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web