Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1604424 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-03-20 12:50 +0100 |
| Last post | 2017-03-22 19:20 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes Colin King <colin.king@canonical.com> - 2017-03-20 12:50 +0100
Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes Ido Schimmel <idosch@idosch.org> - 2017-03-20 13:20 +0100
Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes Jiri Pirko <jiri@resnulli.us> - 2017-03-20 13:40 +0100
Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes David Miller <davem@davemloft.net> - 2017-03-22 19:20 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-03-20 12:50 +0100 |
| Subject | [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes |
| Message-ID | <tn3YZ-48j-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are
in the wrong order. Fix this by swapping them.
Detected by CoverityScan, CID#1419705 ("Arguments in wrong order")
Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for TC flower offload statistics")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
index e724c6266247..3e7a0bcbba72 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
@@ -375,7 +375,7 @@ int mlxsw_sp_flower_stats(struct mlxsw_sp_port *mlxsw_sp_port, bool ingress,
if (!rule)
return -EINVAL;
- err = mlxsw_sp_acl_rule_get_stats(mlxsw_sp, rule, &bytes, &packets,
+ err = mlxsw_sp_acl_rule_get_stats(mlxsw_sp, rule, &packets, &bytes,
&lastuse);
if (err)
goto err_rule_get_stats;
--
2.11.0
[toc] | [next] | [standalone]
| From | Ido Schimmel <idosch@idosch.org> |
|---|---|
| Date | 2017-03-20 13:20 +0100 |
| Subject | Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes |
| Message-ID | <tn4s2-4zk-25@gated-at.bofh.it> |
| In reply to | #1604424 |
On Mon, Mar 20, 2017 at 11:37:22AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are
> in the wrong order. Fix this by swapping them.
>
> Detected by CoverityScan, CID#1419705 ("Arguments in wrong order")
>
> Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for TC flower offload statistics")
Only need first 12 characters.
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ido Schimmel <idosch@mellanox.com>
Thanks!
[toc] | [prev] | [next] | [standalone]
| From | Jiri Pirko <jiri@resnulli.us> |
|---|---|
| Date | 2017-03-20 13:40 +0100 |
| Subject | Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes |
| Message-ID | <tn4Lo-4J7-39@gated-at.bofh.it> |
| In reply to | #1604424 |
Mon, Mar 20, 2017 at 12:37:22PM CET, colin.king@canonical.com wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are
>in the wrong order. Fix this by swapping them.
>
>Detected by CoverityScan, CID#1419705 ("Arguments in wrong order")
>
>Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for TC flower offload statistics")
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-03-22 19:20 +0100 |
| Subject | Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes |
| Message-ID | <tnT1w-6Ex-15@gated-at.bofh.it> |
| In reply to | #1604424 |
From: Colin King <colin.king@canonical.com>
Date: Mon, 20 Mar 2017 11:37:22 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are
> in the wrong order. Fix this by swapping them.
>
> Detected by CoverityScan, CID#1419705 ("Arguments in wrong order")
>
> Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for TC flower offload statistics")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web