Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1604221 > unrolled thread
| Started by | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| First post | 2017-03-20 08:50 +0100 |
| Last post | 2017-03-20 08:50 +0100 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/2] ARM: dts: sun4i: Add CAN node and can0_pins_a pinctrl settings Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-20 08:50 +0100
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-03-20 08:50 +0100 |
| Subject | Re: [PATCH 1/2] ARM: dts: sun4i: Add CAN node and can0_pins_a pinctrl settings |
| Message-ID | <tn0eJ-1w7-7@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi Patrick,
On Sun, Mar 12, 2017 at 02:28:10PM +0100, Patrick Menschel wrote:
> The A10 SoC has an on-board CAN controller. This patch adds the device node
> and the corresponding pinctrl settings for pins PH20 and PH21.
>
> This patch is adapted from the description in
> Documentation/devicetree/bindings/net/can/sun4i_can.txt
>
> Signed-off-by: Patrick Menschel <menschel.p@posteo.de>
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index b14a428..210b616 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -1160,6 +1160,13 @@
> allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> };
> +
> + can0_pins_a: can0@0 {
That should be ordered by alphabetical order.
> + allwinner,pins = "PH20","PH21";
> + allwinner,function = "can";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
We've switched to a new, generic, binding recently for the pinctrl
nodes.
In your case, that would mean dropping "allwinner," from the pins and
functions properties, and droping the last two properties entirely.
> + };
> };
>
> timer@01c20c00 {
> @@ -1376,5 +1383,13 @@
> clocks = <&apb1_gates 7>;
> status = "disabled";
> };
> +
> + can0: can@01c2bc00 {
And this one should be ordered by rising physical addresses.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Back to top | Article view | linux.kernel
csiph-web