Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1604194 > unrolled thread
| Started by | Jacob Zachariah <jacob.zac316@gmail.com> |
|---|---|
| First post | 2017-03-20 07:20 +0100 |
| Last post | 2017-03-20 12:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: wilc1000: Fix sparse warning in wilc_wfi_cfgoperations.c Jacob Zachariah <jacob.zac316@gmail.com> - 2017-03-20 07:20 +0100
Re: [PATCH] staging: wilc1000: Fix sparse warning in wilc_wfi_cfgoperations.c Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-20 12:50 +0100
| From | Jacob Zachariah <jacob.zac316@gmail.com> |
|---|---|
| Date | 2017-03-20 07:20 +0100 |
| Subject | [PATCH] staging: wilc1000: Fix sparse warning in wilc_wfi_cfgoperations.c |
| Message-ID | <tmYPE-Db-19@gated-at.bofh.it> |
Fix the following warning reported by sparse:
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect type in assignment (different base types)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: expected unsigned short [unsigned] [assigned] [usertype] ht_capa_info
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: got restricted __le16 const [usertype] cap_info
Signed-off-by: Jacob Zachariah <jacob.zac316@gmail.com>
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index a37896f..bacd366 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -2003,7 +2003,7 @@ static int add_station(struct wiphy *wiphy, struct net_device *dev,
strStaParams.ht_supported = false;
} else {
strStaParams.ht_supported = true;
- strStaParams.ht_capa_info = params->ht_capa->cap_info;
+ strStaParams.ht_capa_info = le16_to_cpu(params->ht_capa->cap_info);
strStaParams.ht_ampdu_params = params->ht_capa->ampdu_params_info;
memcpy(strStaParams.ht_supp_mcs_set,
¶ms->ht_capa->mcs,
--
1.9.1
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-03-20 12:50 +0100 |
| Subject | Re: [PATCH] staging: wilc1000: Fix sparse warning in wilc_wfi_cfgoperations.c |
| Message-ID | <tn3Z0-48j-9@gated-at.bofh.it> |
| In reply to | #1604194 |
On Sun, Mar 19, 2017 at 11:17:08PM -0700, Jacob Zachariah wrote: > Fix the following warning reported by sparse: > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect type in assignment (different base types) > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: expected unsigned short [unsigned] [assigned] [usertype] ht_capa_info > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: got restricted __le16 const [usertype] cap_info > This is probably correct but there is another just a few lines down. Fix that as well. regards, dan carpenter
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web