Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1603984 > unrolled thread

[PATCH v2 0/2] staging:speakup: Multiple checkpatch issues,

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-19 15:10 +0100
    [PATCH v2 1/2] staging: speakup: Moved OR operator to previous line. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-19 16:00 +0100
    Re: [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Greg KH <gregkh@linuxfoundation.org> - 2017-03-21 07:20 +0100
      Re: [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Greg KH <gregkh@linuxfoundation.org> - 2017-03-21 08:00 +0100

#1603984 — [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues,

Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.

Arushi Singhal (2):
  staging: speakup: Moved OR operator to previous line.
  staging: speakup: spaces preferred around operator

 drivers/staging/speakup/main.c           |  8 ++++----
 drivers/staging/speakup/speakup.h        | 12 ++++++------
 drivers/staging/speakup/speakup_acntpc.c |  2 +-
 drivers/staging/speakup/speakup_decpc.c  | 20 ++++++++++----------
 drivers/staging/speakup/speakup_dtlk.c   |  2 +-
 drivers/staging/speakup/speakup_keypc.c  |  6 +++---
 drivers/staging/speakup/speakup_ltlk.c   |  2 +-
 7 files changed, 26 insertions(+), 26 deletions(-)

-- 
changes in v2
 - correct the commit message of [PATCH 1/2]
2.11.0

[toc] | [next] | [standalone]

#1603994 — [PATCH v2 1/2] staging: speakup: Moved OR operator to previous line.

Moved logical OR operator to previous line to fix the following
checkpatch issue:

CHECK: Logical continuations should be on the previous line.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
  -change the commit message and subject.

 drivers/staging/speakup/main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index c10445624e92..def1a36da9dd 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -2173,10 +2173,10 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym,
 	if (up_flag || spk_killed || type == KT_SHIFT)
 		goto out;
 	spk_shut_up &= 0xfe;
-	kh = (value == KVAL(K_DOWN))
-	    || (value == KVAL(K_UP))
-	    || (value == KVAL(K_LEFT))
-	    || (value == KVAL(K_RIGHT));
+	kh = (value == KVAL(K_DOWN)) ||
+	    (value == KVAL(K_UP)) ||
+	    (value == KVAL(K_LEFT)) ||
+	    (value == KVAL(K_RIGHT));
 	if ((cursor_track != read_all_mode) || !kh)
 		if (!spk_no_intr)
 			spk_do_flush();
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1605331

On Sun, Mar 19, 2017 at 06:44:53PM +0530, Arushi Singhal wrote:
> Improve readability by fixing multiple checkpatch.pl
> issues in speakup driver.
> 
> Arushi Singhal (2):
>   staging: speakup: Moved OR operator to previous line.
>   staging: speakup: spaces preferred around operator

You have sent many different speakup patches, in different series, and
then a bunch of individual patches all at once.  I have no idea what to
apply here, what order they go in, or even which ones should be
reviewed.

So I've dropped all of them from my patch queue.  Please resend all of
your outstanding speakup patches, in a _single_ patch series, so that
they can be reviewed in the correct order.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1605351

On Tue, Mar 21, 2017 at 12:03:50PM +0530, Arushi Singhal wrote:
> 
> 
> On Tue, Mar 21, 2017 at 11:41 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
>     On Sun, Mar 19, 2017 at 06:44:53PM +0530, Arushi Singhal wrote:
>     > Improve readability by fixing multiple checkpatch.pl
>     > issues in speakup driver.
>     >
>     > Arushi Singhal (2):
>     >   staging: speakup: Moved OR operator to previous line.
>     >   staging: speakup: spaces preferred around operator
> 
>     You have sent many different speakup patches, in different series, and
>     then a bunch of individual patches all at once.  I have no idea what to
>     apply here, what order they go in, or even which ones should be
>     reviewed.
> 
>     So I've dropped all of them from my patch queue.  Please resend all of
>     your outstanding speakup patches, in a _single_ patch series, so that
>     they can be reviewed in the correct order.
> 
> 
> Hi Greg
> I will resend them all in a single patch series.
> I just want to confirm that  whether you have droped all my patches or only
> speakup driver patches.

At this point in time, only the speakup patches.  I only see one other
pending patch from you, for the sm750fb driver, in my queue.

And don't worry about confirming or not, just resend, given the huge
numbers of patches sent for kernel development normally, there's no way
I can track what an individual does or has outstanding or has been
dropped, it's impossible.  That's up to you to manage, not me :)

Remember, I get an average of 1000 emails a day that I need to do
something with, not including mailing lists I'm subscribed to...

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web