Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1603559 > unrolled thread
| Started by | <Alexander.Steffen@infineon.com> |
|---|---|
| First post | 2017-03-17 20:00 +0100 |
| Last post | 2017-03-17 21:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
RE: [tpmdd-devel] [PATCH v3 4/7] tpm: infrastructure for TPM spaces <Alexander.Steffen@infineon.com> - 2017-03-17 20:00 +0100
Re: [tpmdd-devel] [PATCH v3 4/7] tpm: infrastructure for TPM spaces Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-17 21:50 +0100
| From | <Alexander.Steffen@infineon.com> |
|---|---|
| Date | 2017-03-17 20:00 +0100 |
| Subject | RE: [tpmdd-devel] [PATCH v3 4/7] tpm: infrastructure for TPM spaces |
| Message-ID | <tm5gu-2nQ-39@gated-at.bofh.it> |
> diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm- > interface.c > index 20b1fe3..db5ffe9 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -376,11 +376,12 @@ static bool tpm_validate_command(struct > tpm_chip *chip, const u8 *cmd, > * 0 when the operation is successful. > * A negative number for system errors (errno). > */ > -ssize_t tpm_transmit(struct tpm_chip *chip, const u8 *buf, size_t bufsiz, > - unsigned int flags) > +ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space, > + u8 *buf, size_t bufsiz, unsigned int flags) When adding parameters, please also update the parameter documentation at the top of the function. It is missing for the new parameter "space" here. Alexander
[toc] | [next] | [standalone]
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2017-03-17 21:50 +0100 |
| Message-ID | <tm6YV-3Hs-11@gated-at.bofh.it> |
| In reply to | #1603559 |
On Fri, Mar 17, 2017 at 03:41:38PM +0000, Alexander.Steffen@infineon.com wrote: > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm- > > interface.c > > index 20b1fe3..db5ffe9 100644 > > --- a/drivers/char/tpm/tpm-interface.c > > +++ b/drivers/char/tpm/tpm-interface.c > > @@ -376,11 +376,12 @@ static bool tpm_validate_command(struct > > tpm_chip *chip, const u8 *cmd, > > * 0 when the operation is successful. > > * A negative number for system errors (errno). > > */ > > -ssize_t tpm_transmit(struct tpm_chip *chip, const u8 *buf, size_t bufsiz, > > - unsigned int flags) > > +ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space, > > + u8 *buf, size_t bufsiz, unsigned int flags) > > When adding parameters, please also update the parameter documentation > at the top of the function. It is missing for the new parameter > "space" here. I missed that. I'll update the commits with the proper documentation. > Alexander /Jarkko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web