Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1601091 > unrolled thread
| Started by | Pushkar Jambhlekar <pushkar.iit@gmail.com> |
|---|---|
| First post | 2017-03-15 07:40 +0100 |
| Last post | 2017-03-21 08:40 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] vc04_services: Fixing coding guideline error Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-15 07:40 +0100
Re: [PATCH] vc04_services: Fixing coding guideline error Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-16 06:40 +0100
Re: [PATCH] vc04_services: Fixing coding guideline error Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-16 07:40 +0100
Re: [PATCH] vc04_services: Fixing coding guideline error Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-16 12:50 +0100
Re: [PATCH] vc04_services: Fixing coding guideline error Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-21 08:40 +0100
| From | Pushkar Jambhlekar <pushkar.iit@gmail.com> |
|---|---|
| Date | 2017-03-15 07:40 +0100 |
| Subject | [PATCH] vc04_services: Fixing coding guideline error |
| Message-ID | <tlaLg-3Ki-19@gated-at.bofh.it> |
Fixing 'if' block coding style. '{' should follow 'if' for multiline block
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
index 48984ab..ca896a5 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
@@ -797,8 +797,7 @@ int32_t vchi_get_peer_version(const VCHI_SERVICE_HANDLE_T handle, short *peer_ve
{
int32_t ret = -1;
SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
- if (service)
- {
+ if (service) {
VCHIQ_STATUS_T status;
status = vchiq_get_peer_version(service->handle, peer_version);
--
2.7.4
[toc] | [next] | [standalone]
| From | Pushkar Jambhlekar <pushkar.iit@gmail.com> |
|---|---|
| Date | 2017-03-16 06:40 +0100 |
| Message-ID | <tlwiJ-223-7@gated-at.bofh.it> |
| In reply to | #1601091 |
Any comment?
On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar
<pushkar.iit@gmail.com> wrote:
> Fixing 'if' block coding style. '{' should follow 'if' for multiline block
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> index 48984ab..ca896a5 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> @@ -797,8 +797,7 @@ int32_t vchi_get_peer_version(const VCHI_SERVICE_HANDLE_T handle, short *peer_ve
> {
> int32_t ret = -1;
> SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
> - if (service)
> - {
> + if (service) {
> VCHIQ_STATUS_T status;
>
> status = vchiq_get_peer_version(service->handle, peer_version);
> --
> 2.7.4
>
--
Jambhlekar Pushkar Arun
M.Tech IIT Roorkee
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-03-16 07:40 +0100 |
| Message-ID | <tlxeO-2IL-11@gated-at.bofh.it> |
| In reply to | #1601937 |
On Thu, Mar 16, 2017 at 11:01:38AM +0530, Pushkar Jambhlekar wrote: > Any comment? > > On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar One day's response? Hah, give me a few weeks at best for trivial stuff like this please. Actually, I totally missed this in my last sweep of staging patches, because you forgot to include "Staging" in the subject line, so it will have to wait a few more days at the earliest. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-03-16 12:50 +0100 |
| Message-ID | <tlC4O-684-11@gated-at.bofh.it> |
| In reply to | #1601937 |
On Thu, Mar 16, 2017 at 11:01:38AM +0530, Pushkar Jambhlekar wrote: > Any comment? > You're too impatient. Wait for 2 weeks before asking for responses. regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-03-21 08:40 +0100 |
| Message-ID | <tnmyB-8M-3@gated-at.bofh.it> |
| In reply to | #1601091 |
On Wed, Mar 15, 2017 at 12:01:08PM +0530, Pushkar Jambhlekar wrote:
> Fixing 'if' block coding style. '{' should follow 'if' for multiline block
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch does not apply to my tree at all, please rebase and refresh and
resend.
thanks,
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web