Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602006 > unrolled thread

[PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

Started byJagan Teki <jagan@openedev.com>
First post2017-03-16 08:10 +0100
Last post2017-03-20 08:50 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding Jagan Teki <jagan@openedev.com> - 2017-03-16 08:10 +0100
    [PATCH v6 6/8] ARM: dts: imx6q-icore: Add touchscreen node Jagan Teki <jagan@openedev.com> - 2017-03-16 08:10 +0100
    Re: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts  binding Shawn Guo <shawnguo@kernel.org> - 2017-03-20 03:40 +0100
      Re: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding Jagan Teki <jagan@amarulasolutions.com> - 2017-03-20 07:40 +0100
        Re: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts  binding Shawn Guo <shawnguo@kernel.org> - 2017-03-20 08:50 +0100

#1602006 — [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

FromJagan Teki <jagan@openedev.com>
Date2017-03-16 08:10 +0100
Subject[PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding
Message-ID<tlxHP-3aK-1@gated-at.bofh.it>
From: Jagan Teki <jagan@amarulasolutions.com>

Add missing documentation of max11801-ts dt-binding details.

Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v6:
- Replace the lable and name of the node
   ts: max11801 => max11801: touchscreen@48
Changes for v5:
- Newly added patch

 .../bindings/input/touchscreen/max11801-ts.txt         | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt

diff --git a/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
new file mode 100644
index 0000000..4afccbe
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
@@ -0,0 +1,18 @@
+* MAXI MAX11801 Resistive touch screen controller with i2c interface
+
+Required properties:
+- compatible: must be "max11801"
+- reg: i2c slave address
+- interrupt-parent: the phandle for the interrupt controller
+- interrupts: touch controller interrupt
+
+Example:
+
+&i2c1 {
+	max11801: touchscreen@48 {
+		compatible = "max11801";
+		reg = <0x48>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <31 2>;
+	};
+};
-- 
1.9.1

[toc] | [next] | [standalone]

#1602009 — [PATCH v6 6/8] ARM: dts: imx6q-icore: Add touchscreen node

FromJagan Teki <jagan@openedev.com>
Date2017-03-16 08:10 +0100
Subject[PATCH v6 6/8] ARM: dts: imx6q-icore: Add touchscreen node
Message-ID<tlxHP-3aK-7@gated-at.bofh.it>
In reply to#1602006
From: Jagan Teki <jagan@amarulasolutions.com>

max11801 touchscreen on Engicam iCoreM6 Quad module is
connected via i2c1, so add tc: max11801@48 on i2c1.

Cc: Domenico Acri <domenico.acri@engicam.com>
Cc: Matteo Lisi <matteo.lisi@engicam.com>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v6:
- Replace the lable and name of the node
   ts: max11801 => max11801: touchscreen@48
Changes for v5:
- %s/arm/ARM/g with subject prefix
Changes for v4:
- Newly added patch

 arch/arm/boot/dts/imx6q-icore.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-icore.dts b/arch/arm/boot/dts/imx6q-icore.dts
index 73f34d1..8c1a572 100644
--- a/arch/arm/boot/dts/imx6q-icore.dts
+++ b/arch/arm/boot/dts/imx6q-icore.dts
@@ -58,6 +58,15 @@
 	status = "okay";
 };
 
+&i2c1 {
+	max11801: touchscreen@48 {
+		compatible = "max11801";
+		reg = <0x48>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <31 2>;
+	};
+};
+
 &ldb {
 	status = "okay";
 
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1604148 — Re: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

FromShawn Guo <shawnguo@kernel.org>
Date2017-03-20 03:40 +0100
SubjectRe: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding
Message-ID<tmVoK-6sy-5@gated-at.bofh.it>
In reply to#1602006
On Thu, Mar 16, 2017 at 12:35:38PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
> 
> Add missing documentation of max11801-ts dt-binding details.
> 
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v6:
> - Replace the lable and name of the node
>    ts: max11801 => max11801: touchscreen@48
> Changes for v5:
> - Newly added patch
> 
>  .../bindings/input/touchscreen/max11801-ts.txt         | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
> new file mode 100644
> index 0000000..4afccbe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
> @@ -0,0 +1,18 @@
> +* MAXI MAX11801 Resistive touch screen controller with i2c interface
> +
> +Required properties:
> +- compatible: must be "max11801"

Shouldn't it have a vendor prefix?

Also I will need Rob's ACK to get this go via IMX tree.

Shawn

> +- reg: i2c slave address
> +- interrupt-parent: the phandle for the interrupt controller
> +- interrupts: touch controller interrupt
> +
> +Example:
> +
> +&i2c1 {
> +	max11801: touchscreen@48 {
> +		compatible = "max11801";
> +		reg = <0x48>;
> +		interrupt-parent = <&gpio3>;
> +		interrupts = <31 2>;
> +	};
> +};
> -- 
> 1.9.1
>

[toc] | [prev] | [next] | [standalone]

#1604197

FromJagan Teki <jagan@amarulasolutions.com>
Date2017-03-20 07:40 +0100
Message-ID<tmZ8Z-Md-1@gated-at.bofh.it>
In reply to#1604148
On Mon, Mar 20, 2017 at 8:06 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Thu, Mar 16, 2017 at 12:35:38PM +0530, Jagan Teki wrote:
>> From: Jagan Teki <jagan@amarulasolutions.com>
>>
>> Add missing documentation of max11801-ts dt-binding details.
>>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Michael Trimarchi <michael@amarulasolutions.com>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>> Changes for v6:
>> - Replace the lable and name of the node
>>    ts: max11801 => max11801: touchscreen@48
>> Changes for v5:
>> - Newly added patch
>>
>>  .../bindings/input/touchscreen/max11801-ts.txt         | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
>>
>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
>> new file mode 100644
>> index 0000000..4afccbe
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
>> @@ -0,0 +1,18 @@
>> +* MAXI MAX11801 Resistive touch screen controller with i2c interface
>> +
>> +Required properties:
>> +- compatible: must be "max11801"
>
> Shouldn't it have a vendor prefix?

Drivers i2c_device_id.name doesn't have vendor prefix, should I fix
that one as well?

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[toc] | [prev] | [next] | [standalone]

#1604219 — Re: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

FromShawn Guo <shawnguo@kernel.org>
Date2017-03-20 08:50 +0100
SubjectRe: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding
Message-ID<tn0eJ-1w7-3@gated-at.bofh.it>
In reply to#1604197
On Mon, Mar 20, 2017 at 11:55:27AM +0530, Jagan Teki wrote:
> >> @@ -0,0 +1,18 @@
> >> +* MAXI MAX11801 Resistive touch screen controller with i2c interface
> >> +
> >> +Required properties:
> >> +- compatible: must be "max11801"
> >
> > Shouldn't it have a vendor prefix?
> 
> Drivers i2c_device_id.name doesn't have vendor prefix, should I fix
> that one as well?

No.  The vendor prefix is only needed for device tree compatible.

Shawn

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web