Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600988 > unrolled thread
| Started by | Andi Kleen <andi@firstfloor.org> |
|---|---|
| First post | 2017-03-15 03:20 +0100 |
| Last post | 2017-03-15 13:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 6/7] megasas: Remove expensive inline from megasas_return_cmd Andi Kleen <andi@firstfloor.org> - 2017-03-15 03:20 +0100
RE: [PATCH 6/7] megasas: Remove expensive inline from megasas_return_cmd Sumit Saxena <sumit.saxena@broadcom.com> - 2017-03-15 13:20 +0100
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Date | 2017-03-15 03:20 +0100 |
| Subject | [PATCH 6/7] megasas: Remove expensive inline from megasas_return_cmd |
| Message-ID | <tl6HD-OK-1@gated-at.bofh.it> |
From: Andi Kleen <ak@linux.intel.com>
Remove an inline from a fairly big function that is used often.
It's unlikely that calling or not calling it makes a lot of difference.
Saves around 8k text in my kernel.
text data bss dec hex filename
9047801 5367568 11116544 25531913 1859609 vmlinux-before-megasas
9039417 5367568 11116544 25523529 1857549 vmlinux-megasas
Cc: megaraidlinux.pdl@broadcom.com
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 7ac9a9ee9bd4..55b71de3fb1f 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -244,7 +244,7 @@ struct megasas_cmd *megasas_get_cmd(struct megasas_instance
* @instance: Adapter soft state
* @cmd: Command packet to be returned to free command pool
*/
-inline void
+void
megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd)
{
unsigned long flags;
--
2.9.3
[toc] | [next] | [standalone]
| From | Sumit Saxena <sumit.saxena@broadcom.com> |
|---|---|
| Date | 2017-03-15 13:20 +0100 |
| Message-ID | <tlg4i-7uK-15@gated-at.bofh.it> |
| In reply to | #1600988 |
>-----Original Message-----
>From: megaraidlinux.pdl@broadcom.com
>[mailto:megaraidlinux.pdl@broadcom.com] On Behalf Of Andi Kleen
>Sent: Wednesday, March 15, 2017 7:45 AM
>To: akpm@linux-foundation.org
>Cc: linux-kernel@vger.kernel.org; Andi Kleen;
>megaraidlinux.pdl@broadcom.com
>Subject: [PATCH 6/7] megasas: Remove expensive inline from
>megasas_return_cmd
>
>From: Andi Kleen <ak@linux.intel.com>
>
>Remove an inline from a fairly big function that is used often.
>It's unlikely that calling or not calling it makes a lot of difference.
>
>Saves around 8k text in my kernel.
>
> text data bss dec hex filename
>9047801 5367568 11116544 25531913 1859609
>vmlinux-before-megasas
>9039417 5367568 11116544 25523529 1857549 vmlinux-megasas
>
>Cc: megaraidlinux.pdl@broadcom.com
>Signed-off-by: Andi Kleen <ak@linux.intel.com>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 7ac9a9ee9bd4..55b71de3fb1f 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -244,7 +244,7 @@ struct megasas_cmd *megasas_get_cmd(struct
>megasas_instance
> * @instance: Adapter soft state
> * @cmd: Command packet to be returned to free command pool
> */
>-inline void
>+void
> megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd
>*cmd) {
> unsigned long flags;
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
>--
>2.9.3
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web