Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602870 > unrolled thread

[PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit

Back to article view | Back to linux.kernel

Contents

  [PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit Matthias Kaehlcke <mka@chromium.org> - 2017-03-16 23:10 +0100
    Re: [alsa-devel] [PATCH] ALSA: hda/ca0132: Limit values for chip       addresses to 32-bit Takashi Iwai <tiwai@suse.de> - 2017-03-20 10:40 +0100

#1602870 — [PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit

With the previous unsigned long value clang generates warnings like
this:

sound/pci/hda/patch_ca0132.c:860:37: error: implicit conversion from
  'unsigned long' to 'u32' (aka 'unsigned int') changes value from
  18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
        spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
                             ~             ^~~~

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 sound/pci/hda/patch_ca0132.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 11b9b2f17a2e..7175e2b46fc4 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -857,7 +857,7 @@ static int chipio_write_address(struct hda_codec *codec,
 				  chip_addx >> 16);
 	}
 
-	spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
+	spec->curr_chip_addx = (res < 0) ? (u32)~0U : chip_addx;
 
 	return res;
 }
@@ -882,7 +882,7 @@ static int chipio_write_data(struct hda_codec *codec, unsigned int data)
 	/*If no error encountered, automatically increment the address
 	as per chip behaviour*/
 	spec->curr_chip_addx = (res != -EIO) ?
-					(spec->curr_chip_addx + 4) : ~0UL;
+					(spec->curr_chip_addx + 4) : (u32)~0U;
 	return res;
 }
 
@@ -933,7 +933,7 @@ static int chipio_read_data(struct hda_codec *codec, unsigned int *data)
 	/*If no error encountered, automatically increment the address
 	as per chip behaviour*/
 	spec->curr_chip_addx = (res != -EIO) ?
-					(spec->curr_chip_addx + 4) : ~0UL;
+					(spec->curr_chip_addx + 4) : (u32)~0U;
 	return res;
 }
 
-- 
2.12.0.367.g23dc2f6d3c-goog

[toc] | [next] | [standalone]

#1604277 — Re: [alsa-devel] [PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit

On Thu, 16 Mar 2017 21:52:23 +0100,
Matthias Kaehlcke wrote:
> 
> With the previous unsigned long value clang generates warnings like
> this:
> 
> sound/pci/hda/patch_ca0132.c:860:37: error: implicit conversion from
>   'unsigned long' to 'u32' (aka 'unsigned int') changes value from
>   18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
>         spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
>                              ~             ^~~~
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>

Thanks for the patch.  The changes look mostly OK, but...

> ---
>  sound/pci/hda/patch_ca0132.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index 11b9b2f17a2e..7175e2b46fc4 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -857,7 +857,7 @@ static int chipio_write_address(struct hda_codec *codec,
>  				  chip_addx >> 16);
>  	}
>  
> -	spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
> +	spec->curr_chip_addx = (res < 0) ? (u32)~0U : chip_addx;

... I guess the cast to u32 is superfluous here?  That is, just
replace UL to U should work, I suppose.  (Ditto for all other places.)


Takashi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web