Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1600592 > unrolled thread

[PATCH 0/4] misc: Add OF device table to I2C drivers that are missing it

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2017-03-14 16:30 +0100
Last post2017-03-20 17:50 +0100
Articles 4 on this page of 24 — 4 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/4] misc: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-14 16:30 +0100
    [PATCH 1/4] misc: tsl2550: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-14 16:30 +0100
      Re: [PATCH 1/4] misc: tsl2550: Add OF device ID table Arnd Bergmann <arnd@arndb.de> - 2017-03-14 22:00 +0100
    [PATCH 3/4] eeprom: idt_89hpesx: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-14 16:30 +0100
    [PATCH 2/4] misc: ds1682: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-14 16:30 +0100
      Re: [PATCH 2/4] misc: ds1682: Add OF device ID table Arnd Bergmann <arnd@arndb.de> - 2017-03-14 21:50 +0100
        Re: [PATCH 2/4] misc: ds1682: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-15 01:40 +0100
          Re: [PATCH 2/4] misc: ds1682: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-15 04:30 +0100
    [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-14 16:30 +0100
      Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-15 00:10 +0100
        Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-15 01:20 +0100
          Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-03-15 09:00 +0100
            Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-15 12:10 +0100
              Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-15 12:30 +0100
                Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-15 12:50 +0100
                  Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-15 23:50 +0100
                    Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-16 13:30 +0100
              Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-03-16 14:10 +0100
                Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-16 14:20 +0100
                  Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-03-16 14:40 +0100
                    Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-16 15:10 +0100
                      Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-03-16 16:10 +0100
                        Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-16 16:40 +0100
                          Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-20 17:50 +0100

Page 2 of 2 — ← Prev page 1 [2]


#1602310 — Re: [PATCH 4/4] eeprom: at24: Add OF device ID table

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2017-03-16 15:10 +0100
SubjectRe: [PATCH 4/4] eeprom: at24: Add OF device ID table
Message-ID<tlEgi-7RT-33@gated-at.bofh.it>
In reply to#1602277
Hello Wolfram,

On 03/16/2017 10:36 AM, Wolfram Sang wrote:
> 
>> Sorry, for not explaining myself correctly. I meant to ask who can do what you
>> suggested before. I'm certainly not familiar with this driver to identify what
>> is the minimum set of compatible strings that can be used as generic fallback.
> 
> Well, I am the maintainer of this driver :) But we should definately get

Oh right, silly me :)

> Rob into the boat if he is OK with updating all DTS files having such an
> EEPROM.
>

Agreed, are you going to take care of that? To be honest I think I'll just give
up on this task, it has been a big time sink and I had to explain over and over
to different people what the problem is with the I2C modalias uevent reporting.

I've posted patches for all the drivers that could be affected when reporting a
proper OF modalias by the core and also the RFC patch to properly report it [0].

But it seems that for many maintainers this is just an unnecessary churn and they
don't think there's an issue with the current behaviour. So it feels I'm causing
more harm than good by keep pushing this.

[0]: https://lkml.org/lkml/2015/7/30/494

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]


#1602488 — Re: [PATCH 4/4] eeprom: at24: Add OF device ID table

FromWolfram Sang <wsa@the-dreams.de>
Date2017-03-16 16:10 +0100
SubjectRe: [PATCH 4/4] eeprom: at24: Add OF device ID table
Message-ID<tlFco-97-75@gated-at.bofh.it>
In reply to#1602310

[Multipart message — attachments visible in raw view] — view raw

> > Rob into the boat if he is OK with updating all DTS files having such an
> > EEPROM.
> >
> 
> Agreed, are you going to take care of that?

Nope, sorry, no bandwidth. You might ask Lee, he was very interested in
getting proper I2C OF support upstream.

> up on this task, it has been a big time sink and I had to explain over and over
> to different people what the problem is with the I2C modalias uevent reporting.

Next time, maybe do a wiki page and point people to it? That being said,
we should probably create a wiki page on the I2C wiki anyhow.
Documenting the current state of affairs. That I would do when I finally
get around to brush up I2C wiki.

> But it seems that for many maintainers this is just an unnecessary churn and they
> don't think there's an issue with the current behaviour. So it feels I'm causing
> more harm than good by keep pushing this.

I understand somehow. They probably were reluctant to change something
that is working, even if it is not pretty. I'm not saying it's not worth
it, yet one needs energy and motivation to push it through.

[toc] | [prev] | [next] | [standalone]


#1602566 — Re: [PATCH 4/4] eeprom: at24: Add OF device ID table

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2017-03-16 16:40 +0100
SubjectRe: [PATCH 4/4] eeprom: at24: Add OF device ID table
Message-ID<tlFFq-lI-69@gated-at.bofh.it>
In reply to#1602488
Hello Wolfram,

On 03/16/2017 12:05 PM, Wolfram Sang wrote:
> 
>>> Rob into the boat if he is OK with updating all DTS files having such an
>>> EEPROM.
>>>
>>
>> Agreed, are you going to take care of that?
> 
> Nope, sorry, no bandwidth. You might ask Lee, he was very interested in
> getting proper I2C OF support upstream.
>

Ok, understandable. Adding Lee and Kieran to cc who were also interested on this.
 
>> up on this task, it has been a big time sink and I had to explain over and over
>> to different people what the problem is with the I2C modalias uevent reporting.
> 
> Next time, maybe do a wiki page and point people to it? That being said,
> we should probably create a wiki page on the I2C wiki anyhow.
> Documenting the current state of affairs. That I would do when I finally
> get around to brush up I2C wiki.
> 

Agreed, I can help writing such a wiki page if you want. I've already requested for
an account at https://i2c.wiki.kernel.org.

>> But it seems that for many maintainers this is just an unnecessary churn and they
>> don't think there's an issue with the current behaviour. So it feels I'm causing
>> more harm than good by keep pushing this.
> 
> I understand somehow. They probably were reluctant to change something

Yes, I don't blame them. It's kind of corner case that most people don't hit it.

One problem though is that this implementation detail leaks into the DTS and DT
binding documents, as we saw people using compatible strings without a vendor
prefix just because they could.

> that is working, even if it is not pretty. I'm not saying it's not worth
> it, yet one needs energy and motivation to push it through.
> 

Yeah, I think I've the energy and motivation but unfortunately also not enough
time :) And likely to have even less time in the near future.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]


#1604779 — Re: [PATCH 4/4] eeprom: at24: Add OF device ID table

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2017-03-20 17:50 +0100
SubjectRe: [PATCH 4/4] eeprom: at24: Add OF device ID table
Message-ID<tn8Fk-7tv-25@gated-at.bofh.it>
In reply to#1602566
Hello,

On 03/16/2017 12:39 PM, Javier Martinez Canillas wrote:
> On 03/16/2017 12:05 PM, Wolfram Sang wrote:

[snip]

>>
>> Next time, maybe do a wiki page and point people to it? That being said,
>> we should probably create a wiki page on the I2C wiki anyhow.
>> Documenting the current state of affairs. That I would do when I finally
>> get around to brush up I2C wiki.
>>
> 
> Agreed, I can help writing such a wiki page if you want. I've already requested for
> an account at https://i2c.wiki.kernel.org.
> 

FYI, I've added a page to the wiki explaining the current issues with the I2C core
MODALIAS uevent reporting and OF match:

https://i2c.wiki.kernel.org/index.php/OF_Modalias

And also linked to the main page in the work-in-progress section:

https://i2c.wiki.kernel.org/index.php/Main_Page#Work_in_progress

Please feel free to add/remove/change anything that you think is missing or isn't
correct for you.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [standalone]


Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel


csiph-web