Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601000 > unrolled thread

[PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

Started byMatthew Giassa <matthew@giassa.net>
First post2017-03-15 03:30 +0100
Last post2017-03-16 04:20 +0100
Articles 14 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa <matthew@giassa.net> - 2017-03-15 03:30 +0100
    [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes. Matthew Giassa <matthew@giassa.net> - 2017-03-15 03:30 +0100
      [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa <matthew@giassa.net> - 2017-03-15 03:30 +0100
        Re: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex  macros with parentheses "Tobin C. Harding" <me@tobin.cc> - 2017-03-15 04:20 +0100
          Re: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex  macros with parentheses Matthew Giassa <matthew@giassa.net> - 2017-03-15 21:30 +0100
    [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa <matthew@giassa.net> - 2017-03-15 03:30 +0100
    Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed  spaces/tabs Greg KH <gregkh@linuxfoundation.org> - 2017-03-16 03:50 +0100
      [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa <matthew@giassa.net> - 2017-03-16 04:20 +0100
        Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed  spaces/tabs Greg KH <gregkh@linuxfoundation.org> - 2017-03-17 07:30 +0100
          Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed  spaces/tabs Greg KH <gregkh@linuxfoundation.org> - 2017-03-17 07:40 +0100
      [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa <matthew@giassa.net> - 2017-03-16 04:20 +0100
      [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes. Matthew Giassa <matthew@giassa.net> - 2017-03-16 04:20 +0100
      [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes Matthew Giassa <matthew@giassa.net> - 2017-03-16 04:20 +0100
        [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa <matthew@giassa.net> - 2017-03-16 04:20 +0100

#1601000 — [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

FromMatthew Giassa <matthew@giassa.net>
Date2017-03-15 03:30 +0100
Subject[PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs
Message-ID<tl6Rj-Sv-3@gated-at.bofh.it>
Removing mixed spaces/hard-tabs used to create a "column alignment" of
macro names and macro values.

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 8e62b10..d811680 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
@@ -20,8 +20,8 @@
 /*					SIOCIWFIRSTPRIV + 2 */
 #define KS_WLAN_GET_FIRM_VERSION	SIOCIWFIRSTPRIV + 3
 #ifdef WPS
-#define KS_WLAN_SET_WPS_ENABLE 		SIOCIWFIRSTPRIV + 4
-#define KS_WLAN_GET_WPS_ENABLE 		SIOCIWFIRSTPRIV + 5
+#define KS_WLAN_SET_WPS_ENABLE		SIOCIWFIRSTPRIV + 4
+#define KS_WLAN_GET_WPS_ENABLE		SIOCIWFIRSTPRIV + 5
 #define KS_WLAN_SET_WPS_PROBE_REQ	SIOCIWFIRSTPRIV + 6
 #endif
 #define KS_WLAN_GET_EEPROM_CKSUM	SIOCIWFIRSTPRIV + 7
-- 
2.7.4

[toc] | [next] | [standalone]

#1601001 — [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes.

FromMatthew Giassa <matthew@giassa.net>
Date2017-03-15 03:30 +0100
Subject[PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes.
Message-ID<tl6Rj-Sv-5@gated-at.bofh.it>
In reply to#1601000
Re-aligning function parameters in function prototypes by inserting
additional hard-tabs to resolve a checkpatch warning.

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 1b68402..1251d7e 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
@@ -60,7 +60,7 @@
 
 int ks_wlan_read_config_file(struct ks_wlan_private *priv);
 int ks_wlan_setup_parameter(struct ks_wlan_private *priv,
-		             unsigned int commit_flag);
+			    unsigned int commit_flag);
 
 #endif /* __KERNEL__ */
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1601004 — [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

FromMatthew Giassa <matthew@giassa.net>
Date2017-03-15 03:30 +0100
Subject[PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses
Message-ID<tl6Rj-Sv-17@gated-at.bofh.it>
In reply to#1601001
Wrapping all complex macros with parentheses to resolve checkpatch
errors. This change, along with the preceding changes in this change
set, resolves all checkpatch warnings and errors for the file.

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++-----------------
 1 file changed, 32 insertions(+), 32 deletions(-)

diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 1251d7e..adc935d 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
@@ -15,43 +15,43 @@
 #include <linux/wireless.h>
 /* The low order bit identify a SET (0) or a GET (1) ioctl.  */
 
-/*					SIOCIWFIRSTPRIV + 0 */
-/* former KS_WLAN_GET_DRIVER_VERSION	SIOCIWFIRSTPRIV + 1 */
-/*					SIOCIWFIRSTPRIV + 2 */
-#define KS_WLAN_GET_FIRM_VERSION	SIOCIWFIRSTPRIV + 3
+/*					(SIOCIWFIRSTPRIV + 0) */
+/* former KS_WLAN_GET_DRIVER_VERSION	(SIOCIWFIRSTPRIV + 1) */
+/*					(SIOCIWFIRSTPRIV + 2) */
+#define KS_WLAN_GET_FIRM_VERSION	(SIOCIWFIRSTPRIV + 3)
 #ifdef WPS
-#define KS_WLAN_SET_WPS_ENABLE		SIOCIWFIRSTPRIV + 4
-#define KS_WLAN_GET_WPS_ENABLE		SIOCIWFIRSTPRIV + 5
-#define KS_WLAN_SET_WPS_PROBE_REQ	SIOCIWFIRSTPRIV + 6
+#define KS_WLAN_SET_WPS_ENABLE		(SIOCIWFIRSTPRIV + 4)
+#define KS_WLAN_GET_WPS_ENABLE		(SIOCIWFIRSTPRIV + 5)
+#define KS_WLAN_SET_WPS_PROBE_REQ	(SIOCIWFIRSTPRIV + 6)
 #endif
-#define KS_WLAN_GET_EEPROM_CKSUM	SIOCIWFIRSTPRIV + 7
-#define KS_WLAN_SET_PREAMBLE		SIOCIWFIRSTPRIV + 8
-#define KS_WLAN_GET_PREAMBLE		SIOCIWFIRSTPRIV + 9
-#define KS_WLAN_SET_POWER_SAVE		SIOCIWFIRSTPRIV + 10
-#define KS_WLAN_GET_POWER_SAVE		SIOCIWFIRSTPRIV + 11
-#define KS_WLAN_SET_SCAN_TYPE		SIOCIWFIRSTPRIV + 12
-#define KS_WLAN_GET_SCAN_TYPE		SIOCIWFIRSTPRIV + 13
-#define KS_WLAN_SET_RX_GAIN		SIOCIWFIRSTPRIV + 14
-#define KS_WLAN_GET_RX_GAIN		SIOCIWFIRSTPRIV + 15
-#define KS_WLAN_HOSTT			SIOCIWFIRSTPRIV + 16	/* unused */
-//#define KS_WLAN_SET_REGION            SIOCIWFIRSTPRIV + 17
-#define KS_WLAN_SET_BEACON_LOST		SIOCIWFIRSTPRIV + 18
-#define KS_WLAN_GET_BEACON_LOST		SIOCIWFIRSTPRIV + 19
+#define KS_WLAN_GET_EEPROM_CKSUM	(SIOCIWFIRSTPRIV + 7)
+#define KS_WLAN_SET_PREAMBLE		(SIOCIWFIRSTPRIV + 8)
+#define KS_WLAN_GET_PREAMBLE		(SIOCIWFIRSTPRIV + 9)
+#define KS_WLAN_SET_POWER_SAVE		(SIOCIWFIRSTPRIV + 10)
+#define KS_WLAN_GET_POWER_SAVE		(SIOCIWFIRSTPRIV + 11)
+#define KS_WLAN_SET_SCAN_TYPE		(SIOCIWFIRSTPRIV + 12)
+#define KS_WLAN_GET_SCAN_TYPE		(SIOCIWFIRSTPRIV + 13)
+#define KS_WLAN_SET_RX_GAIN		(SIOCIWFIRSTPRIV + 14)
+#define KS_WLAN_GET_RX_GAIN		(SIOCIWFIRSTPRIV + 15)
+#define KS_WLAN_HOSTT			(SIOCIWFIRSTPRIV + 16) /* unused */
+//#define KS_WLAN_SET_REGION            (SIOCIWFIRSTPRIV + 17)
+#define KS_WLAN_SET_BEACON_LOST		(SIOCIWFIRSTPRIV + 18)
+#define KS_WLAN_GET_BEACON_LOST		(SIOCIWFIRSTPRIV + 19)
 
-#define KS_WLAN_SET_TX_GAIN		SIOCIWFIRSTPRIV + 20
-#define KS_WLAN_GET_TX_GAIN		SIOCIWFIRSTPRIV + 21
+#define KS_WLAN_SET_TX_GAIN		(SIOCIWFIRSTPRIV + 20)
+#define KS_WLAN_GET_TX_GAIN		(SIOCIWFIRSTPRIV + 21)
 
 /* for KS7010 */
-#define KS_WLAN_SET_PHY_TYPE		SIOCIWFIRSTPRIV + 22
-#define KS_WLAN_GET_PHY_TYPE		SIOCIWFIRSTPRIV + 23
-#define KS_WLAN_SET_CTS_MODE		SIOCIWFIRSTPRIV + 24
-#define KS_WLAN_GET_CTS_MODE		SIOCIWFIRSTPRIV + 25
-/*					SIOCIWFIRSTPRIV + 26 */
-/*					SIOCIWFIRSTPRIV + 27 */
-#define KS_WLAN_SET_SLEEP_MODE		SIOCIWFIRSTPRIV + 28	/* sleep mode */
-#define KS_WLAN_GET_SLEEP_MODE		SIOCIWFIRSTPRIV + 29	/* sleep mode */
-/*					SIOCIWFIRSTPRIV + 30 */
-/*					SIOCIWFIRSTPRIV + 31 */
+#define KS_WLAN_SET_PHY_TYPE		(SIOCIWFIRSTPRIV + 22)
+#define KS_WLAN_GET_PHY_TYPE		(SIOCIWFIRSTPRIV + 23)
+#define KS_WLAN_SET_CTS_MODE		(SIOCIWFIRSTPRIV + 24)
+#define KS_WLAN_GET_CTS_MODE		(SIOCIWFIRSTPRIV + 25)
+/*					(SIOCIWFIRSTPRIV + 26) */
+/*					(SIOCIWFIRSTPRIV + 27) */
+#define KS_WLAN_SET_SLEEP_MODE		(SIOCIWFIRSTPRIV + 28) /* sleep mode */
+#define KS_WLAN_GET_SLEEP_MODE		(SIOCIWFIRSTPRIV + 29) /* sleep mode */
+/*					(SIOCIWFIRSTPRIV + 30) */
+/*					(SIOCIWFIRSTPRIV + 31) */
 
 #ifdef __KERNEL__
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1601013 — Re: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

From"Tobin C. Harding" <me@tobin.cc>
Date2017-03-15 04:20 +0100
SubjectRe: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses
Message-ID<tl7DH-1xm-1@gated-at.bofh.it>
In reply to#1601004
On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote:
> Wrapping all complex macros with parentheses to resolve checkpatch
> errors. This change, along with the preceding changes in this change
> set, resolves all checkpatch warnings and errors for the file.
> 
> Signed-off-by: Matthew Giassa <matthew@giassa.net>
> ---
>  drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++-----------------
>  1 file changed, 32 insertions(+), 32 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
> index 1251d7e..adc935d 100644
> --- a/drivers/staging/ks7010/ks_wlan_ioctl.h
> +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
> @@ -15,43 +15,43 @@
>  #include <linux/wireless.h>
>  /* The low order bit identify a SET (0) or a GET (1) ioctl.  */
>  
> -/*					SIOCIWFIRSTPRIV + 0 */
> -/* former KS_WLAN_GET_DRIVER_VERSION	SIOCIWFIRSTPRIV + 1 */
> -/*					SIOCIWFIRSTPRIV + 2 */
> -#define KS_WLAN_GET_FIRM_VERSION	SIOCIWFIRSTPRIV + 3
> +/*					(SIOCIWFIRSTPRIV + 0) */
> +/* former KS_WLAN_GET_DRIVER_VERSION	(SIOCIWFIRSTPRIV + 1) */
> +/*					(SIOCIWFIRSTPRIV + 2) */
> +#define KS_WLAN_GET_FIRM_VERSION	(SIOCIWFIRSTPRIV + 3)
>  #ifdef WPS
> -#define KS_WLAN_SET_WPS_ENABLE		SIOCIWFIRSTPRIV + 4
> -#define KS_WLAN_GET_WPS_ENABLE		SIOCIWFIRSTPRIV + 5
> -#define KS_WLAN_SET_WPS_PROBE_REQ	SIOCIWFIRSTPRIV + 6
> +#define KS_WLAN_SET_WPS_ENABLE		(SIOCIWFIRSTPRIV + 4)
> +#define KS_WLAN_GET_WPS_ENABLE		(SIOCIWFIRSTPRIV + 5)
> +#define KS_WLAN_SET_WPS_PROBE_REQ	(SIOCIWFIRSTPRIV + 6)
>  #endif
> -#define KS_WLAN_GET_EEPROM_CKSUM	SIOCIWFIRSTPRIV + 7
> -#define KS_WLAN_SET_PREAMBLE		SIOCIWFIRSTPRIV + 8
> -#define KS_WLAN_GET_PREAMBLE		SIOCIWFIRSTPRIV + 9
> -#define KS_WLAN_SET_POWER_SAVE		SIOCIWFIRSTPRIV + 10
> -#define KS_WLAN_GET_POWER_SAVE		SIOCIWFIRSTPRIV + 11
> -#define KS_WLAN_SET_SCAN_TYPE		SIOCIWFIRSTPRIV + 12
> -#define KS_WLAN_GET_SCAN_TYPE		SIOCIWFIRSTPRIV + 13
> -#define KS_WLAN_SET_RX_GAIN		SIOCIWFIRSTPRIV + 14
> -#define KS_WLAN_GET_RX_GAIN		SIOCIWFIRSTPRIV + 15
> -#define KS_WLAN_HOSTT			SIOCIWFIRSTPRIV + 16	/* unused */
> -//#define KS_WLAN_SET_REGION            SIOCIWFIRSTPRIV + 17
> -#define KS_WLAN_SET_BEACON_LOST		SIOCIWFIRSTPRIV + 18
> -#define KS_WLAN_GET_BEACON_LOST		SIOCIWFIRSTPRIV + 19
> +#define KS_WLAN_GET_EEPROM_CKSUM	(SIOCIWFIRSTPRIV + 7)
> +#define KS_WLAN_SET_PREAMBLE		(SIOCIWFIRSTPRIV + 8)
> +#define KS_WLAN_GET_PREAMBLE		(SIOCIWFIRSTPRIV + 9)
> +#define KS_WLAN_SET_POWER_SAVE		(SIOCIWFIRSTPRIV + 10)
> +#define KS_WLAN_GET_POWER_SAVE		(SIOCIWFIRSTPRIV + 11)
> +#define KS_WLAN_SET_SCAN_TYPE		(SIOCIWFIRSTPRIV + 12)
> +#define KS_WLAN_GET_SCAN_TYPE		(SIOCIWFIRSTPRIV + 13)
> +#define KS_WLAN_SET_RX_GAIN		(SIOCIWFIRSTPRIV + 14)
> +#define KS_WLAN_GET_RX_GAIN		(SIOCIWFIRSTPRIV + 15)
> +#define KS_WLAN_HOSTT			(SIOCIWFIRSTPRIV + 16) /* unused */
> +//#define KS_WLAN_SET_REGION            (SIOCIWFIRSTPRIV + 17)
> +#define KS_WLAN_SET_BEACON_LOST		(SIOCIWFIRSTPRIV + 18)
> +#define KS_WLAN_GET_BEACON_LOST		(SIOCIWFIRSTPRIV + 19)
>  
> -#define KS_WLAN_SET_TX_GAIN		SIOCIWFIRSTPRIV + 20
> -#define KS_WLAN_GET_TX_GAIN		SIOCIWFIRSTPRIV + 21
> +#define KS_WLAN_SET_TX_GAIN		(SIOCIWFIRSTPRIV + 20)
> +#define KS_WLAN_GET_TX_GAIN		(SIOCIWFIRSTPRIV + 21)
>  
>  /* for KS7010 */
> -#define KS_WLAN_SET_PHY_TYPE		SIOCIWFIRSTPRIV + 22
> -#define KS_WLAN_GET_PHY_TYPE		SIOCIWFIRSTPRIV + 23
> -#define KS_WLAN_SET_CTS_MODE		SIOCIWFIRSTPRIV + 24
> -#define KS_WLAN_GET_CTS_MODE		SIOCIWFIRSTPRIV + 25
> -/*					SIOCIWFIRSTPRIV + 26 */
> -/*					SIOCIWFIRSTPRIV + 27 */
> -#define KS_WLAN_SET_SLEEP_MODE		SIOCIWFIRSTPRIV + 28	/* sleep mode */
> -#define KS_WLAN_GET_SLEEP_MODE		SIOCIWFIRSTPRIV + 29	/* sleep mode */
> -/*					SIOCIWFIRSTPRIV + 30 */
> -/*					SIOCIWFIRSTPRIV + 31 */
> +#define KS_WLAN_SET_PHY_TYPE		(SIOCIWFIRSTPRIV + 22)
> +#define KS_WLAN_GET_PHY_TYPE		(SIOCIWFIRSTPRIV + 23)
> +#define KS_WLAN_SET_CTS_MODE		(SIOCIWFIRSTPRIV + 24)
> +#define KS_WLAN_GET_CTS_MODE		(SIOCIWFIRSTPRIV + 25)
> +/*					(SIOCIWFIRSTPRIV + 26) */
> +/*					(SIOCIWFIRSTPRIV + 27) */
> +#define KS_WLAN_SET_SLEEP_MODE		(SIOCIWFIRSTPRIV + 28) /* sleep mode */
> +#define KS_WLAN_GET_SLEEP_MODE		(SIOCIWFIRSTPRIV + 29) /* sleep mode */
> +/*					(SIOCIWFIRSTPRIV + 30) */
> +/*					(SIOCIWFIRSTPRIV + 31) */
>  
>  #ifdef __KERNEL__
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Hi Matthew,

Sergei already mentioned the length of the subject line. If I may add
to what he said. 

You may want to make your subject line (about) maximum 50
characters. Also, while we are at it, you may like to wrap your git
log lines at 72 characters.

One other thing, are you using git send-email? Your patches are
chained together.

From Documentation/process/5.Posting.rst

If you have a significant series of patches, it is customary to send
an introductory description as part zero.  This convention is not
universally followed though; if you use it, remember that information
in the introduction does not make it into the kernel changelogs.  So
please ensure that the patches, themselves, have complete changelog
information.

In general, the second and following parts of a multi-part patch
should be sent as a reply to the first part so that they all thread
together at the receiving end.  Tools like git and quilt have commands
to mail out a set of patches with the proper threading.  If you have a
long series, though, and are using git, please stay away from the
--chain-reply-to option to avoid creating exceptionally deep nesting.

Good luck,
Tobin.

[toc] | [prev] | [next] | [standalone]

#1601718 — Re: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

FromMatthew Giassa <matthew@giassa.net>
Date2017-03-15 21:30 +0100
SubjectRe: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses
Message-ID<tlnIt-4nV-1@gated-at.bofh.it>
In reply to#1601013
* Tobin C. Harding <me@tobin.cc> [2017-03-15 14:14:08 +1100]:

>On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote:
>> Wrapping all complex macros with parentheses to resolve checkpatch
>> errors. This change, along with the preceding changes in this change
>> set, resolves all checkpatch warnings and errors for the file.
>>
>> Signed-off-by: Matthew Giassa <matthew@giassa.net>
>> ---
>>  drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++-----------------
>>  1 file changed, 32 insertions(+), 32 deletions(-)
>>
>> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
>> index 1251d7e..adc935d 100644
>> --- a/drivers/staging/ks7010/ks_wlan_ioctl.h
>> +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
>> @@ -15,43 +15,43 @@
>>  #include <linux/wireless.h>
>>  /* The low order bit identify a SET (0) or a GET (1) ioctl.  */
>>
>> -/*					SIOCIWFIRSTPRIV + 0 */
>> -/* former KS_WLAN_GET_DRIVER_VERSION	SIOCIWFIRSTPRIV + 1 */
>> -/*					SIOCIWFIRSTPRIV + 2 */
>> -#define KS_WLAN_GET_FIRM_VERSION	SIOCIWFIRSTPRIV + 3
>> +/*					(SIOCIWFIRSTPRIV + 0) */
>> +/* former KS_WLAN_GET_DRIVER_VERSION	(SIOCIWFIRSTPRIV + 1) */
>> +/*					(SIOCIWFIRSTPRIV + 2) */
>> +#define KS_WLAN_GET_FIRM_VERSION	(SIOCIWFIRSTPRIV + 3)
>>  #ifdef WPS
>> -#define KS_WLAN_SET_WPS_ENABLE		SIOCIWFIRSTPRIV + 4
>> -#define KS_WLAN_GET_WPS_ENABLE		SIOCIWFIRSTPRIV + 5
>> -#define KS_WLAN_SET_WPS_PROBE_REQ	SIOCIWFIRSTPRIV + 6
>> +#define KS_WLAN_SET_WPS_ENABLE		(SIOCIWFIRSTPRIV + 4)
>> +#define KS_WLAN_GET_WPS_ENABLE		(SIOCIWFIRSTPRIV + 5)
>> +#define KS_WLAN_SET_WPS_PROBE_REQ	(SIOCIWFIRSTPRIV + 6)
>>  #endif
>> -#define KS_WLAN_GET_EEPROM_CKSUM	SIOCIWFIRSTPRIV + 7
>> -#define KS_WLAN_SET_PREAMBLE		SIOCIWFIRSTPRIV + 8
>> -#define KS_WLAN_GET_PREAMBLE		SIOCIWFIRSTPRIV + 9
>> -#define KS_WLAN_SET_POWER_SAVE		SIOCIWFIRSTPRIV + 10
>> -#define KS_WLAN_GET_POWER_SAVE		SIOCIWFIRSTPRIV + 11
>> -#define KS_WLAN_SET_SCAN_TYPE		SIOCIWFIRSTPRIV + 12
>> -#define KS_WLAN_GET_SCAN_TYPE		SIOCIWFIRSTPRIV + 13
>> -#define KS_WLAN_SET_RX_GAIN		SIOCIWFIRSTPRIV + 14
>> -#define KS_WLAN_GET_RX_GAIN		SIOCIWFIRSTPRIV + 15
>> -#define KS_WLAN_HOSTT			SIOCIWFIRSTPRIV + 16	/* unused */
>> -//#define KS_WLAN_SET_REGION            SIOCIWFIRSTPRIV + 17
>> -#define KS_WLAN_SET_BEACON_LOST		SIOCIWFIRSTPRIV + 18
>> -#define KS_WLAN_GET_BEACON_LOST		SIOCIWFIRSTPRIV + 19
>> +#define KS_WLAN_GET_EEPROM_CKSUM	(SIOCIWFIRSTPRIV + 7)
>> +#define KS_WLAN_SET_PREAMBLE		(SIOCIWFIRSTPRIV + 8)
>> +#define KS_WLAN_GET_PREAMBLE		(SIOCIWFIRSTPRIV + 9)
>> +#define KS_WLAN_SET_POWER_SAVE		(SIOCIWFIRSTPRIV + 10)
>> +#define KS_WLAN_GET_POWER_SAVE		(SIOCIWFIRSTPRIV + 11)
>> +#define KS_WLAN_SET_SCAN_TYPE		(SIOCIWFIRSTPRIV + 12)
>> +#define KS_WLAN_GET_SCAN_TYPE		(SIOCIWFIRSTPRIV + 13)
>> +#define KS_WLAN_SET_RX_GAIN		(SIOCIWFIRSTPRIV + 14)
>> +#define KS_WLAN_GET_RX_GAIN		(SIOCIWFIRSTPRIV + 15)
>> +#define KS_WLAN_HOSTT			(SIOCIWFIRSTPRIV + 16) /* unused */
>> +//#define KS_WLAN_SET_REGION            (SIOCIWFIRSTPRIV + 17)
>> +#define KS_WLAN_SET_BEACON_LOST		(SIOCIWFIRSTPRIV + 18)
>> +#define KS_WLAN_GET_BEACON_LOST		(SIOCIWFIRSTPRIV + 19)
>>
>> -#define KS_WLAN_SET_TX_GAIN		SIOCIWFIRSTPRIV + 20
>> -#define KS_WLAN_GET_TX_GAIN		SIOCIWFIRSTPRIV + 21
>> +#define KS_WLAN_SET_TX_GAIN		(SIOCIWFIRSTPRIV + 20)
>> +#define KS_WLAN_GET_TX_GAIN		(SIOCIWFIRSTPRIV + 21)
>>
>>  /* for KS7010 */
>> -#define KS_WLAN_SET_PHY_TYPE		SIOCIWFIRSTPRIV + 22
>> -#define KS_WLAN_GET_PHY_TYPE		SIOCIWFIRSTPRIV + 23
>> -#define KS_WLAN_SET_CTS_MODE		SIOCIWFIRSTPRIV + 24
>> -#define KS_WLAN_GET_CTS_MODE		SIOCIWFIRSTPRIV + 25
>> -/*					SIOCIWFIRSTPRIV + 26 */
>> -/*					SIOCIWFIRSTPRIV + 27 */
>> -#define KS_WLAN_SET_SLEEP_MODE		SIOCIWFIRSTPRIV + 28	/* sleep mode */
>> -#define KS_WLAN_GET_SLEEP_MODE		SIOCIWFIRSTPRIV + 29	/* sleep mode */
>> -/*					SIOCIWFIRSTPRIV + 30 */
>> -/*					SIOCIWFIRSTPRIV + 31 */
>> +#define KS_WLAN_SET_PHY_TYPE		(SIOCIWFIRSTPRIV + 22)
>> +#define KS_WLAN_GET_PHY_TYPE		(SIOCIWFIRSTPRIV + 23)
>> +#define KS_WLAN_SET_CTS_MODE		(SIOCIWFIRSTPRIV + 24)
>> +#define KS_WLAN_GET_CTS_MODE		(SIOCIWFIRSTPRIV + 25)
>> +/*					(SIOCIWFIRSTPRIV + 26) */
>> +/*					(SIOCIWFIRSTPRIV + 27) */
>> +#define KS_WLAN_SET_SLEEP_MODE		(SIOCIWFIRSTPRIV + 28) /* sleep mode */
>> +#define KS_WLAN_GET_SLEEP_MODE		(SIOCIWFIRSTPRIV + 29) /* sleep mode */
>> +/*					(SIOCIWFIRSTPRIV + 30) */
>> +/*					(SIOCIWFIRSTPRIV + 31) */
>>
>>  #ifdef __KERNEL__
>>
>> --
>> 2.7.4
>>
>> _______________________________________________
>> devel mailing list
>> devel@linuxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
>Hi Matthew,
>
>Sergei already mentioned the length of the subject line. If I may add
>to what he said.
>
>You may want to make your subject line (about) maximum 50
>characters. Also, while we are at it, you may like to wrap your git
>log lines at 72 characters.
>
>One other thing, are you using git send-email? Your patches are
>chained together.
>
>From Documentation/process/5.Posting.rst
>
>If you have a significant series of patches, it is customary to send
>an introductory description as part zero.  This convention is not
>universally followed though; if you use it, remember that information
>in the introduction does not make it into the kernel changelogs.  So
>please ensure that the patches, themselves, have complete changelog
>information.
>
>In general, the second and following parts of a multi-part patch
>should be sent as a reply to the first part so that they all thread
>together at the receiving end.  Tools like git and quilt have commands
>to mail out a set of patches with the proper threading.  If you have a
>long series, though, and are using git, please stay away from the
>--chain-reply-to option to avoid creating exceptionally deep nesting.
>
>Good luck,
>Tobin.
>

Duely noted. Thank you for the heads-up Tobin.

-Matthew

[toc] | [prev] | [next] | [standalone]

#1601005 — [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space

FromMatthew Giassa <matthew@giassa.net>
Date2017-03-15 03:30 +0100
Subject[PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space
Message-ID<tl6Rj-Sv-7@gated-at.bofh.it>
In reply to#1601000
Removing trailing white space characters in comments to resolve
a checkpatch warning.

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
index d811680..1b68402 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
@@ -1,6 +1,6 @@
 /*
  *   Driver for KeyStream 11b/g wireless LAN
- *   
+ *
  *   Copyright (c) 2005-2008 KeyStream Corp.
  *   Copyright (C) 2009 Renesas Technology Corp.
  *
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1601896 — Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-03-16 03:50 +0100
SubjectRe: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs
Message-ID<tltEe-8qE-19@gated-at.bofh.it>
In reply to#1601000
On Tue, Mar 14, 2017 at 07:25:51PM -0700, Matthew Giassa wrote:
> Removing mixed spaces/hard-tabs used to create a "column alignment" of
> macro names and macro values.
> 
> Signed-off-by: Matthew Giassa <matthew@giassa.net>
> ---
>  drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This does not apply, please rebase your tree and resend.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1601904

FromMatthew Giassa <matthew@giassa.net>
Date2017-03-16 04:20 +0100
Message-ID<tlu7g-yJ-3@gated-at.bofh.it>
In reply to#1601896
Removing mixed spaces/hard-tabs used to create a "column alignment" of
macro names and macro values.

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 8e62b10..d811680 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
@@ -20,8 +20,8 @@
 /*					SIOCIWFIRSTPRIV + 2 */
 #define KS_WLAN_GET_FIRM_VERSION	SIOCIWFIRSTPRIV + 3
 #ifdef WPS
-#define KS_WLAN_SET_WPS_ENABLE 		SIOCIWFIRSTPRIV + 4
-#define KS_WLAN_GET_WPS_ENABLE 		SIOCIWFIRSTPRIV + 5
+#define KS_WLAN_SET_WPS_ENABLE		SIOCIWFIRSTPRIV + 4
+#define KS_WLAN_GET_WPS_ENABLE		SIOCIWFIRSTPRIV + 5
 #define KS_WLAN_SET_WPS_PROBE_REQ	SIOCIWFIRSTPRIV + 6
 #endif
 #define KS_WLAN_GET_EEPROM_CKSUM	SIOCIWFIRSTPRIV + 7
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1603063 — Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-03-17 07:30 +0100
SubjectRe: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs
Message-ID<tlTyF-1Rb-1@gated-at.bofh.it>
In reply to#1601904
On Wed, Mar 15, 2017 at 08:18:08PM -0700, Matthew Giassa wrote:
> Removing mixed spaces/hard-tabs used to create a "column alignment" of
> macro names and macro values.
> 
> Signed-off-by: Matthew Giassa <matthew@giassa.net>
> ---
>  drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This patch does not apply to my tree at all.  Are you sure you are
working against the staging-next branch?  Please rebase and resend.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1603065 — Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-03-17 07:40 +0100
SubjectRe: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs
Message-ID<tlTIl-1W7-1@gated-at.bofh.it>
In reply to#1603063
On Fri, Mar 17, 2017 at 03:22:57PM +0900, Greg KH wrote:
> On Wed, Mar 15, 2017 at 08:18:08PM -0700, Matthew Giassa wrote:
> > Removing mixed spaces/hard-tabs used to create a "column alignment" of
> > macro names and macro values.
> > 
> > Signed-off-by: Matthew Giassa <matthew@giassa.net>
> > ---
> >  drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> This patch does not apply to my tree at all.  Are you sure you are
> working against the staging-next branch?  Please rebase and resend.

Same thing for all of the patches in this series.

greg k-h

[toc] | [prev] | [next] | [standalone]

#1601905 — [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space

FromMatthew Giassa <matthew@giassa.net>
Date2017-03-16 04:20 +0100
Subject[PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space
Message-ID<tlu7g-yJ-7@gated-at.bofh.it>
In reply to#1601896
Removing trailing white space characters in comments to resolve
a checkpatch warning.

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
index d811680..1b68402 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
@@ -1,6 +1,6 @@
 /*
  *   Driver for KeyStream 11b/g wireless LAN
- *   
+ *
  *   Copyright (c) 2005-2008 KeyStream Corp.
  *   Copyright (C) 2009 Renesas Technology Corp.
  *
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1601906 — [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes.

FromMatthew Giassa <matthew@giassa.net>
Date2017-03-16 04:20 +0100
Subject[PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes.
Message-ID<tlu7g-yJ-9@gated-at.bofh.it>
In reply to#1601896
Re-aligning function parameters in function prototypes by inserting
additional hard-tabs to resolve a checkpatch warning.

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 1b68402..1251d7e 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
@@ -60,7 +60,7 @@
 
 int ks_wlan_read_config_file(struct ks_wlan_private *priv);
 int ks_wlan_setup_parameter(struct ks_wlan_private *priv,
-		             unsigned int commit_flag);
+			    unsigned int commit_flag);
 
 #endif /* __KERNEL__ */
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1601908 — [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes

FromMatthew Giassa <matthew@giassa.net>
Date2017-03-16 04:20 +0100
Subject[PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes
Message-ID<tlu7g-yJ-5@gated-at.bofh.it>
In reply to#1601896
The following patches address all outstanding checkpatch warnings/errors
present in drivers/staging/ks7010/ks_wlan_ioctl.h.

This change set has been rebased off of the current master
(69eea5a4ab9c705496e912b55a9d312325de19e6) as per an earlier request,
and the change log formatting has been slightly changed, as per Tobin's
advice.

[toc] | [prev] | [next] | [standalone]

#1601909 — [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

FromMatthew Giassa <matthew@giassa.net>
Date2017-03-16 04:20 +0100
Subject[PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses
Message-ID<tlu7g-yJ-15@gated-at.bofh.it>
In reply to#1601908
Wrapping all complex macros with parentheses to resolve checkpatch
errors. This change, along with the preceding changes in this change
set, resolves all checkpatch warnings and errors for the file.

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++-----------------
 1 file changed, 32 insertions(+), 32 deletions(-)

diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 1251d7e..adc935d 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
@@ -15,43 +15,43 @@
 #include <linux/wireless.h>
 /* The low order bit identify a SET (0) or a GET (1) ioctl.  */
 
-/*					SIOCIWFIRSTPRIV + 0 */
-/* former KS_WLAN_GET_DRIVER_VERSION	SIOCIWFIRSTPRIV + 1 */
-/*					SIOCIWFIRSTPRIV + 2 */
-#define KS_WLAN_GET_FIRM_VERSION	SIOCIWFIRSTPRIV + 3
+/*					(SIOCIWFIRSTPRIV + 0) */
+/* former KS_WLAN_GET_DRIVER_VERSION	(SIOCIWFIRSTPRIV + 1) */
+/*					(SIOCIWFIRSTPRIV + 2) */
+#define KS_WLAN_GET_FIRM_VERSION	(SIOCIWFIRSTPRIV + 3)
 #ifdef WPS
-#define KS_WLAN_SET_WPS_ENABLE		SIOCIWFIRSTPRIV + 4
-#define KS_WLAN_GET_WPS_ENABLE		SIOCIWFIRSTPRIV + 5
-#define KS_WLAN_SET_WPS_PROBE_REQ	SIOCIWFIRSTPRIV + 6
+#define KS_WLAN_SET_WPS_ENABLE		(SIOCIWFIRSTPRIV + 4)
+#define KS_WLAN_GET_WPS_ENABLE		(SIOCIWFIRSTPRIV + 5)
+#define KS_WLAN_SET_WPS_PROBE_REQ	(SIOCIWFIRSTPRIV + 6)
 #endif
-#define KS_WLAN_GET_EEPROM_CKSUM	SIOCIWFIRSTPRIV + 7
-#define KS_WLAN_SET_PREAMBLE		SIOCIWFIRSTPRIV + 8
-#define KS_WLAN_GET_PREAMBLE		SIOCIWFIRSTPRIV + 9
-#define KS_WLAN_SET_POWER_SAVE		SIOCIWFIRSTPRIV + 10
-#define KS_WLAN_GET_POWER_SAVE		SIOCIWFIRSTPRIV + 11
-#define KS_WLAN_SET_SCAN_TYPE		SIOCIWFIRSTPRIV + 12
-#define KS_WLAN_GET_SCAN_TYPE		SIOCIWFIRSTPRIV + 13
-#define KS_WLAN_SET_RX_GAIN		SIOCIWFIRSTPRIV + 14
-#define KS_WLAN_GET_RX_GAIN		SIOCIWFIRSTPRIV + 15
-#define KS_WLAN_HOSTT			SIOCIWFIRSTPRIV + 16	/* unused */
-//#define KS_WLAN_SET_REGION            SIOCIWFIRSTPRIV + 17
-#define KS_WLAN_SET_BEACON_LOST		SIOCIWFIRSTPRIV + 18
-#define KS_WLAN_GET_BEACON_LOST		SIOCIWFIRSTPRIV + 19
+#define KS_WLAN_GET_EEPROM_CKSUM	(SIOCIWFIRSTPRIV + 7)
+#define KS_WLAN_SET_PREAMBLE		(SIOCIWFIRSTPRIV + 8)
+#define KS_WLAN_GET_PREAMBLE		(SIOCIWFIRSTPRIV + 9)
+#define KS_WLAN_SET_POWER_SAVE		(SIOCIWFIRSTPRIV + 10)
+#define KS_WLAN_GET_POWER_SAVE		(SIOCIWFIRSTPRIV + 11)
+#define KS_WLAN_SET_SCAN_TYPE		(SIOCIWFIRSTPRIV + 12)
+#define KS_WLAN_GET_SCAN_TYPE		(SIOCIWFIRSTPRIV + 13)
+#define KS_WLAN_SET_RX_GAIN		(SIOCIWFIRSTPRIV + 14)
+#define KS_WLAN_GET_RX_GAIN		(SIOCIWFIRSTPRIV + 15)
+#define KS_WLAN_HOSTT			(SIOCIWFIRSTPRIV + 16) /* unused */
+//#define KS_WLAN_SET_REGION            (SIOCIWFIRSTPRIV + 17)
+#define KS_WLAN_SET_BEACON_LOST		(SIOCIWFIRSTPRIV + 18)
+#define KS_WLAN_GET_BEACON_LOST		(SIOCIWFIRSTPRIV + 19)
 
-#define KS_WLAN_SET_TX_GAIN		SIOCIWFIRSTPRIV + 20
-#define KS_WLAN_GET_TX_GAIN		SIOCIWFIRSTPRIV + 21
+#define KS_WLAN_SET_TX_GAIN		(SIOCIWFIRSTPRIV + 20)
+#define KS_WLAN_GET_TX_GAIN		(SIOCIWFIRSTPRIV + 21)
 
 /* for KS7010 */
-#define KS_WLAN_SET_PHY_TYPE		SIOCIWFIRSTPRIV + 22
-#define KS_WLAN_GET_PHY_TYPE		SIOCIWFIRSTPRIV + 23
-#define KS_WLAN_SET_CTS_MODE		SIOCIWFIRSTPRIV + 24
-#define KS_WLAN_GET_CTS_MODE		SIOCIWFIRSTPRIV + 25
-/*					SIOCIWFIRSTPRIV + 26 */
-/*					SIOCIWFIRSTPRIV + 27 */
-#define KS_WLAN_SET_SLEEP_MODE		SIOCIWFIRSTPRIV + 28	/* sleep mode */
-#define KS_WLAN_GET_SLEEP_MODE		SIOCIWFIRSTPRIV + 29	/* sleep mode */
-/*					SIOCIWFIRSTPRIV + 30 */
-/*					SIOCIWFIRSTPRIV + 31 */
+#define KS_WLAN_SET_PHY_TYPE		(SIOCIWFIRSTPRIV + 22)
+#define KS_WLAN_GET_PHY_TYPE		(SIOCIWFIRSTPRIV + 23)
+#define KS_WLAN_SET_CTS_MODE		(SIOCIWFIRSTPRIV + 24)
+#define KS_WLAN_GET_CTS_MODE		(SIOCIWFIRSTPRIV + 25)
+/*					(SIOCIWFIRSTPRIV + 26) */
+/*					(SIOCIWFIRSTPRIV + 27) */
+#define KS_WLAN_SET_SLEEP_MODE		(SIOCIWFIRSTPRIV + 28) /* sleep mode */
+#define KS_WLAN_GET_SLEEP_MODE		(SIOCIWFIRSTPRIV + 29) /* sleep mode */
+/*					(SIOCIWFIRSTPRIV + 30) */
+/*					(SIOCIWFIRSTPRIV + 31) */
 
 #ifdef __KERNEL__
 
-- 
2.7.4

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web