Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600919 > unrolled thread

Re: [PATCH v4 05/11] mm: thp: enable thp migration in generic path

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 05/11] mm: thp: enable thp migration in generic path kbuild test robot <lkp@intel.com> - 2017-03-14 22:30 +0100
    Re: [PATCH v4 05/11] mm: thp: enable thp migration in generic path Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-15 10:10 +0100

#1600919 — Re: [PATCH v4 05/11] mm: thp: enable thp migration in generic path

[Multipart message — attachments visible in raw view] — view raw

Hi Naoya,

[auto build test WARNING on mmotm/master]
[also build test WARNING on next-20170310]
[cannot apply to v4.11-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Zi-Yan/mm-page-migration-enhancement-for-thp/20170315-042736
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

   In file included from fs/proc/task_mmu.c:15:0:
   include/linux/swapops.h: In function 'remove_migration_pmd':
   include/linux/swapops.h:209:2: warning: 'return' with a value, in function returning void
     return 0;
     ^
   include/linux/swapops.h: In function 'swp_entry_to_pmd':
>> include/linux/swapops.h:223:2: warning: missing braces around initializer [-Wmissing-braces]
     return (pmd_t){ 0 };
     ^
   include/linux/swapops.h:223:2: warning: (near initialization for '(anonymous).pmd') [-Wmissing-braces]

vim +223 include/linux/swapops.h

   203	}
   204	
   205	static inline void remove_migration_pmd(struct page_vma_mapped_walk *pvmw,
   206			struct page *new)
   207	{
   208		BUILD_BUG();
 > 209		return 0;
   210	}
   211	
   212	static inline void pmd_migration_entry_wait(struct mm_struct *m, pmd_t *p) { }
   213	
   214	static inline swp_entry_t pmd_to_swp_entry(pmd_t pmd)
   215	{
   216		BUILD_BUG();
   217		return swp_entry(0, 0);
   218	}
   219	
   220	static inline pmd_t swp_entry_to_pmd(swp_entry_t entry)
   221	{
   222		BUILD_BUG();
 > 223		return (pmd_t){ 0 };
   224	}
   225	
   226	static inline int is_pmd_migration_entry(pmd_t pmd)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [next] | [standalone]

#1601149

On Tue, Mar 14, 2017 at 10:55 PM, Zi Yan <zi.yan@cs.rutgers.edu> wrote:
>>>> include/linux/swapops.h:223:2: warning: missing braces around initializer [-Wmissing-braces]
>>      return (pmd_t){ 0 };
>>      ^
>>    include/linux/swapops.h:223:2: warning: (near initialization for '(anonymous).pmd') [-Wmissing-braces]
>
> I do not have any warning with gcc 6.3.0. This seems to be a GCC bug
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119).

I guess you need

    return (pmd_t) { { 0, }};

to kill the warning.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web