Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1596175 > unrolled thread

Re: [PATCHv2 4/5] mfd: altr_a10sr: Add Arria10 DevKit Reset Controller

Started byThor Thayer <thor.thayer@linux.intel.com>
First post2017-03-09 17:10 +0100
Last post2017-03-13 16:30 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCHv2 4/5] mfd: altr_a10sr: Add Arria10 DevKit Reset  Controller Thor Thayer <thor.thayer@linux.intel.com> - 2017-03-09 17:10 +0100
    Re: [PATCHv2 4/5] mfd: altr_a10sr: Add Arria10 DevKit Reset  Controller Philipp Zabel <p.zabel@pengutronix.de> - 2017-03-13 15:50 +0100
      Re: [PATCHv2 4/5] mfd: altr_a10sr: Add Arria10 DevKit Reset  Controller Thor Thayer <thor.thayer@linux.intel.com> - 2017-03-13 16:30 +0100

#1596175 — Re: [PATCHv2 4/5] mfd: altr_a10sr: Add Arria10 DevKit Reset Controller

FromThor Thayer <thor.thayer@linux.intel.com>
Date2017-03-09 17:10 +0100
SubjectRe: [PATCHv2 4/5] mfd: altr_a10sr: Add Arria10 DevKit Reset Controller
Message-ID<tj8Nz-7yD-9@gated-at.bofh.it>
Hi Lee,

On 02/28/2017 08:42 AM, Philipp Zabel wrote:
> On Wed, 2017-02-22 at 11:10 -0600, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Add Peripheral PHY Reset Controller to the Arria10
>> Development Kit System Resource Chip's MFD.
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> ---
>> v2  Changes to commit header & body for clarification.
>> ---
>>  drivers/mfd/altera-a10sr.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
>> index 06e1f7f..96e7d2c 100644
>> --- a/drivers/mfd/altera-a10sr.c
>> +++ b/drivers/mfd/altera-a10sr.c
>> @@ -33,6 +33,10 @@
>>  		.name = "altr_a10sr_gpio",
>>  		.of_compatible = "altr,a10sr-gpio",
>>  	},
>> +	{
>> +		.name = "altr_a10sr_reset",
>> +		.of_compatible = "altr,a10sr-reset",
>> +	},
>>  };
>>
>>  static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg)
>
> Lee, should this be merged through the reset tree? Otherwise I'll just
> pick up patches 1-3.
>
> regards
> Philipp
>

Any comments on this patch and the patch series?

Thanks,

Thor

[toc] | [next] | [standalone]


#1599481

FromPhilipp Zabel <p.zabel@pengutronix.de>
Date2017-03-13 15:50 +0100
Message-ID<tkzsm-1TD-27@gated-at.bofh.it>
In reply to#1596175
On Thu, 2017-03-09 at 10:03 -0600, Thor Thayer wrote:
> Hi Lee,
> 
> On 02/28/2017 08:42 AM, Philipp Zabel wrote:
> > On Wed, 2017-02-22 at 11:10 -0600, thor.thayer@linux.intel.com wrote:
> >> From: Thor Thayer <thor.thayer@linux.intel.com>
> >>
> >> Add Peripheral PHY Reset Controller to the Arria10
> >> Development Kit System Resource Chip's MFD.
> >>
> >> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
> >> ---
> >> v2  Changes to commit header & body for clarification.
> >> ---
> >>  drivers/mfd/altera-a10sr.c | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
> >> index 06e1f7f..96e7d2c 100644
> >> --- a/drivers/mfd/altera-a10sr.c
> >> +++ b/drivers/mfd/altera-a10sr.c
> >> @@ -33,6 +33,10 @@
> >>  		.name = "altr_a10sr_gpio",
> >>  		.of_compatible = "altr,a10sr-gpio",
> >>  	},
> >> +	{
> >> +		.name = "altr_a10sr_reset",
> >> +		.of_compatible = "altr,a10sr-reset",
> >> +	},
> >>  };
> >>
> >>  static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg)
> >
> > Lee, should this be merged through the reset tree? Otherwise I'll just
> > pick up patches 1-3.

I have picked up patches 1-3, but I only just noticed that patch 1 also
would require Lee's ack for me to submit this.

regards
Philipp

[toc] | [prev] | [next] | [standalone]


#1599510

FromThor Thayer <thor.thayer@linux.intel.com>
Date2017-03-13 16:30 +0100
Message-ID<tkA54-2tH-9@gated-at.bofh.it>
In reply to#1599481
On 03/13/2017 09:42 AM, Philipp Zabel wrote:
> On Thu, 2017-03-09 at 10:03 -0600, Thor Thayer wrote:
>> Hi Lee,
>>
>> On 02/28/2017 08:42 AM, Philipp Zabel wrote:
>>> On Wed, 2017-02-22 at 11:10 -0600, thor.thayer@linux.intel.com wrote:
>>>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>>>
>>>> Add Peripheral PHY Reset Controller to the Arria10
>>>> Development Kit System Resource Chip's MFD.
>>>>
>>>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>>>> ---
>>>> v2  Changes to commit header & body for clarification.
>>>> ---
>>>>  drivers/mfd/altera-a10sr.c | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
>>>> index 06e1f7f..96e7d2c 100644
>>>> --- a/drivers/mfd/altera-a10sr.c
>>>> +++ b/drivers/mfd/altera-a10sr.c
>>>> @@ -33,6 +33,10 @@
>>>>  		.name = "altr_a10sr_gpio",
>>>>  		.of_compatible = "altr,a10sr-gpio",
>>>>  	},
>>>> +	{
>>>> +		.name = "altr_a10sr_reset",
>>>> +		.of_compatible = "altr,a10sr-reset",
>>>> +	},
>>>>  };
>>>>
>>>>  static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg)
>>>
>>> Lee, should this be merged through the reset tree? Otherwise I'll just
>>> pick up patches 1-3.
>
> I have picked up patches 1-3, but I only just noticed that patch 1 also
> would require Lee's ack for me to submit this.
>
> regards
> Philipp
>
OK. Thanks Philipp.

FWIW, Patch 1 was acked by Rob Herring on 2/27/2017 although I 
understand that Lee may want a say in this as well.

Thanks again for reviewing and picking up those patches!

Thor

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web